HLJ2009 updated this revision to Diff 149665.
HLJ2009 added a comment.
update test case.
Repository:
rC Clang
https://reviews.llvm.org/D46805
Files:
include/clang/Basic/Attr.td
test/Sema/attr-alias-has.c
test/Sema/attr-alias.c
Index: test/Sema/attr-alias.c
===
HLJ2009 added a comment.
In https://reviews.llvm.org/D46805#1117091, @sunfish wrote:
> In https://reviews.llvm.org/D46805#1115681, @rsmith wrote:
>
> > In https://reviews.llvm.org/D46805#1113358, @aaron.ballman wrote:
> >
> > > @rsmith -- do the object file formats listed look correct to you?
> >
HLJ2009 updated this revision to Diff 147773.
HLJ2009 added a comment.
Herald added a subscriber: aheejin.
listing the object formats that *do* support aliases seems reasonable
Repository:
rC Clang
https://reviews.llvm.org/D46805
Files:
include/clang/Basic/Attr.td
test/Sema/attr-alias-ha
HLJ2009 added inline comments.
Comment at: include/clang/Basic/Attr.td:566-567
-def Alias : Attr {
+// We do not support alias attribute on Apple platform, so we exclude the
platform.
+def Alias : Attr, TargetSpecificAttr {
let Spellings = [GCC<"alias">];
r
HLJ2009 marked 4 inline comments as done.
HLJ2009 added inline comments.
Comment at: include/clang/Basic/Attr.td:327
+def TargetDarwinNegative : TargetArch<["x86", "x86_64"]> {
+ let OSes = ["MacOSX"];
+ let Negated = 1;
aaron.ballman wrote:
> I would expect th
HLJ2009 created this revision.
HLJ2009 added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
I tested the alias attribute on my own Apple laptop (Target:
x86_64-apple-darwin17.5.0). First, I use __has_attribute to test that the alias
is usable or not. The test code is as follo
