[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. In D70366#1971137 , @dexonsmith wrote: > In D70366#1970758 , @jdoerfert wrote: > > > In D70366#1970526 , @dexonsmith > > wrote: > > > > > In

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. While adding tests to clang I realized the attribute is not working as intended when using an optimization level of zero, because clang adds the noinline attribute to all functions. In this case the optimizer cannot distinguish between functions originally marked

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion updated this revision to Diff 254217. LevitatingLion added a comment. Herald added a reviewer: sstefan1. I rebased my changes onto 49d00824bbb , renamed the attribute to 'alwaysinline_recursively', and added some

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. Thanks for the ping. I hadn't looked at this since, but I'll update the patch this weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added inline comments. Comment at: llvm/docs/LangRef.rst:1428 can prove that the call/invoke cannot call a convergent function. +``flatten`` +This attribute is similar to ``alwaysinline``, but applies recursively to arsenm wrote: > It's no

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion created this revision. LevitatingLion added reviewers: jdoerfert, pcc, chandlerc. LevitatingLion added projects: LLVM, clang. Herald added subscribers: dexonsmith, steven_wu, haicheng, hiraditya, eraman, nhaehnle, jvesely, mehdi_amini, arsenm. This adds a new 'flatten' attribute, w