[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2379793 , @aaron.ballman wrote: > I think the issue is that ASTNodeTraverser is visiting all of the attribute > arguments (around ASTNodeTraverse.h:726) and your patch also visits them (as > part of what's emitted from

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky added a comment. > It seems surprising to me that you'd have to add those declarations; I think > that's a layering violation. There's something somewhat strange going on here > that I think is related. Given: > [...] > Notice how the annotate attribute has an `inner` array with the argu

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky updated this revision to Diff 302558. aronsky retitled this revision from "Include attribute details when dumping AST in JSON" to "Include more attribute details when dumping AST in JSON". aronsky edited the summary of this revision. aronsky added a comment. Updated the relevant unit-test

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2357060 , @aaron.ballman wrote: > In D90221#2356110 , @aronsky wrote: > >> In D90221#2356062 , @lebedev.ri >> wrote: >> >>> Are there tes

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2356062 , @lebedev.ri wrote: > Are there tests missing? Quite possible. I followed the trail of the existing functions to figure out the difference between JSON and textual dumping, and tried replicating everything in

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky created this revision. aronsky added reviewers: aaron.ballman, steveire. aronsky created this object with visibility "All Users". Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. aronsky requested review of this revision. AST dumps in JSON format were missing a