This revision was automatically updated to reflect the committed changes.
Closed by commit rGdd6bcdbf2171: [Attributes] Remove AttrSyntax and migrate
uses to AttributeCommonInfo::Syntax… (authored by lgrey).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
lgrey updated this revision to Diff 434036.
lgrey added a comment.
Add assert
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126902/new/
https://reviews.llvm.org/D126902
Files:
clang/include/clang/Basic/Attributes.h
clang/lib/Basic/Attributes.cpp
clang/lib/Lex/PPMacroExpansion.cpp
lgrey added inline comments.
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3368
+ fn("C2x", C2x);
+ OS << "case AttributeCommonInfo::Syntax::AS_Keyword:\n";
+ OS << "case AttributeCommonInfo::Syntax::AS_ContextSensitiveKeyword:\n";
Not sure if this sho
lgrey created this revision.
lgrey added a reviewer: aaron.ballman.
lgrey added a project: clang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
lgrey requested review of this revision.
Herald added a subscriber: cfe-commits.
This is setup for allowing `hasAttribute` to work fo
lgrey added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242
} else if (D.getLTOMode() == LTOK_Thin)
// If we are using thin LTO, then create a directory instead.
TmpPathName = D.GetTemporaryDirectory("thinlto");
thakis w
