[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e336511f18a: [clang] Recognize ppc32 as valid mcpu value (authored by LemonBoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100933/new/ https://reviews.

[PATCH] D100933: [clang] Recognize ppc32 as valid mcpu value

LemonBoy created this revision. LemonBoy added a reviewer: PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. LemonBoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ppc32` cpu model was introduced a while ago in a9321059

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

LemonBoy added a comment. In D99465#2654633 , @craig.topper wrote: > We can't use preprocessor defines in the intrinsic header files. It prevents > being able to use the intrinsics with attribute(target("avx512f,vaes")). > What's preventing __m512i from

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

LemonBoy created this revision. LemonBoy added a reviewer: craig.topper. LemonBoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AMD Zen3 architecture supports the VAES instruction set but not the 512bit variants, add a feature gate on __

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Looks good to me - thanks! Great! Can you please commit this for me as I have no commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 298133. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp Index: clang/unittests/Frontend/ASTUnitTest.cpp

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 297959. LemonBoy added a comment. Use `ScopeExit` instead of a bare lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Perhaps this'd be more robust with ScopeExit? Not really, `OnError` is not executed when/if the function succeeds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-c

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping with some more reviewers, hoping to land this in time for LLVM 99. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 259374. LemonBoy added a comment. Fix a C&P error in the attached test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cp

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy created this revision. LemonBoy added a reviewer: rsmith. LemonBoy added a project: clang. Herald added a subscriber: cfe-commits. Some early errors during the ASTUnit creation were not transferred to the `FailedParseDiagnostic` so when the code in `LoadFromCommandLine` swaps its conten