[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

antiagainst accepted this revision. antiagainst added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93591/new/ https://reviews.llvm.org/D93591 ___ cfe-commits mailing list cfe

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

antiagainst requested changes to this revision. antiagainst added a comment. This revision now requires changes to proceed. Awesome! I just have a few nits left now. Marked as blocking because we need to avoid change Clang code. Comment at: clang-tools-extra/clangd/ClangdLSPSe

[PATCH] D83088: Introduce CfgTraits abstraction

antiagainst added inline comments. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; rriddle wrote: > This seems to have broken the GCC5 build: > https://buildkite.com/mlir/mlir-core/bu

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

antiagainst accepted this revision. antiagainst added a comment. This revision is now accepted and ready to land. LGTM for SPIR-V side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.llvm.org/D84780 __

[PATCH] D79830: Add support of __builtin_expect_with_probability

antiagainst added inline comments. Comment at: llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:62 +// __builtin_expect +return {LikelyBranchWeight, UnlikelyBranchWeight}; + } else { FYI: this breaks GCC5: https://buildkite.com/mlir/mlir-core/builds/

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

This revision was automatically updated to reflect the committed changes. antiagainst marked an inline comment as done. Closed by commit rGdf71000d7d5d: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops (authored by antiagainst). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 4 inline comments as done. antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:125 + +PatternMatchResult SingleWorkgroupReduction::matchAndRewrite( +linalg::GenericOp genericOp, ArrayRef operands, -

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 241431. antiagainst marked 16 inline comments as done. antiagainst added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/i

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:182 + // Perform the group reduction operation. + Value groupOperation = rewriter.create( + loc, originalInputType.getElementType(), spirv::Scope::Subgroup,

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added a comment. Messed up the revision history with Arc... Please show the diff between "Diff 1" and "Diff 4" to check the modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 240861. antiagainst added a comment. Clean up unrelated commits again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/include/mlir/Conversion/LinalgTo

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 2 inline comments as done. antiagainst added inline comments. Herald added a reviewer: mclow.lists. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static inline bool areAllValuesMemref(Operation *op) { + auto isOfMemrefType = [

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

zlei added a comment. LGTM https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits