[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

wlei added subscribers: modimo, hoy, wlei. wlei added a comment. Hi @ahatanak We recently hit an issue of inconsistent codegen related with this optimization. In one build, Clang frontend generates different llvm IRs for the same function that is originally from one header file. It turned out t

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

wlei added a comment. Tested this and confirmed the issue I reported is gone, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

wlei added a comment. In D126907#3805606 , @erichkeane wrote: > Now fully runs libcxx modules configuration as well, and passes the > minimization examples from @wlei . > > @wlei and anyone else: can you please try running this against your > workload

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

wlei added a comment. In D131714#3754399 , @ahatanak wrote: > Fixed in f051c1ded40970169cda84b0966331ae7ad424ed > . It > looks like gcc, unlike clang, doesn't allow passing `-Werror=fo

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

wlei added a comment. Hi @ahatanak This or its child diff broke our internal build, I saw it was reverted but the reapplied diff(https://github.com/llvm/llvm-project/commit/2e9df860468425645dcd1b241c5dbf76c072e314) still broke our build. see the log: (1)floatundidf.S.o : FAILED: projects/

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wlei accepted this revision. wlei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 __

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

wlei added a comment. In D109386#2990504 , @rnk wrote: > This seems incorrect: a weak VH won't have the same semantics, it will just > drop the comdat associativity when the underlying global changes type. @rnk Thanks. Here I tried to use `WeakTrackingV

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei added a comment. @rnk @rjmccall Thanks for the suggestion! @wenlei Thanks for the helpful example! Changed to use ValueHandle(WeakTrackingVH) for this, please see if this looks good to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10938

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei updated this revision to Diff 371455. wlei added a comment. change to use ValueHandle for associated data Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109386/new/ https://reviews.llvm.org/D109386 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei created this revision. Herald added subscribers: hoy, wenlei, lxfind. wlei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109386 Files: clang/lib/CodeGen/CodeGenModul