Re: [PATCH] D14419: [Extension --> Completeness] Relax rules for writeonce candidacy...

2015-11-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39724. lvoufo added a comment. Fix patch (wrong one submitted initially). http://reviews.llvm.org/D14419 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invaria

[PATCH] D14419: [Extension --> Completeness] Relax rules for writeonce candidacy...

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: chandlerc, majnemer, dberlin, nlewycky. lvoufo added a subscriber: cfe-commits. After D14418, Remove restriction for writeonce semantics to objects with no non-trivial methods... http://reviews.llvm.org/D14419 Files: include/clang/AST/Dec

[PATCH] D14418: [Extension] Optimizing const objects with mutable fields.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: dberlin, chandlerc, nlewycky, majnemer. lvoufo added a subscriber: cfe-commits. Adapting solution from const members of non-const objects (D13618) http://reviews.llvm.org/D14418 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunctio

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39467. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39466. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39465. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39464. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39463. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo added a reviewer: majnemer. lvoufo updated this revision to Diff 39458. lvoufo added a comment. Reify computed invariant offsets, and while we're at it, cleanup InvariantArgs: move it out of CodeGenModule.h and remove Offsets member field since offsets are already in the start instruction

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo removed a reviewer: majnemer. lvoufo updated this revision to Diff 39411. lvoufo added a comment. Remove commented out line -- Offsets not needed on invariant_end calls after all. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37024. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37023. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

[PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: dberlin, chandlerc, majnemer, nlewycky. lvoufo added a subscriber: cfe-commits. Continued from D13603... http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeG

Re: [PATCH] D13614: [Extension] Optimizing passed by-value const objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37012. lvoufo added a comment. Update patch (Wrong patch submitted earlier). http://reviews.llvm.org/D13614 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/const-invariant.cpp test/CodeGenObjCXX/arc.mm Index: test/CodeGenObjCXX/arc.mm ==

[PATCH] D13614: [Extension] Optimizing passed by-value const objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: chandlerc, dberlin, majnemer, nicholas. lvoufo added a subscriber: cfe-commits. Continued from D13603, handling functions that are defined with const parameters. http://reviews.llvm.org/D13614 Files: include/clang/AST/DeclCXX.h include/c

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37005. lvoufo added a comment. All formatting changes should be done by now. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDecl

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37004. lvoufo added a comment. Fix regression test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37003. lvoufo added a comment. Fix unit test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGe

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 36991. lvoufo added a comment. Clang-formatted. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExprA

[PATCH] D13603: [Introduction] C++ Const object optimization.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: chandlerc, majnemer, dberlin, nlewycky. lvoufo added a subscriber: cfe-commits. Based on the design doc at https://docs.google.com/a/google.com/document/d/1vtoMypqHjkUle8KldKWYYwJF750KkYnEKffQKoYs6jo/edit?usp=sharing, it handles non-member co