[clang] 45d6792 - [clang][OpenMP] Fix signed v unsigned comparison

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2025-07-07T09:15:10-05:00 New Revision: 45d679218aebdac5c9818be211d8e3a517c944c3 URL: https://github.com/llvm/llvm-project/commit/45d679218aebdac5c9818be211d8e3a517c944c3 DIFF: https://github.com/llvm/llvm-project/commit/45d679218aebdac5c9818be211d8e3a517c944c3

[clang] [llvm] [clang][OpenMP] Issue a warning when parsing future directive spelling (PR #146933)

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/146933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Issue a warning when parsing future directive spelling (PR #146933)

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146933 >From 0e9eab649f7a515c0697c3fe58309c478108f6b1 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 2 Jul 2025 09:43:32 -0500 Subject: [PATCH 01/12] [Frontend][OpenMP] Implement directive name parser

[clang] [llvm] [clang][OpenMP] Issue a warning when parsing future directive spelling (PR #146933)

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/146933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Use DirectiveNameParser to parse directive names (PR #146779)

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/146779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Use DirectiveNameParser to parse directive names (PR #146779)

2025-07-07 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Hi @alexey-bataev, did you miss this one? https://github.com/llvm/llvm-project/pull/146779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Use DirectiveNameParser to parse directive names (PR #146779)

2025-07-03 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146779 >From 0e9eab649f7a515c0697c3fe58309c478108f6b1 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 2 Jul 2025 09:43:32 -0500 Subject: [PATCH 01/11] [Frontend][OpenMP] Implement directive name parser

[clang] [llvm] [clang][OpenMP] Use DirectiveNameParser to parse directive names (PR #146779)

2025-07-03 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146779 >From 0e9eab649f7a515c0697c3fe58309c478108f6b1 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 2 Jul 2025 09:43:32 -0500 Subject: [PATCH 01/11] [Frontend][OpenMP] Implement directive name parser

[clang] [llvm] [clang][OpenMP] Use DirectiveNameParser to parse directive names (PR #146779)

2025-07-03 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/146779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/146390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146390 >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH 1/3] [STLForwardCompat] Implement llvm::type_identity, NFC

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146390 >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH 1/2] [STLForwardCompat] Implement llvm::type_identity, NFC

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
@@ -36,6 +36,16 @@ template using remove_cvref_t // NOLINT(readability-identifier-naming) = typename llvm::remove_cvref::type; +template kparzysz wrote: Done https://github.com/llvm/llvm-project/pull/146390 _

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/146390 >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH 1/2] [STLForwardCompat] Implement llvm::type_identity, NFC

[clang] [llvm] [STLForwardCompat] Implement llvm::type_identity (PR #146390)

2025-06-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/146390 A basic implementation until we get it in `std` in C++20. >From 7c294619f38984e26264d25524f6f5e79397f297 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 30 Jun 2025 11:45:43 -0500 Subject: [PATCH

[clang] [flang] [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. https://github.com/llvm/llvm-project/pull/144915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-25 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: @alexey-bataev This is ready now. https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-25 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/141772 >From e9dc0bebc958f62dec8d4cda38d8187e8675d474 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 28 May 2025 09:20:00 -0500 Subject: [PATCH 1/8] [OpenMP] Add directive spellings introduced in spec v

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-25 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-23 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I'll add a unit test that prints all affected directives with different versions. https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-23 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: We don't parse them yet, that will require additional changes. This patch will only affect what names are printed in diagnostic messages. https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-23 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: @alexey-bataev, could you clarify what tests you had in mind? https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] DRAFT: [flang][OpenMP] Remove experimental warning (PR #144915)

2025-06-20 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang][flang-driver][mlir][OpenMP] atomic control support (PR #143441)

2025-06-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz commented: Please remove 'amdgpu' from variable and function names. These options may be useful for other targets as well. https://github.com/llvm/llvm-project/pull/143441 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-16 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Hi @alexey-bataev, could you check if you're ok with this? I had to modify a few clang tests to accommodate this change. https://github.com/llvm/llvm-project/pull/141772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-12 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/141772 >From e9dc0bebc958f62dec8d4cda38d8187e8675d474 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 28 May 2025 09:20:00 -0500 Subject: [PATCH 1/7] [OpenMP] Add directive spellings introduced in spec v

[clang] [llvm] [OpenMP] Add directive spellings introduced in spec v6.0 (PR #141772)

2025-06-10 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/141772 >From e9dc0bebc958f62dec8d4cda38d8187e8675d474 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 28 May 2025 09:20:00 -0500 Subject: [PATCH 1/6] [OpenMP] Add directive spellings introduced in spec v

[clang-tools-extra] 11e804f - [clang-doc] Fix build break with BUILD_SHARED_LIBS=ON

2025-05-28 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2025-05-28T08:13:31-05:00 New Revision: 11e804fcabce11a9fdfb4033263ef1e502cc8a72 URL: https://github.com/llvm/llvm-project/commit/11e804fcabce11a9fdfb4033263ef1e502cc8a72 DIFF: https://github.com/llvm/llvm-project/commit/11e804fcabce11a9fdfb4033263ef1e502cc8a72

[clang] [llvm] [clang][OpenMP] Improve handling of non-C/C++ directives (PR #139961)

2025-05-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Improve handling of non-C/C++ directives (PR #139961)

2025-05-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Treat "workshare" as unknown OpenMP directive (PR #139793)

2025-05-14 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Treat "workshare" as unknown OpenMP directive (PR #139793)

2025-05-13 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/139793 The "workshare" construct is only present in Fortran. The common OpenMP code does treat it as any other directive, but in clang we need to reject it, and do so gracefully before it encounters an internal asser

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-02 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: @alexey-bataev Are you ok with the change in SemaOpenMP? https://github.com/llvm/llvm-project/pull/138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/138179 >From d991e966f12229fc4a9cc1114e3fa4651bc9d59d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 1 May 2025 11:42:12 -0500 Subject: [PATCH 1/2] [OpenMP] Remove "alternativeName" from Clause and Dir

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/138179 The "alternativeName" was introduced ~5 years ago in D82405, and at the moment it has only one use, the one that the original change introduced. OpenMP 6.0 spec has introduced different spellings of some direc

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-04-05 Thread Krzysztof Parzyszek via cfe-commits
@@ -2759,6 +2759,19 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( OpenMPClauseKind CKind = Tok.isAnnotation() ? OMPC_unknown : getOpenMPClauseKind(PP.getSpelling(Tok)); + // C

[clang] [llvm] [clang] [OpenMP] New OpenMP 6.0 self_maps clause - CodeGen (PR #134131)

2025-04-03 Thread Krzysztof Parzyszek via cfe-commits
@@ -236,6 +236,8 @@ enum class OpenMPOffloadMappingFlags : uint64_t { // dynamic. // This is an OpenMP extension for the sake of OpenACC support. OMP_MAP_OMPX_HOLD = 0x2000, + /// Self directs mapping without creating a separate device copy. + OMP_MAP_SELF = 0x4000, ---

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-03-24 Thread Krzysztof Parzyszek via cfe-commits
@@ -1657,6 +1657,10 @@ def err_omp_expected_colon : Error<"missing ':' in %0">; def err_omp_missing_comma : Error< "missing ',' after %0">; def err_omp_expected_context_selector : Error<"expected valid context selector in %0">; +def err_omp_unknown_clause +: Error<"unkn

[clang] [flang] [flang/clang] Adding use of Clang's diagnostics in Flang (PR #130593)

2025-03-11 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > In general, we aim to only depend on libClangDriver and move it to LLVM so > that Flang need not depend on Clang or its libraries. If this patch increases > the dependency on Clang it might not be acceptable. Agreed. 👍 @JDPailleux: It may a good idea to extract the diagnost

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-21 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM, but please address Alexey's comments before merging. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [OpenMP] Allow GPUs to be targeted directly via `-fopenmp`. (PR #122149)

2025-01-09 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > All that said, there are two cases to consider wrt. the standard: > > 1. The initial device is the CPU and the code compiled here is just part of a > GPU library, or > 2. the initial device is the GPU and the code compiled here is just part of > the "host code". > > For 1),

[clang] Update OpenMPSupport.rst (PR #122174)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
@@ -343,6 +343,124 @@ implementation. | task | nowait clause on taskwait | :part:`partial` | parsing/sema done: D131830, D141531 | +--+---

[clang] [OpenMP] Allow GPUs to be targeted directly via `-fopenmp`. (PR #122149)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: To me this looks like compilation for a host, except the GPU is the host. The only functions that could be called from such a CU would be the top-level ones, not any of the auto-generated one. Additionally, the host wouldn't support offload, so we'd need to do something about

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
@@ -2158,6 +2158,10 @@ enum CXCursorKind { */ CXCursor_OMPAssumeDirective = 309, + /** OpenMP assume directive. + */ + CXCursor_OMPStripeDirective = 310, kparzysz wrote: Please add this to `clang/bindings/python/clang/cindex.py` as well. https://git

[clang] [flang] [Flang][OpenMP] Add -fopenmp-default-none command line flag (PR #120287)

2024-12-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Is NONE special enough to have a dedicated option, or could we have `-fopenmp-default=` for any dsa? https://github.com/llvm/llvm-project/pull/120287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] Clarify use of contractions in diagnostic messages (PR #116803)

2024-11-19 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Here's another thing---could there be tools that try to parse the messages (e.g. something that runs clang and presents the messages to the user in some form)? Having a policy such as "single quotes only come in pairs" could make it easier. I don't know if that's something we

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/116623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I (visually) looked at all occurrences of `can\>` in the td files, and I didn't see any occurring at the end of a line, or in a place where a `not` could be pasted into the message following the `can`. It was a "best effort" inspection, but there weren't too many of these, so

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/116623 See https://discourse.llvm.org/t/cant-cannot-can-not-in-diagnostic-messages/83171 >From 489d5a0c1f9cb53e87cbbf30e8ddec83820e0326 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 18 Nov 2024 07:51

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

2024-10-30 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I was able to see the internal bug report. This shows up when some code on Windows runs clang (via a library call), and it ends up crashing due to stack overflow. The crash happens in this function, in "__chkstk" to be exact. https://github.com/llvm/llvm-project/pull/114285 _

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

2024-10-30 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Don't see how or why this would introduce stackusage. std::string temporaries > should be avoided whenever possible The code that's included afterwards contains a lot of comparisons with string literals: ``` if (Name == "aarch64_sve_pcs" && getSyntax() == AttributeCommonInfo:

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-21 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Thanks! I was getting these warning too. https://github.com/llvm/llvm-project/pull/112942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-21 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. https://github.com/llvm/llvm-project/pull/112942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

2024-10-08 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Right, use `git clang-format`, that will take care of formatting the file > over time without creating churn. I think the number of changes is relatively small for a file this size. The churn here is comparable to that created by a "normal" patch... https://github.com/llvm/

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-09-27 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Yeah I was actually wondering if I should go for something like this: > > ```c > #ifdef __NVPTX__ > uint32_t nvptx_get_thread_id_x() { return __nvvm_ptx_read_sreg_tid_x(); } > #define IMPL nvptx > #endif > uint32_t gpu_get_thread_id_x() { return ##IMPL##_get_thread_id_x(); } >

[clang] [llvm] [clang][OpenMP] Prototype #1 of directive splitting (PR #108855)

2024-09-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Right now it's about 400 check-clang failures for all changes together. Adding AST nodes for directives in templates causes 12 failures (mostly in slightly differing diagnostics), adding capturing regions for all constituents will have its own share, but the majority comes fro

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/109003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/109003 >From d9bb31da5c897aad0dbc55781df2341db75aad6d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 12 Aug 2024 08:46:12 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock f

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/109003 Change the loop ``` if (isOpenMPExecutableDirective) for (Clause) if (Clause is kind1) multi line do something1; else if (Clause is kind2) ... ...

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-07 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/106786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-06 Thread Krzysztof Parzyszek via cfe-commits
@@ -6060,69 +6057,55 @@ StmtResult SemaOpenMP::ActOnOpenMPExecutableDirective( return StmtError(); // Generate list of implicitly defined firstprivate variables. VarsWithInheritedDSA = DSAChecker.getVarsWithInheritedDSA(); +VariableImplicitInfo ImpInfo = DSACh

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-06 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/106786 >From 92e82b249836b4f17d1e13a927ca3e8300f671ee Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 30 Aug 2024 13:57:13 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Simplify handling of implicit DSA/map

[clang] [clang][OpenMP] `masked` and `master` are not capturing (PR #106787)

2024-09-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/106787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/106786 >From 92e82b249836b4f17d1e13a927ca3e8300f671ee Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 30 Aug 2024 13:57:13 -0500 Subject: [PATCH] [clang][OpenMP] Simplify handling of implicit DSA/mapping

[clang] [clang][OpenMP] `masked` and `master` are not capturing (PR #106787)

2024-09-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/106787 >From 053374ee88af47515a54e5c5ba3b680e252862bf Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 30 Jul 2024 15:02:38 -0500 Subject: [PATCH] [clang][OpenMP] `masked` and `master` are not capturing

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-08-30 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/106786 Create `VariableImplicitInfo` to hold the data. Most of it is used all at once, so aggregating it seems like a good idea. >From 92e82b249836b4f17d1e13a927ca3e8300f671ee Mon Sep 17 00:00:00 2001 From: Krzysztof

[clang] 1c3955f - [clang][OpenMP] Fix typo in comment, NFC

2024-08-20 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-20T10:07:19-05:00 New Revision: 1c3955f9dff9b653be88d5dea5bc3cd007904e90 URL: https://github.com/llvm/llvm-project/commit/1c3955f9dff9b653be88d5dea5bc3cd007904e90 DIFF: https://github.com/llvm/llvm-project/commit/1c3955f9dff9b653be88d5dea5bc3cd007904e90

[clang] [Clang] Fix ICE in SemaOpenMP with structured binding (PR #104822)

2024-08-19 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM. We will complain when someone tries to capture a structure binding anyway. https://github.com/llvm/llvm-project/pull/104822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [OpenMP] Diagnostic check for imperfect loop collapse (PR #96087)

2024-08-19 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > I think you're right for this particular test case, but I don't think that > solution works in general. Consider something like: > > ``` > int arr1[N][N], arr2[N]; > > #pragma omp parallel for collapse(2) > { > for (int i = 0; i < N; i++) { > arr2[i] = i; > for (int

[clang] de5ea2d - [clang][OpenMP] Change /* ParamName */ to /*ParamName=*/, NFC

2024-08-18 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-18T10:48:49-05:00 New Revision: de5ea2d122c31e1551654ff506c33df299f351b8 URL: https://github.com/llvm/llvm-project/commit/de5ea2d122c31e1551654ff506c33df299f351b8 DIFF: https://github.com/llvm/llvm-project/commit/de5ea2d122c31e1551654ff506c33df299f351b8

[clang] e05307f - [clang][OpenMP] Avoid multiple calls to getCurrentDirective in DSAChecker, NFC

2024-08-18 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-18T10:25:52-05:00 New Revision: e05307f6633ca405834a4fd24d858ffb676c9170 URL: https://github.com/llvm/llvm-project/commit/e05307f6633ca405834a4fd24d858ffb676c9170 DIFF: https://github.com/llvm/llvm-project/commit/e05307f6633ca405834a4fd24d858ffb676c9170

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/101058 >From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 29 Jul 2024 13:29:09 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Rename `varlists` to `varlist`, NFC

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/101058 >From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 29 Jul 2024 13:29:09 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Rename `varlists` to `varlist`, NFC

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/101058 It returns a range of variables (via Expr*), not a range of lists. >From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 29 Jul 2024 13:29:09 -0500 Subjec

[clang] [clang][OpenMP] Mark all SIMD regions as non-throwing (PR #100162)

2024-07-23 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Linux failure went away, but a Windows issue was introduced upstream in the meantime. None of that has to do with this PR. https://github.com/llvm/llvm-project/pull/100162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang][OpenMP] Mark all SIMD regions as non-throwing (PR #100162)

2024-07-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/100162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Mark all SIMD regions as non-throwing (PR #100162)

2024-07-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/100162 >From 8e99d0743c69f3e5981deb24f501ea993567522e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 23 Jul 2024 09:56:53 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Mark all SIMD regions as non-throwing

[clang] [clang][OpenMP] Mark all SIMD regions as non-throwing (PR #100162)

2024-07-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/100162 >From 8e99d0743c69f3e5981deb24f501ea993567522e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 23 Jul 2024 09:56:53 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Mark all SIMD regions as non-throwing

[clang] [clang][OpenMP] Mark all SIMD regions as non-throwing (PR #100162)

2024-07-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/100162 [4.5:75:19], [5.0:114:3], [5.1:137:21], [5.2:235:30] "No exception can be raised in the **simd** region." >From 8e99d0743c69f3e5981deb24f501ea993567522e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date:

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

2024-07-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

2024-07-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

2024-07-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

2024-07-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/99905 Given "loop" construct, clang will try to treat it as "for", "distribute" or "simd", depending on either the implied binding, or the bind clause if present. This patch moves the code that performs this construc

[clang] e970989 - [clang][OpenMP] Avoid names that hide existing variables, NFC

2024-07-22 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-22T10:22:20-05:00 New Revision: e9709899db7d4a8b1c36475e90e4a934335f3d95 URL: https://github.com/llvm/llvm-project/commit/e9709899db7d4a8b1c36475e90e4a934335f3d95 DIFF: https://github.com/llvm/llvm-project/commit/e9709899db7d4a8b1c36475e90e4a934335f3d95

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98500 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] 97ebc97 - [clang[OpenMP] Revert accidentally included changes from previous commit

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-15T09:10:11-05:00 New Revision: 97ebc9794941d9e73792ab9deab7abafaf750a17 URL: https://github.com/llvm/llvm-project/commit/97ebc9794941d9e73792ab9deab7abafaf750a17 DIFF: https://github.com/llvm/llvm-project/commit/97ebc9794941d9e73792ab9deab7abafaf750a17

[clang] [clang][OpenMP] Simplify check for taskloop in `ActOnOpenMPLoopInitia… (PR #98633)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/98633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Simplify check for taskloop in `ActOnOpenMPLoopInitia… (PR #98633)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/98633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98500 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/98500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >