[PATCH] D89453: Fix hidden-redecls.m test for some environments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6030a075164c: Fix hidden-redecls.m test for some environments (authored by kschwarz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D89453: Fix hidden-redecls.m test for some environments

kschwarz added a comment. Yes, I'll commit it tomorrow, thanks for the review @akyrtzi! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89453/new/ https://reviews.llvm.org/D89453 ___ cfe-commits mailing li

[PATCH] D89453: Fix hidden-redecls.m test for some environments

kschwarz created this revision. kschwarz added reviewers: bnbarham, akyrtzi. Herald added subscribers: arphaman, dexonsmith. Herald added a project: clang. kschwarz requested review of this revision. This test was failing in our CI environment, because Jenkins mounts the workspaces into Docker co

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz added a comment. I brought this to the mailing list (http://lists.llvm.org/pipermail/llvm-dev/2020-March/140032.html) but didn't get an answer there. @arsenm, have you any comments regarding @rjmccall's last comment regarding the sizes of pointers in different address spaces? Reposi

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz updated this revision to Diff 269789. kschwarz added a comment. Herald added a project: LLVM. Brining this up again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76283/new/ https://reviews.llvm.org/D76283 Files: clang/test/CodeGen/c11at

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz added a comment. Correct, it will still miscompile even with this change. I see two options: either 1) extend GlobalISel to select to the appropriate type, or 2) declare this as illegal LLVM IR in the first place. 1. will introduce an implicit truncation of the i64 argument (same as Se

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz created this revision. kschwarz added reviewers: rjmccall, gchatelet, aemerson. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. The IR builder hard-coded the type of the `len` argument of the memory function instrinsics to i64 for several builder functions. Du

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

kschwarz added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") Hi @JDevlieghere, we've noticed that with this patch check-llvm isn't added to check-all anymore by default.