[PATCH] D60748: Fix i386 struct and union parameter alignment

2019-09-24 Thread Konstantin Belousov via Phabricator via cfe-commits
kib added a comment. In fact, can we have an option controlling this ? Does it have anything to do with -malign-data gcc switch ? We do want to be able to optionally generate code ABI-compatible with modern gcc, per user discretion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

2019-01-30 Thread Konstantin Belousov via Phabricator via cfe-commits
kib added a comment. I do not like this. The change makes binaries linked by the default toolchain on FreeBSD, non-standard compliant. Several hundred bytes is not too high cost to pay for not having issues with all tools still not adapted to GNU hash (and never be). Repository: rC Clang