[PATCH] D145302: [clangd] Add library for clangd main function

raj.khem added a comment. indeed, broke my CI with same issue. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > /usr/bin/ld: > tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTw

[PATCH] D149272: [clang] Call printName to get name of Decl

raj.khem added a comment. This would fix https://github.com/llvm/llvm-project/issues/62192 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 ___ cfe-commits maili

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

raj.khem added a comment. In D140875#4065824 , @hokein wrote: > In D140875#4065763 , @ckandeler > wrote: > >> With this, I now get: >> FAILED: bin/clangd-fuzzer >> : && /usr/lib/icecream/libexec/icecc/bin/c++ -f

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

raj.khem added a comment. In D71387#3755056 , @lewis-revill wrote: > I believe this patch is still relevant/necessary when using LTO for RISCV, so > can I ask if @khchen is able to update it to rebase/address the feedback? If > not, are there are any ob

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

raj.khem added a comment. Herald added a project: All. In D119590#3316050 , @JonChesterfield wrote: > Cross compilers are a hazard here. I'd expect there to be a fairly long list > of magic flags you need to pass to clang to get it to find the right >

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

raj.khem created this revision. raj.khem added reviewers: jhuber6, JonChesterfield. Herald added subscribers: guansong, yaxunl. raj.khem requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenEmbedd

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

raj.khem added a comment. http://sprunge.us/FJzZXL is a file from harfbuzz and it warns a.cc:28670:32: error: variable 'supp_size' set but not used [-Werror,-Wunused-but-set-variable] unsigned int size0, size1, supp_size = 0; I do not have -Werror enabled but it still is reported as err

[PATCH] D102568: [Driver] Delete -mimplicit-it=

raj.khem accepted this revision. raj.khem added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102568/new/ https://reviews.llvm.org/D102568 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

raj.khem accepted this revision. raj.khem added a comment. This revision is now accepted and ready to land. once you fix the clang-format issue reported this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99308/new/ https://reviews

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. @MaskRay how should be proceeed here Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65572/new/ https://reviews.llvm.org/D65572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D71369: Detect libdl from cmake variable

raj.khem abandoned this revision. raj.khem added a comment. 0073c293a401774ac96b4b3d27f05e13f379f98e has fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71369/new/ http

[PATCH] D46914: Run scan-view on systems with python3 as default python provider

raj.khem abandoned this revision. raj.khem added a comment. it works with python3 too, perhaps it would be good to ask for python3 instead Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46914/new/ https://reviews.llvm.org/D46914 __

[PATCH] D18174: Fix libcxx build on musl

raj.khem abandoned this revision. raj.khem added a comment. this is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18174/new/ https://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D70764: build: reduce CMake handling for zlib

raj.khem added a comment. In D70764#1807405 , @smeenai wrote: > In D70764#1803559 , @raj.khem wrote: > > > this is now in master, and I am seeing build failures in cross-building > > clang, e.g. when building clang

[PATCH] D70764: build: reduce CMake handling for zlib

raj.khem added a comment. this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g. FAILED: bin/llvm

[PATCH] D71965: include missing for std::abort

raj.khem created this revision. raj.khem added reviewers: kadircet, jfb. raj.khem added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman, dexonsmith, jkorous, ilya-biryukov. Herald added a project: clang. Fixes TOPDIR/build/tmp/work-shared/llvm-project-sou

[PATCH] D71369: Detect libdl from cmake variable

raj.khem created this revision. raj.khem added a reviewer: espindola. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This helps in getting right settings for libdl irrespective of platform it also fixes build with -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. In D65699#1662915 , @dalias wrote: > That's a separate issue of clang having a slight types-ABI mismatch with some > 32-bit archs whose original ABIs used `long` instead of `int` for `wchar_t`. > The wrong header order makes it

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. one issue I now see is that when we have some thing like static const struct { const wchar_t *name; int (*func)(EditLine *, int, const wchar_t **); } cmds[] = { { L"bind", map_bind}, { L"echotc",

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. Can we bring this to 9.x release branch as well please ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. In D65572#1614003 , @compnerd wrote: > `-ldl` doesn't work on all platforms (e.g. android, FreeBSD, etc). > `-lpthread` is wrong - if you want to add that, I think that we need to > improve the `-thread-model` flag in clang fir

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem added a comment. In D65572#1610169 , @rengolin wrote: > This is a tricky one which may vary depending on the libraries available on > different systems. Which toolchain is this? Can you add more context? @rengolin this is when building linux sy

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem created this revision. raj.khem added a reviewer: rengolin. raj.khem added a project: clang. Herald added subscribers: cfe-commits, jfb. when trying to use llvm libunwind via clang driver option --unwindlib and using -static together, linking fails with missing symbols libunwind/src/R

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto &Entry : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if (llvm::sys::pa

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto &Entry : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if (llvm::sys::pa

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

raj.khem added a comment. Can this be backported to release_60 branch too please ? Repository: rL LLVM https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D46914: Run scan-view on systems with python3 as default python provider

raj.khem created this revision. Herald added a subscriber: cfe-commits. Linux Distros e.g. archlinux have started to use python3 as default python interpreter, therefore we need to be specific if we need python2 Repository: rC Clang https://reviews.llvm.org/D46914 Files: tools/scan-view/b

[PATCH] D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro

raj.khem added a comment. There is a proposed fix for glibc's assert here https://sourceware.org/ml/libc-alpha/2017-07/msg00227.html despite that, this patch in general seems useful. https://reviews.llvm.org/D35564 ___ cfe-commits mailing list cfe

[PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. @EricWF you are right. I have made the changes accordingly. This patch can be ignored. https://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D18174: Fix libcxx build on musl

raj.khem updated this revision to Diff 108853. raj.khem edited the summary of this revision. Herald added a reviewer: EricWF. https://reviews.llvm.org/D18174 Files: include/__mutex_base Index: include/__mutex_base === --- include