This revision was automatically updated to reflect the committed changes.
Closed by commit rL292184: [Test patch] Inline hot functions in libcxx
shared_ptr (authored by hxy9243).
Changed prior to commit:
https://reviews.llvm.org/D24991?vs=84569&id=84622#toc
Repository:
rL LLVM
https://revie
hxy9243 updated this revision to Diff 84569.
hxy9243 added a comment.
Addresses comments from @mclow.lists.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
Index: libcxx/src/memory.cpp
===
hxy9243 updated this revision to Diff 84565.
hxy9243 added a comment.
Addresses comments from @EricWF.
Thanks for reviewing, I know it takes a lot of energy. It helped me learn a lot.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
hxy9243 updated this revision to Diff 84004.
hxy9243 added a comment.
Minor changes on function names. Rename __libcpp_atomic_* to
__libcpp_atomic_refcount_*.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
Index: libcxx/src/memory
hxy9243 marked an inline comment as done.
hxy9243 added a comment.
Addressed previous issues in the comments. The patch still shows consistent
perf uplift in proprietary benchmark on shared_ptr.
@EricWF @sebpop @hiraditya Any thoughts?
Repository:
rL LLVM
https://reviews.llvm.org/D24991
hxy9243 updated this revision to Diff 82962.
hxy9243 marked 4 inline comments as done.
hxy9243 added a comment.
Minor fix, remove redundant inlines.
Repository:
rL LLVM
https://reviews.llvm.org/D24991
Files:
libcxx/include/memory
libcxx/src/memory.cpp
Index: libcxx/src/memory.cpp
==
hxy9243 set the repository for this revision to rL LLVM.
hxy9243 updated this revision to Diff 82958.
hxy9243 added a comment.
Move the header back in its place, and only copy over necessary parts. Now call
__atomic_add_fetch from inside the functions.
Repository:
rL LLVM
https://reviews.llv
