[PATCH] D100028: [docs] Update clazy's URL in the external Clang examples page

2021-04-07 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100028/new/ https://reviews.llvm.org/D100028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D49890: Clang-Tidy Export Problem

2019-11-13 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. Is someone willing to pick up this patch again? It's still an issue. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49890/new/ https://reviews.llvm.org/D49890 ___ cfe-commits maili

[PATCH] D37482: run-clang-tidy: Use check_call instead of check_output

2017-11-27 Thread Kevin Funk via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319148: run-clang-tidy: Use check_call instead of check_output (authored by kfunk). Repository: rL LLVM https://reviews.llvm.org/D37482 Files: clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.

[PATCH] D15729: Load compiler plugins in ASTUnit, too

2017-11-27 Thread Kevin Funk via Phabricator via cfe-commits
kfunk planned changes to this revision. kfunk added a comment. Marking this Diff properly -- it needs more work. https://reviews.llvm.org/D15729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D37482: run-clang-tidy: Use check_call instead of check_output

2017-09-20 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. Bump? This is a trivial one https://reviews.llvm.org/D37482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37479: run-clang-tidy: Report progress

2017-09-05 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. In https://reviews.llvm.org/D37479#861580, @Eugene.Zelenko wrote: > I think will be good idea to introduce command line option to control > progress display: turn it off, show in absolute numbers or percents. Honestly, I don't think this configurability is necessary. I'd

[PATCH] D37138: Make run-clang-tidy compatible with Python 3.x

2017-09-05 Thread Kevin Funk via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312532: Make run-clang-tidy compatible with Python 3.x (authored by kfunk). Changed prior to commit: https://reviews.llvm.org/D37138?vs=112677&id=113841#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-25 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. Seems to have worked: Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ... A test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml A test/clang-apply-replacements/invalid-files.cpp M c

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-25 Thread Kevin Funk via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308974: [clang-tidy] clang-apply-replacements: Don't insert null entry (authored by kfunk). Repository: rL LLVM https://reviews.llvm.org/D35194 Files: clang-tools-extra/trunk/clang-apply-replacemen

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-25 Thread Kevin Funk via Phabricator via cfe-commits
kfunk updated this revision to Diff 108061. kfunk added a comment. Addressed concerns https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clang-apply-replacements/inval

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-11 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:296 + << "' doesn't exist. Ignoring...\n"; +} continue; yawanng wrote: > Maybe add some error message here if it's not an existenc

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-10 Thread Kevin Funk via Phabricator via cfe-commits
kfunk updated this revision to Diff 105929. kfunk added a comment. Remove unnecessary `sed` line in test driver https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clan

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

2017-07-10 Thread Kevin Funk via Phabricator via cfe-commits
kfunk updated this revision to Diff 105928. kfunk added a comment. Add test https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml test/clang-apply-replacements/invalid-files.c

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

2017-02-28 Thread Kevin Funk via Phabricator via cfe-commits
kfunk added a comment. @erikjv Ready for review? Does this reliably fix https://bugreports.qt.io/browse/QTCREATORBUG-15449? https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-12-20 Thread Kevin Funk via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290172: Fix for clang_Cursor_getSpellingNameRange() (authored by kfunk). Changed prior to commit: https://reviews.llvm.org/D18462?vs=51608&id=82071#toc Repository: rL LLVM https://reviews.llvm.org/D