ksuther updated this revision to Diff 72578.
ksuther added a comment.
Added a unit test.
https://reviews.llvm.org/D15643
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
ksuther updated this revision to Diff 68930.
ksuther added a comment.
This was accepted a few months ago but it got buried and was never committed.
The diff has been updated so that it can be committed cleanly.
https://reviews.llvm.org/D15643
Files:
lib/Format/TokenAnnotator.cpp
Index: lib/
ksuther created this revision.
ksuther added a reviewer: djasper.
ksuther added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The following Obj-C methods will get formatted with an extra space between the
right paren and the name:
`- (void)delete:(id)sender`
`- (void)export:(id)s
ksuther updated this revision to Diff 49928.
ksuther added a comment.
Thanks for the comments. I've made some changes that eliminates reverting
r236598 and instead makes the behavior part of `IndentNestedBlocks`. That
allows the Google Obj-C code style
(https://google.github.io/styleguide/objcg
ksuther added a comment.
Thank you! I don't have commit access, so could this be committed by someone
who does?
http://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ksuther created this revision.
ksuther added a reviewer: djasper.
ksuther added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Changes to clang-format's Objective-C block formatting over the past year have
made clang-format's output deviate from what is expected (in my opinion).
T
ksuther added a comment.
This patch got buried, giving it a bump to see if anyone can take a look at it.
http://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
ksuther created this revision.
ksuther added a reviewer: djasper.
ksuther added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fixes the following:
BOOL (^aaa)(void) = ^BOOL {
};
The first BOOL's token was getting set to TT_FunctionAnnotationRParen
incorrectly, which was causing
ksuther created this revision.
ksuther added reviewers: cfe-commits, djasper.
Herald added a subscriber: klimek.
The BraceWrapping of the Linux style is incorrect. This appeared in r248802
when the custom BraceWrapping options were added.
This is what r248801 looked like:
clang-format -style="{
ksuther added a comment.
This patch is still awaiting a commit. Sorry to repeatedly post about this,
just don't want it to get lost.
Thanks!
http://reviews.llvm.org/D12501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ksuther added a comment.
Do I need to do anything else about this and http://reviews.llvm.org/D12489, or
do they eventually get committed by someone else? Thanks!
http://reviews.llvm.org/D12501
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ksuther added a comment.
I don't, this and http://reviews.llvm.org/D12489 are my first patch submissions.
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
ksuther added a comment.
I do not.
http://reviews.llvm.org/D12501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ksuther added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:377
@@ -376,1 +376,3 @@
+(!Contexts.back().ColonIsDictLiteral ||
+ Style.Language != FormatStyle::LK_Cpp)) ||
Style.Language == FormatStyle::LK_Proto) &&
--
ksuther added a comment.
Adding another comment in hopes of getting some visibility on this. Do I need
to add other people as reviewers?
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ksuther added a comment.
Adding another comment in hopes of getting some visibility on this. Do I need
to add other people as reviewers?
http://reviews.llvm.org/D12501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ksuther updated this revision to Diff 33947.
ksuther added a comment.
Added two tests: One of a for/in loop with a cast, and one without.
http://reviews.llvm.org/D12489
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
ksuther created this revision.
ksuther added a reviewer: djasper.
ksuther added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fixes this bug: https://llvm.org/bugs/show_bug.cgi?id=22647
The following dictionary was getting formatted oddly:
NSDictionary *query = @{
(__bridge i
ksuther added a reviewer: djasper.
ksuther added a comment.
This is my first commit and I'm trying to figure out the system, hope I'm doing
this right.
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
19 matches
Mail list logo
