[PATCH] D157620: [Thumb1] Do not allow Armv6-m XO and PI code

2023-08-22 Thread Keith Walker via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc5db2bedd5: [Thumb1] Do not allow Armv6-m XO and PI code (authored by keith.walker.arm). Herald added a project: clang. Herald added a subscriber:

[PATCH] D101532: [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML

2021-04-30 Thread Keith Walker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG109bf25e2c42: [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML (authored by keith.walker.arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-24 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. I feel that using a -g option make more sense. Maybe -gdwarf-frame, or -gdwarf-frame-always might be more user friendly as it relates more to the DWARF section created rather than the section content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. This change fixed a failing build here, so it looks correct to me. Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D42569: [ARM] disable FPU features when using soft floating point.

2018-02-12 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. review request ping. There was one line in the compiler itself which is different to what had been previously reviewed and approved ... so hopefully that change is easily reviewed. However this change also resulted in updates to the associated tests, and the

[PATCH] D42569: [ARM] disable FPU features when using soft floating point.

2018-01-26 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm created this revision. keith.walker.arm added reviewers: efriedma, compnerd. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar, aemerson. This change was orignally approved in Differential Revision https://reviews.llvm.org/D40256 and committed in r319420 and subseq

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

2017-11-28 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm updated this revision to Diff 124579. keith.walker.arm added a comment. > What are these disabled "R-UN" lines? Oops! They shouldn't have been disabled in the patch. > Do we really need to check every combination like this? I don't think the > underlying logic actually varies

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

2017-11-22 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm updated this revision to Diff 123936. keith.walker.arm added a comment. I have updated the patch with the suggested change to use a list of features to disable. I checked that LLVM does indeed implicitly disable features if they are dependent on a feature that is explicitly dis

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

2017-11-21 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:406 +const bool HasVFPv4 = (std::find(ItBegin, ItEnd, "+vfpv4") != ItEnd); +const bool HasFParmv8 = (std::find(ItBegin, ItEnd, "+fp-armv8") != ItEnd); +const bool HasFullFP16 = (

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

2017-11-20 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. To be compatible with GCC if soft floating point is in effect any FPU specified is effectively ignored, eg, -mfloat-abi=soft -fpu=neon If any floating point features which require FPU hardwa