kiszk added a comment.
Thank you very much at
https://github.com/llvm/llvm-project/commit/8f77dc459e31aad6daab89a124fa92067916274c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77470/new/
https://reviews.llvm.org/D77470
__
kiszk added a comment.
I have done in https://reviews.llvm.org/D77458
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77482/new/
https://reviews.llvm.org/D77482
___
cfe-commits mailing list
cfe-commits@l
kiszk updated this revision to Diff 255120.
kiszk added a comment.
This include the fix of the build failure at
http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/7450/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Afuchsia-multiple-inheritance.cpp
CHANGES SINCE LA
kiszk updated this revision to Diff 255119.
kiszk added a comment.
This includes a fix to break the llvm build
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
Files:
clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp
clang-tools-ex
kiszk added a comment.
Thank you for letting me know. I will do that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77482/new/
https://reviews.llvm.org/D77482
___
cfe-commits mailing list
cfe-commits@l
kiszk added a subscriber: sammccall.
kiszk added a comment.
Herald added a subscriber: wuzish.
@sammccall, I am very sorry that I led to the build break due to my
misoperation in https://reviews.llvm.org/D77458
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
kiszk created this revision.
Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb,
arphaman, jkorous, kbarton, nemanjai.
Herald added a project: clang.
This also includes the build failure due to https://reviews.llvm.org/D77458
Repository:
rG LLVM Github Monorepo
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rGabdd042bb7a5: [clang-tools-extra] NFC: Fix trivial typo in
documents and comments (authored by kiszk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/ne
kiszk updated this revision to Diff 255071.
kiszk added a comment.
address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
Files:
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceChe
kiszk added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48
// Inherits from multiple concrete classes.
-// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting mulitple classes that
aren't pure virtual is discouraged [
kiszk added a comment.
Sorry, I made a mistake. This should not be reviewed. This should be deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77471/new/
https://reviews.llvm.org/D77471
___
cfe-com
kiszk created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
kiszk added a comment.
kiszk removed a project: clang.
kiszk removed a subscriber: cfe-commits.
Herald added a project: clang.
Sorry, I made a mistake. This should not be reviewed. This should be de
kiszk created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`the the` -> `the`
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77470
Files:
clang/docs/LibASTMatchersReference.html
clang/include/clang/AST/ASTStructuralEquivalence.h
c
kiszk added a comment.
I used aspell for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
kiszk created this revision.
Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb,
arphaman, jkorous, kbarton, nemanjai.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77458
Files:
clang-tools-extra/clang-change-namespace/Chan
kiszk added a comment.
I do not have commit rights to the repository. Could someone commit this change
if it is OK?
Kazuaki Ishizaki
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72140/new/
https://reviews.llvm.org/D72140
_
kiszk updated this revision to Diff 236069.
kiszk added a comment.
Rebase with master
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72140/new/
https://reviews.llvm.org/D72140
Files:
clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyRep
kiszk created this revision.
Herald added subscribers: cfe-commits, usaxena95, jsji, kadircet, arphaman,
jkorous, javed.absar, kbarton, nemanjai.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72140
Files:
clang-tools-extra/clang-apply-replaceme
kiszk added a comment.
I do not have commit rights to the repository. Could someone commit this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72087/new/
https://reviews.llvm.org/D72087
___
cfe-
kiszk created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
"the the" -> "the"
"an" -> "a"
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72087
Files:
clang-tools-extra/clang-tidy/bugprone/NotNull
20 matches
Mail list logo