[PATCH] D152782: [CodeGen] Remove unused declaration/function GetOrCreateRTTIProxyGlobalVariable

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fd80d1d1366: [CodeGen] Remove unused function GetOrCreateRTTIProxyGlobalVariable (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152782/ne

[PATCH] D152782: [CodeGen] Remove unused declaration/function GetOrCreateRTTIProxyGlobalVariable

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use removed by: commit 46f366494f3ca8cc98daa6fb4f29c7c446c176b6 Author: Fangrui Song Date: Sat May 20 08:24:20

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGee72e2b3939a: [Sema] Remove unused isNonTypeNestedNameSpecifier (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152634/new/ https://review

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 04f131da0b19abff611773c03be9bafb53c753ce Author: Richard Smith Date: Fri Jan 24 15:1

[PATCH] D151786: [Tooling] Remove unused function setRestoreWorkingDir

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a0d53ce4148: [Tooling] Remove unused function setRestoreWorkingDir (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151786/new/ https://re

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa88f496f8f3b: [Sema] Remove unused function getFloat128Identifier (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D151786: [Tooling] Remove unused function setRestoreWorkingDir

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 146ec74a8382dc820809d0a2bf4b918d0b5e6603 Author: Jan Svoboda Date: Fri Sep 10 10:24:

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu added a comment. Please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151608/new/ https://reviews.llvm.org/D151608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu added a comment. In D151607#4380757 , @erichkeane wrote: > Since this is part of the public API, do we need to publish/alert folks of > this? This could perhaps be in use by someone using libclang/etc, right? I don't think we guarantee the API st

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

This revision was automatically updated to reflect the committed changes. Closed by commit rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151609/new/ https://reviews

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe396c375a108: [AST] Remove unused function removeLocalCVRQualifiers (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The last use was removed by: commit 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 Author: Hans Wennborg Date: Tue Feb

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit bb1ea2d6139a72340b426e114510c46d938645a6 Author: Nemanja Ivanovic Date: Mon May 9 08

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 0eb06cb3aa2700508c20da28f22ff91e7b82a436 Author: Roy Jacobson Date: Tue Mar 14 21:25

[PATCH] D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed1539c6ad3d: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC) (authored by kazu). Repository: rG LLVM Github Monorep

[PATCH] D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC)

kazu created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, kadircet, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, nios

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bdf38785888: Use *{Map,Set}::contains (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

kazu created this revision. Herald added subscribers: PiotrZSL, Moerafaat, zero9178, steakhal, bzcheeseman, ayermolo, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester, arpith-ja

[PATCH] D142857: [clang] Remove clang::Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG125f4457a54a: [clang] Remove clang::Optional (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142857: [clang] Remove clang::Optional

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu added a comment. In D141798#4065025 , @RKSimon wrote: > @kazu Thanks for dealing with this! > > I'd like to build on this and create llvm variants of the C++20 > countl_zero/countr_zero/countl_one/countr_one template functions similar to > what I

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kazu marked 2 inline comments as done. Closed by commit rG83d56fb17a4d: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC) (authored by kazu). R

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:225 /// /// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are /// valid arguments. jrtc27 wrote: > A bunch of functi

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490363. kazu added a comment. I've adjusted comments for findFirstSet and findLastSet to reflect the fact that ZeroBehavior now takes only two values -- ZB_Undefined and ZB_Max. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. Please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https://reviews.llvm.org/D141798 ___ cfe-commits mailin

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. In D141798#4055050 , @barannikov88 wrote: > It would be nice to have comments reflecting the new behavior in the case of > 0 / max value. I've added comments to all four functions -- count{L

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490348. kazu added a comment. Updated the patch to leave findFirstSet and findLastSet untouched. Added a comment about the behavior on 0/max input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https:

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, mgester, arpith-jacob, csig

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

kazu added a comment. Thank you for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

kazu added a comment. In D139229#3967666 , @jansvoboda11 wrote: > Sorry for the noise, didn't realize this will trigger Herald rules. Wanted to > check with @kazu if this looks fine in principle and if it should be split up > into multiple commits (e.g

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34bcadc38c22: Use std::nullopt_t instead of NoneType (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, r

[PATCH] D138464: Return None instead of Optional() (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba4b62af8df: Return None instead of Optional() (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D138466: Don't use Optional::getPointer (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f914944b6c9: Don't use Optional::getPointer (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D138466: Don't use Optional::getPointer (NFC)

kazu added a comment. Thanks for the review! In D138466#3942622 , @MaskRay wrote: > `getPointer` asserts `hasValue`, so `&*` is safe, Yes. `operator*` also asserts `hasVal` via `value()`, so we maintain the same level of safety. Repository: rG LLV

[PATCH] D138464: Return None instead of Optional() (NFC)

kazu added a comment. Thanks for the review! In D138464#3942626 , @MaskRay wrote: > We have `return llvm::None;` and `return None;`. Shall we always prefer > `llvm::None`? Either one is OK (to me). I can deprecate `None` in my personal tree, and get

[PATCH] D138466: Don't use Optional::getPointer (NFC)

kazu created this revision. Herald added subscribers: kadircet, arphaman, javed.absar, hiraditya. Herald added a project: All. kazu requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Since std::optional doe

[PATCH] D138464: Return None instead of Optional() (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, ThomasRaoux, pmatos, asb, sdasgup3, wenzhicui, wrengr, jsetoain, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D138376: Use None consistently (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa870b1bd6c: Use None consistently (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D138376: Use None consistently (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, mtrofin, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

kazu added a comment. In D129883#3806507 , @python3kgae wrote: > In D129883#3806393 , @kazu wrote: > >> This patch seems to cause several warnings: >> >> clang/include/clang/AST/Decl.h:4696:15: error: 'getSourc

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

kazu added a comment. This patch seems to cause several warnings: clang/include/clang/AST/Decl.h:4696:15: error: 'getSourceRange' overrides a member function but is not marked 'override' [-Werror,-Wsuggest-override] clang/lib/Parse/ParseHLSL.cpp:76:20: error: unused variable 'Loc' [-Werror,

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e207e4c096e: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue} (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3708542 , @dblaikie wrote: > Sounds good - I'd be probably OK with removing these outright as they're so > niche/generally only for use by `llvm::Optional` anyway - but not much harm > in keeping them around for the same

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu updated this revision to Diff 451002. kazu added a comment. Updated to use LLVM_DEPRECATED instead of [[deprecated]]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 Files: clang/include/clang/Basi

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3707265 , @dblaikie wrote: > Update this to use something like https://reviews.llvm.org/D131381 ? Great idea! Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MapEntryOptionalStorage is an underlying storage class for OptionalStorage. This patch deprecates: OptionalStorage::hasValue

[PATCH] D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT)

kazu created this revision. Herald added subscribers: abrachet, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, zzheng, szepet, baloghadamsoftware. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de69e16ea9a: [clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation… (authored by salman-javed-nz, committed by kazu). Repos

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

kazu accepted this revision. kazu added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing the docs! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356 _

[PATCH] D112336: [Serialization] Fix a uniqueness check

kazu created this revision. kazu added a reviewer: rsmith. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The function is intended to maintain uniqueness of two sets -- Found and Data. Now, we can reach the for loop shown in the patc

[PATCH] D84473: Dump Accumulator

kazu updated this revision to Diff 281344. kazu added a comment. Spun off the llvm-readobj bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm

[PATCH] D84473: Dump Accumulator

kazu added a comment. In D84473#2178167 , @jhenderson wrote: > Could the llvm-readobj bit be spun off into a separate review, please. As > things stand it doesn't have any of its own testing, which should be added at > the same time as adding support in

[PATCH] D84473: Dump Accumulator

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// mtrofin wrote: > I'd clarify that transferring the data from pre-link thinlto to pos

[PATCH] D84473: Dump Accumulator

kazu created this revision. kazu added reviewers: davidxl, mtrofin, wmi. kazu added a project: LLVM. Herald added subscribers: cfe-commits, rupprecht, MaskRay, hiraditya, mgorny. Herald added a reviewer: jhenderson. Herald added a project: clang. This patch adds a utility called DumpAccumulator.