[PATCH] D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering

kromanova created this revision. Herald added a subscriber: cfe-commits. Below are a few doxygen intrisics documentation changes requested by our documentation team: (1) I added some \see cross-references to a few select intrinsics that are related (and have the same or very similar semantics).

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL325312: [DOXYGEN] There was a request in the review D41507 to change the notation for… (authored by kromanova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

kromanova updated this revision to Diff 134537. kromanova added a comment. Doug Yung (the reviewer for this patch) noticed that some lines exceed 80 characters limitation. I fixed that. https://reviews.llvm.org/D41888 Files: lib/Headers/emmintrin.h lib/Headers/tmmintrin.h Index: lib/Heade

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

kromanova added subscribers: kromanova, alexfh. kromanova added a comment. We have a request for this feature in clang-format in Sony. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D41523: xmmintrin.h documentation fixes and updates

kromanova added a comment. In https://reviews.llvm.org/D41523#968776, @craig.topper wrote: > The builtins are tested in tests like test/CodeGen/sse-builtins.c, Thank you! I wonder if -Wdocumentation is working... I have enabled it for a few tests, like avx-builtins.c, sse-builtins.c and re-r

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:4683 /// -/// This intrinsic has no corresponding instruction. +/// This intrinsic corresponds to the MOVDQ2Q instruction. /// efriedma wrote: > kromanova wrote: > > kromanova wrot

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Herald added a subscriber: llvm-commits. Comment at: cfe/trunk/lib/Headers/emmintrin.h:3865 /// -/// This intrinsic corresponds to the VPUNPCKLQDQ / PUNPCKLQDQ -/// instruction. +/// This intrinsic does not correspond to a specific instructio

[PATCH] D41507: avxintrin.h documentation fixes and updates

kromanova accepted this revision. kromanova added a comment. LGTM too. https://reviews.llvm.org/D41507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41523: xmmintrin.h documentation fixes and updates

kromanova added a comment. In https://reviews.llvm.org/D41523#968359, @RKSimon wrote: > Sort of related - should we enable -Wdocumentation (it's currently -Wall and > -Weverything might be too much) on the respective clang builtin tests? > Doesn't have to be part of this patch. Good idea,

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:1143 /// -///If either of the two lower double-precision values is NaN, 1 is returned. +///If either of the two lower double-precision values is NaN, 0 is returned. /// For

[PATCH] D41523: xmmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/xmmintrin.h:2199 /// -/// This intrinsic corresponds to the VPINSRW / PINSRW instruction. +/// This intrinsic corresponds to the PINSRW instruction. /// craig.topper wrote: > Why is VPINSRW removed? I

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// I tried clang on Linux, x86_64, and if -mavx option is p

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// craig.topper wrote: > PXOR? For which platform/compil

[PATCH] D41507: avxintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/avxintrin.h:1668 ///operation to use: \n -///0x00 : Equal (ordered, non-signaling) -///0x01 : Less-than (ordered, signaling) -///0x02 : Less-than-or-equal (ordered, signaling) -///0x03 : Unordered (non-

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291876: [DOXYGEN] Documentation for the newly added x86 intrinsics. (authored by kromanova). Changed prior to commit: https://reviews.llvm.org/D28503?vs=84038&id=84200#toc Repository: rL LLVM https:

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

kromanova updated this revision to Diff 84038. kromanova added a comment. Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64 Repository: rL LLVM https://reviews.llvm.org/D28503 Files: avxintrin.h emmintrin.h mmintrin.h pmmintrin.h xmmintrin.h Index: xmmintrin.h

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// RKSimon wrote: > kromanova wrote: > > kromanova wrote: > > > kromanova wrote: > > > > probinson wrote: > > > > > should th

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// probinson wrote: > should this be VMOVQ/MOVQ instead? Probably yes. Let me know if you have a different opinion. If I us