This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
ergawy marked an inline comment as done.
Closed by commit rGa40767ec8851: [MLIR][SPIRV] Add (de-)serialization support
for SpecConstantOpeati
ergawy marked 2 inline comments as done.
ergawy added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:623
{"referencesProvider", true},
-{"astProvider", true},
+{"astProvider", true}, // clangd extension
ergawy updated this revision to Diff 315658.
ergawy marked 5 inline comments as done.
ergawy added a comment.
Handle review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93591/new/
https://reviews.llvm.org/D93591
Files:
mlir/include/ml
ergawy added inline comments.
Comment at: mlir/lib/Target/SPIRV/Deserialization.cpp:1791
+
+ // Since the enclosed op is emitted in the current block, split it in a
+ // separate new block.
antiagainst wrote:
> What about first creating the spec op, set the ins
ergawy updated this revision to Diff 315302.
ergawy marked 4 inline comments as done.
ergawy added a comment.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
Handle review comments:
- Use different value map for emitting SpecConstOperation.
- S
