[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

This revision was automatically updated to reflect the committed changes. Closed by commit rGca8d2533c79c: [clang-repl][Orc] Export executable symbols in… (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lkail added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lkail created this revision. lkail added reviewers: lhames, v.g.vassilev. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. In Orc runtime, we use `dlopen(nullptr, ...)` to open current executable, th

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ceaec3e8104: [PowerPC][altivec] Optimize codegen of vec_promote (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added a comment. > but it might be a good idea to improve codegen for the insert which might be > more common. Yes. Usually `insertelement` is transformed to `BUILD_VECTOR` is SDAG, currently we don't have much optimization for `BUILD_VECTOR` in special patterns. Repository: rG LLVM

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vec_promote on vector char

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6ea93125bd: [PowerPC][altivec] Correct modulo number of vec_promote on vector char (authored by lkail). Repository: rG LLVM Github Monorepo CHA

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); lkail wrote:

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); qiucf wrote:

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail updated this revision to Diff 552251. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158487/new/ https://reviews.llvm.org/D158487 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/PowerPC/builtins-ppc-vsx.c llvm/test/CodeGen/PowerPC/v

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail updated this revision to Diff 552226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158487/new/ https://reviews.llvm.org/D158487 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/PowerPC/builtins-ppc-vsx.c llvm/test/CodeGen/PowerPC/v

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail created this revision. lkail added reviewers: nemanjai, shchenz, stefanp, PowerPC, amyk. Herald added a subscriber: kbarton. Herald added a project: All. lkail requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Accordin

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vector char

lkail created this revision. lkail added reviewers: PowerPC, nemanjai, qiucf. Herald added subscribers: sunshaoce, shchenz, kbarton. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to https://ww

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. lgtm. Though `__PPC64__` is kept in https://reviews.llvm.org/D137511, we prefer to use `__powerpc64__` which is documented in https://reviews.llvm.org/D137511. Repository: rG LLVM G

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e73129483c4: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136229/new/ h

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

lkail created this revision. lkail added reviewers: hokein, sammccall, PowerPC. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed ppc buildbot https://lab.llvm.org/buildbot/#/builders/121/b

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe231a580139a: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support (authored by lkail). Repository: rG LLVM Github Mon

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail added inline comments. Comment at: clang/test/Modules/module-file-home-is-cwd.m:1 +// UNSUPPORTED: aix // RUN: cd %S hubert.reinterpretcast wrote: > We see GOFF in the same list. Nice one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail updated this revision to Diff 467356. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135848/new/ https://reviews.llvm.org/D135848 Files: clang/test/Modules/module-file-home-is-cwd.m Index: clang/test/Modules/module-file-home-is-cwd.m ==

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, daltenty, stevewan. Herald added a subscriber: sunfish. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Fixed error Co

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbaf681b0f1: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX (authored by lkail). Repository: rG LLVM Github Monorepo C

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. > Can we use the feature bit FeatureQuadwordAtomic to decide whether QuadAtomic > is supported or not on AIX? Like what we do for Linux. `FeatureQuadwordAtomic` is for cpu level control, while `-mabi=quadword-atomics` is for ABI level. AIX running on pwr8+ also features

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

lkail added a comment. Summary should be updated as @nemanjai has said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 ___ cfe-commits mailing list cfe-commits

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail updated this revision to Diff 441293. lkail added a comment. Option name changed to `-mabi=quadword-atomics` as nemanja suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 Files: clang/incl

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. > Is there any precedent for options that start with -maix or -m for any > other OS? There is `-maix-struct-return`. > Is quadword the best word to use? There is no type information and this is > restricted to integers. Would something like -maix-i128-atomics be a better

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail updated this revision to Diff 440860. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 Files: clang/include/clang/Basic/LangOptions.def clang/include/clan

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/test/Driver/ppc-unsupported.c:12 +// RUN: -c %s 2>&1 | FileCheck %s +// RUN: not %clang -target powerpc64le-unknown-linux -maix64-quadword-atomics \ +// RUN: -c %s 2>&1 | FileCheck %s amyk wrote: > amyk wrote: >

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, cebowleratibm, xingxue, PowerPC. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: cla

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG549e118e93c6: [PowerPC] Support 16-byte lock free atomics on pwr8 and up (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421385. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/PowerPC/atomic-align

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421384. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/PowerPC/atomic-align

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 421088. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added inline comments. Comment at: llvm/test/CodeGen/PowerPC/atomics-i128.ll:77 +; AIX64-PWR8-NEXT:sync +; AIX64-PWR8-NEXT:bl .__sync_lock_test_and_set_16[PR] +; AIX64-PWR8-NEXT:nop hubert.reinterpretcast wrote: > What library is this expected t

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:440 if (Triple.isOSAIX() || Triple.isOSLinux()) DataLayout += "-S128-v256:256:256-v512:512:512"; resetDataLayout(DataLayout); adalava wrote: > I don't understand what DataLayo

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 420687. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added a comment. In D122377#3428533 , @hubert.reinterpretcast wrote: > I am not sure that the choice of `isOSBinFormatELF` to (afaik) primarily > scope this change from affecting AIX (where we know the library calls are not > implemented to be lo

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail marked an inline comment as done. lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:448 + void setMaxAtomicWidth() override { +// For layout on ELF targets, we support up to 16 bytes. +if (getTriple().isOSBinFormatELF()) hubert

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 419618. lkail retitled this revision from "[PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up" to "[PowerPC] Support 16-byte lock free atomics on pwr8 and up". lkail edited the summary of this revision. lkail added a comment. Make 16-byte atomic

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 418537. lkail added a comment. Thanks @efriedma for pointing out. Updated guard code. Also adjust backend to reflect ABI change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail added a comment. Removed alter of `-ppc-quadword-atomcis` in backend to decouple from frontend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 ___ cfe-co

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 418142. lkail added reviewers: dim, pkubaj. lkail set the repository for this revision to rG LLVM Github Monorepo. lkail added subscribers: pkubaj, dim. lkail added a comment. @dim @pkubaj We are modifying layout of 16-byte atomic type on Linux to be consisten

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail abandoned this revision. lkail added a comment. Herald added a project: All. Most are covered by https://reviews.llvm.org/D122377 already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103501/new/ https://reviews.llvm.org/D103501 ___

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 417868. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/CodeGen/PowerPC/qua

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: ll

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9247145fbae7: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \ hubert.reinterpretcast wrote: > hubert.reinterpret

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 415684. lkail added a comment. Fix typo; Add `pwr7` and `pwr8` as `-target-cpu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/ato

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414583. lkail added a comment. Add `-verify`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/a

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414575. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index: clang/test/Sema/ato

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 414574. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files: clang/test/CodeGen/PowerPC/atomic-alignment.c clang/test/Sema/atomic-ops.c Index: clang/test/Sema/ato

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC. Herald added subscribers: steven.zhang, shchenz, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

lkail added a comment. Hi, is this patch ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/ https://reviews.llvm.org/D28213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

lkail added a comment. Looks a more general way should be implemented in tailduplicator to avoid adding quadratic edges in CFGs. BRANCHES EmptyLineAfterFunctionDefinition, fix_asan, main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 ___

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

lkail added a comment. Confirmed it solves our internal regressions, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114207/new/ https://reviews.llvm.org/D114207 ___ cfe-commits mailing list cfe-co

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

lkail added a comment. Is there any way to filter these tests out on AIX in `lit.local.cfg`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mai

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

lkail added a comment. Hi we found regression in our internal tests. It compiles with clang-13.0.0 https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but fails with clang-trunk https://godbolt.org/z/1Tehxa1x9. Is it an intended change? If so, do we have to document this?

[PATCH] D113654: [AIX] Set D111860's test unsupported on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG72362736c380: [AIX] Set D111860's test unsupported on AIX (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113654/new/ https://reviews.llv

[PATCH] D113654: [AIX] Set D111860's test unsupported on AIX

lkail created this revision. lkail added reviewers: PowerPC, jsji. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113654 Files: clang/test/Modules/merge-objc-protoco

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea2431d3f10: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support… (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail added inline comments. Comment at: compiler-rt/lib/builtins/atomic.c:339 +#define ATOMIC_RMW_NAND(n, lockfree, type) \ + type __atomic_fetch_nand_##n(type *ptr, type val, int model) { \ jyknight wrote:

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail updated this revision to Diff 382624. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112400/new/ https://reviews.llvm.org/D112400 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def clang/lib/AST/Expr.cpp cla

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail added a comment. > The GCC builtins paint the ABI into a corner. They accept > non-`_Atomic`-qualified types (the C11 spec guarantees only that these > operations work on `_Atomic` types). The goal of the original C++ > specification was to allow implementations to use atomic operations

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail updated this revision to Diff 382618. lkail retitled this revision from "[compiler-rt][atomics] Support __atomic_fetch_nand" to "[clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall". lkail edited the summary of this revision. lkail a

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. This LGTM as the start point to support int128 on AIX. We might need more patches involving libraries in the LLVM monorepo, we can do that progressively. Repository: rG LLVM Github

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail added a comment. I would like to see more aix triple added to existing tests involving ABI in `llvm/test/CodeGen/PowerPC`(such as ppc64-i128-abi.ll), since AIX has independent calling convention lowering and is different from linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

lkail created this revision. lkail added reviewers: PowerPC, hubert.reinterpretcast, jsji, cebowleratibm, Jake-Egan. Herald added subscribers: jfb, kbarton, nemanjai. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://reviews

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

lkail added a comment. This looks has broken build if `-DBUILD_SHARED_LIBS=On` is specified. CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): "LLVMFrontendOpenMP" of type SHARED_LIBRARY depends on "LLVMPasses" (weak) "LLV

[PATCH] D107077: [PowerPC] Fix return type of XL compat CAS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4902e69e99d: [PowerPC] Fix return type of XL compat CAS (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D107077: [PowerPC] Fix return type of XL compat CAS

lkail created this revision. lkail added reviewers: jsji, PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `__compare_and_swap*` should return `i32` rather than `i1`. Rep

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ed93cb25ac: [PowerPC] Implement XL compatible behavior of __compare_and_swap (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360721. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-ppc-xlcompat-cas.c llvm/test/CodeGen/Powe

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360699. lkail added a comment. Herald added a project: LLVM. Discussed with @jsji about the details of codegen and inspect XL's codegen at different opt level, add an `opt` test from jinsong to demonstrate the store can be eliminated. Repository: rG LLVM G

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail added a comment. In D106344#2894755 , @jsji wrote: > Doesn't look good enough to me, the assembly code sequence generated is not > clean enough. I'm assuming you mean the second `stdcx.`, that looks like a historical issue which exists for 13yrs

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail accepted this revision. lkail added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail requested changes to this revision. lkail added a comment. This revision now requires changes to proceed. Looks we should put it in `llvm/test/CodeGen/PowerPC`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.or

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ This l

[PATCH] D106344: [PowerPC] Correct behavior of __compare_and_swap

lkail created this revision. lkail added reviewers: jsji, nemanjai, w2yehia, shchenz, PowerPC. Herald added subscribers: jfb, kbarton. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. XL's `__compare_and_swap` has a weird behavior that

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1015 +break; + } + Adding `default: llvm_unreachable` would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:997 +static llvm::Value *emitLoadReserveIntrinsic(CodeGenFunction &CGF, + unsigned BuiltinID, Maybe rename to `emitPPCLoadReserveIntrinsic` shou

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535 - def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">, - Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } Just curious, compiler optimizes the

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

lkail accepted this revision. lkail added a comment. lgtm,thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

lkail added a comment. The wording might be inaccurate. It's better to rephrase to 'Load and Reserve and Store Conditional'. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1724 + +let Predicates = [HasP8Altivec] in { + def : Pat<(int_ppc_stdcx xoaddr:$dst, g8rc:$A), ---

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

lkail accepted this revision. lkail added a comment. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104991/new/ https://reviews.llvm.org/D104991 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics hubert.reinterpretcast wrote: > Can you add a link to something that demonstrates that the implement

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:336 .Default(false); + Features["quadword-atomics"] = llvm::StringSwitch(CPU) + .Case("pwr10", true) qiucf wrote: > What about `

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail updated this revision to Diff 353268. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103501/new/ https://reviews.llvm.org/D103501 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail created this revision. lkail added reviewers: nemanjai, jsji, xingxue, hubert.reinterpretcast, cebowleratibm, PowerPC. Herald added subscribers: jfb, kbarton. Herald added a reviewer: jfb. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68e07da3e5d5: [clang][PowerPC] Enable -fstack-clash-protection option for ppc64 (authored by lkail). Changed prior to commit: https://reviews.llvm.org/D81355?vs=269094&id=275538#toc Repository: rG LL

[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

lkail added a comment. In D81355#2078752 , @steven.zhang wrote: > Shouldn't this be the last patch to commit after the backend supporting this > feature ? Yes, I've updated the parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

lkail created this revision. lkail added reviewers: PowerPC, hfinkel, jonpa, serge-sans-paille. Herald added subscribers: cfe-commits, shchenz, kbarton, nemanjai. Herald added a project: clang. Open `-fstack-clash-protection` option in clang for ppc64 arch. Repository: rG LLVM Github Monorepo