[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2023-01-24 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky added a comment. @nridge I have fixed the issues. Thank you for supporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140619/new/ https://reviews.llvm.org/D140619 ___ cfe-commits mailing l

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2023-01-23 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky updated this revision to Diff 491347. KKoovalsky added a comment. Fixed nullptr dereferencing and missing ASTMatchers lib linking 1. Fixed lit fail: dereferencing a null pointer when calling ignoreImplicit() on CommonAncestor being nullptr - fixed with sanitization of CommonAncestor

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2023-01-23 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky updated this revision to Diff 491331. KKoovalsky added a comment. 1. Fixed lit fail: dereferencing a null pointer when calling `ignoreImplicit()` on `CommonAncestor` being `nullptr` - fixed with sanitization of `CommonAncestor` being `nullptr`. 2. Fixed link error: missing `ASTMatcher

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2023-01-23 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky updated this revision to Diff 491324. KKoovalsky added a comment. 1. Fixed lit fail: dereferencing a null pointer when calling `ignoreImplicit()` on `CommonAncestor` being `nullptr` - fixed with sanitization of `CommonAncestor` being `nullptr`. 2. Fixed link error: missing `ASTMatcher

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2023-01-17 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky added a comment. Hey! I can see that the build: https://reviews.llvm.org/harbormaster/build/311598/ failed, but I am not sure whether this is related to my change. Could someone take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

2022-12-23 Thread Kacper Kowalski via Phabricator via cfe-commits
KKoovalsky created this revision. Herald added subscribers: kadircet, arphaman, mgrang. Herald added a project: All. KKoovalsky requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. This is mainly insipred by ExtractVari