https://github.com/kpet approved this pull request.
LGTM, thanks! (The definitions match the specification, tests ran, CI failures
look unrelated.)
https://github.com/llvm/llvm-project/pull/134216
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/kpet closed https://github.com/llvm/llvm-project/pull/113145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpet wrote:
AFAICT, the new tests ran and the failed tests are completely unrelated to this
change. Merging.
https://github.com/llvm/llvm-project/pull/113145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/kpet approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/113145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kpet closed https://github.com/llvm/llvm-project/pull/66902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kpet approved this pull request.
https://github.com/llvm/llvm-project/pull/66902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -251,13 +258,19 @@ def generate_default_conversion(src, dst, mode):
print("#endif")
-for src in types:
-for dst in types:
-generate_default_conversion(src, dst, "")
+# Do not generate default conversion for clspv as they are handle natively
@@ -307,8 +320,8 @@ def generate_saturated_conversion(src, dst, size):
# Conversion from float to int
print(
""" {DST}{N} y = convert_{DST}{N}(x);
- y = select(y, ({DST}{N}){DST_MIN}, {BP}(x < ({SRC}{N}){DST_MIN}){BS});
- y = select(y, ({DST}{N}){
@@ -484,4 +536,8 @@ def generate_float_conversion(src, dst, size, mode, sat):
for dst in float_types:
for size in vector_sizes:
for mode in rounding_modes:
+# Do not generate "_rte" conversion for clspv as they are
+# hand
@@ -251,13 +258,19 @@ def generate_default_conversion(src, dst, mode):
print("#endif")
-for src in types:
-for dst in types:
-generate_default_conversion(src, dst, "")
+# Do not generate default conversion for clspv as they are handle natively
+if not clsp
@@ -26,6 +27,12 @@
#
# convert_<_sat><_roundingMode>()
+import sys
+
+clspv = False
+if len(sys.argv) == 2 and sys.argv[1] == "--clspv":
+clspv = True
+
kpet wrote:
```suggestion
import argparse
parser = argparse.ArgumentParser()
parser.add_argument('--c
https://github.com/kpet closed https://github.com/llvm/llvm-project/pull/66901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kpet approved this pull request.
Looks infinitely better than the absence of FP16 implementation we currently
have. I have not tried to think through rounding and other detailed
considerations. The OpenCL CTS currently does not cover FP16 variants of these
functions but I be
Author: Kévin Petit
Date: 2023-05-09T16:52:13+01:00
New Revision: 21508fa76914a5e4281dc5bc77cac7f2e8bc3aef
URL:
https://github.com/llvm/llvm-project/commit/21508fa76914a5e4281dc5bc77cac7f2e8bc3aef
DIFF:
https://github.com/llvm/llvm-project/commit/21508fa76914a5e4281dc5bc77cac7f2e8bc3aef.diff
L
Author: Kévin Petit
Date: 2023-02-14T18:26:42Z
New Revision: 1da2085a513341f0e8d7578415dcf77d614708e5
URL:
https://github.com/llvm/llvm-project/commit/1da2085a513341f0e8d7578415dcf77d614708e5
DIFF:
https://github.com/llvm/llvm-project/commit/1da2085a513341f0e8d7578415dcf77d614708e5.diff
LOG: l
Author: Kévin Petit
Date: 2023-02-14T18:23:35Z
New Revision: 290308a99e6b9e6f808a9824c8e5a58a65749585
URL:
https://github.com/llvm/llvm-project/commit/290308a99e6b9e6f808a9824c8e5a58a65749585
DIFF:
https://github.com/llvm/llvm-project/commit/290308a99e6b9e6f808a9824c8e5a58a65749585.diff
LOG: l
Author: Kévin Petit
Date: 2023-02-14T18:11:01Z
New Revision: f6cd46e07fcca123620afff96675171f8fe96124
URL:
https://github.com/llvm/llvm-project/commit/f6cd46e07fcca123620afff96675171f8fe96124
DIFF:
https://github.com/llvm/llvm-project/commit/f6cd46e07fcca123620afff96675171f8fe96124.diff
LOG: l
Author: Kévin Petit
Date: 2023-02-13T21:27:40Z
New Revision: f11ab8353f972647f276b07c24d1308859fbde0d
URL:
https://github.com/llvm/llvm-project/commit/f11ab8353f972647f276b07c24d1308859fbde0d
DIFF:
https://github.com/llvm/llvm-project/commit/f11ab8353f972647f276b07c24d1308859fbde0d.diff
LOG: l
Author: Kévin Petit
Date: 2022-01-13T09:28:19Z
New Revision: ec0a880d54632923b4d0742f38d565830fc0d0e0
URL:
https://github.com/llvm/llvm-project/commit/ec0a880d54632923b4d0742f38d565830fc0d0e0
DIFF:
https://github.com/llvm/llvm-project/commit/ec0a880d54632923b4d0742f38d565830fc0d0e0.diff
LOG: l
19 matches
Mail list logo
