[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

justinstitt updated this revision to Diff 451955. justinstitt added a comment. move return to new line, as per clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131532/new/ https://reviews.llvm.org/D131532 Files: clang/lib/Sema/SemaChe

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

justinstitt updated this revision to Diff 451902. justinstitt edited the summary of this revision. justinstitt added a comment. add more descriptive names, add more detail to revision summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131532/new

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

justinstitt updated this revision to Diff 451687. justinstitt added a comment. use @rtrieu 's suggestion regarding not invoking isNullPointerConstant as opposed to checking for C++ lang opt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131532/new/ https://reviews.llvm.org/D131532 Fil

[PATCH] D131532: [Sema] Only invoke DiagnoseNullConversions for CPlusPlus (-Wnull-conversion)

justinstitt created this revision. Herald added a subscriber: pengfei. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -Wnull-conversion is not supported in C and therefore DiagnoseNullConversions sh

[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

justinstitt updated this revision to Diff 450966. justinstitt retitled this revision from "[Clang][BinaryOperator] cache ICEKind" to "[Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs". justinstitt edited the summary of this revision. justinstitt added a comment. Herald added a subs

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt updated this revision to Diff 450964. justinstitt added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/ https://reviews.llvm.org/D131416 Files: clang/include/clang/AST/Expr.h clang/lib/AST

[PATCH] D131447: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

justinstitt created this revision. Herald added a subscriber: pengfei. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building the Linux Kernel (x86_64) CheckICE is a particularly slow method w

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt updated this revision to Diff 450961. justinstitt marked 7 inline comments as done. justinstitt added a comment. create getter/setter for optional ICEKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/ https://reviews.llvm.or

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt updated this revision to Diff 450872. justinstitt edited the summary of this revision. justinstitt added a reviewer: nickdesaulniers. justinstitt added a comment. - test adding reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1314

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt created this revision. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Justin Stitt Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131416 Files: cla