[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-22 Thread Justin Fargnoli via cfe-commits
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, bool TakingCandidateAddress) { TemplateParameter Param = DeductionFailure.getTemplateParameter(); NamedDecl *ParamD; - (ParamD = Param.dy

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-21 Thread Justin Fargnoli via cfe-commits
@@ -11610,9 +11610,10 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, bool TakingCandidateAddress) { TemplateParameter Param = DeductionFailure.getTemplateParameter(); NamedDecl *ParamD; - (ParamD = Param.dy

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -4870,9 +4870,25 @@ def note_ovl_candidate_inconsistent_deduction_types : Note< "candidate template ignored: deduced values %diff{" "of conflicting types for parameter %0 (%1 of type $ vs. %3 of type $)|" "%1 and %3 of conflicting types for parameter %0}2,4">; +

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -883,13 +896,11 @@ TemplateParameter DeductionFailureInfo::getTemplateParameter() { case TemplateDeductionResult::NonDependentConversionFailure: case TemplateDeductionResult::ConstraintsNotSatisfied: return TemplateParameter(); - justinfargnoli wrot

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -749,10 +753,9 @@ clang::MakeDeductionFailureInfo(ASTContext &Context, break; case TemplateDeductionResult::Incomplete: - case TemplateDeductionResult::InvalidExplicitArguments: +// case TemplateDeductionResult::InvalidExplicitArguments: justinfa

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -883,13 +896,11 @@ TemplateParameter DeductionFailureInfo::getTemplateParameter() { case TemplateDeductionResult::NonDependentConversionFailure: case TemplateDeductionResult::ConstraintsNotSatisfied: return TemplateParameter(); - case TemplateDeductionResult::Inc

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -736,8 +738,10 @@ clang::MakeDeductionFailureInfo(ASTContext &Context, TemplateDeductionResult TDK, TemplateDeductionInfo &Info) { DeductionFailureInfo Result; + justinfargnoli wrote: ```sugg

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -11714,13 +11724,53 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -946,15 +956,14 @@ const TemplateArgument *DeductionFailureInfo::getFirstArg() { case TemplateDeductionResult::Incomplete: case TemplateDeductionResult::TooManyArguments: case TemplateDeductionResult::TooFewArguments: - case TemplateDeductionResult::InvalidExplicitAr

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -3575,7 +3575,15 @@ TemplateDeductionResult Sema::SubstituteExplicitTemplateArguments( unsigned Index = SugaredBuilder.size(); if (Index >= TemplateParams->size()) return TemplateDeductionResult::SubstitutionFailure; + justinfargnoli wrote: `

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -715,12 +715,14 @@ namespace { struct DFIParamWithArguments : DFIArguments { TemplateParameter Param; }; + justinfargnoli wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/122754 ___ cfe-

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -163,4 +163,4 @@ namespace PR15673 { CONCEPT_REQUIRES_(some_passing_trait::value && some_trait::value)> void rangesv3(); // expected-note{{candidate template ignored: requirement 'some_trait::value' was not satisfied [with T = int, x = 42]}} void test_ranges

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -11610,9 +11618,11 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, bool TakingCandidateAddress) { TemplateParameter Param = DeductionFailure.getTemplateParameter(); NamedDecl *ParamD; - (ParamD = Param.dy

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -822,13 +834,14 @@ void DeductionFailureInfo::Destroy() { case TemplateDeductionResult::Incomplete: case TemplateDeductionResult::TooManyArguments: case TemplateDeductionResult::TooFewArguments: - case TemplateDeductionResult::InvalidExplicitArguments: + // case Temp

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -918,7 +929,6 @@ TemplateArgumentList *DeductionFailureInfo::getTemplateArgumentList() { case TemplateDeductionResult::CUDATargetMismatch: case TemplateDeductionResult::NonDependentConversionFailure: return nullptr; - justinfargnoli wrote: Add newl

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -979,14 +988,13 @@ const TemplateArgument *DeductionFailureInfo::getSecondArg() { case TemplateDeductionResult::IncompletePack: case TemplateDeductionResult::TooManyArguments: case TemplateDeductionResult::TooFewArguments: - case TemplateDeductionResult::InvalidExpli

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -777,6 +780,7 @@ clang::MakeDeductionFailureInfo(ASTContext &Context, case TemplateDeductionResult::IncompletePack: // FIXME: It's slightly wasteful to allocate two TemplateArguments for this. case TemplateDeductionResult::Inconsistent: + justinfarg

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -1,4 +1,4 @@ // RUN: %clang_cc1 -std=c++98 -fsyntax-only -verify %s // expected-no-diagnostics void f(void *); -void g() { f(__nullptr); } +void g() { f(__nullptr); } justinfargnoli wrote: ```suggestion void g() { f(__nullptr); } ``` https://github.com/ll

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-20 Thread Justin Fargnoli via cfe-commits
@@ -4870,9 +4870,25 @@ def note_ovl_candidate_inconsistent_deduction_types : Note< "candidate template ignored: deduced values %diff{" "of conflicting types for parameter %0 (%1 of type $ vs. %3 of type $)|" "%1 and %3 of conflicting types for parameter %0}2,4">; +

[clang] [clang][sema] Add support and documentation for `__has_extension(c_fixed_enum)` (PR #117507)

2024-11-27 Thread Justin Fargnoli via cfe-commits
@@ -156,13 +156,15 @@ FEATURE(objc_class_property, LangOpts.ObjC) FEATURE(objc_c_static_assert, LangOpts.C11) FEATURE(objc_cxx_static_assert, LangOpts.CPlusPlus11) EXTENSION(objc_c_static_assert, true) -// C11 features +// C11 features justinfargnoli wrote: D

[clang] [clang][sema] Add support and documentation for `__has_extension(c_fixed_enum)` (PR #117507)

2024-11-24 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/117507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] (PR #117507)

2024-11-24 Thread Justin Fargnoli via cfe-commits
@@ -121,6 +121,17 @@ int NegativeShortTest[NegativeShort == -1 ? 1 : -1]; enum Color { Red, Green, Blue }; // expected-note{{previous use is here}} typedef struct Color NewColor; // expected-error {{use of 'Color' with tag type that does not match previous declaration}} +// E

[clang] [clang][sema] (PR #117507)

2024-11-24 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/117507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] (PR #117507)

2024-11-24 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli commented: Add a title. And welcome to the LLVM community :) https://github.com/llvm/llvm-project/pull/117507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-11-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/113780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-11-13 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: > Is it possible/easy to split > https://github.com/llvm/llvm-project/commit/ef6a751a794c3e2d266cac0242629043ddd0d2aa > into a new PR? Certainly, @boomanaiden154! Please see #116108 :) https://github.com/llvm/llvm-project/pull/113780 _

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-11-12 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: > @justinfargnoli in few words the problem is in the broken link order for > those two Key references. @vvereschaka thank you for your [detail description](https://github.com/llvm/llvm-project/pull/113780#issuecomment-2448416385) of the issue. I've attempted to address

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-10-29 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: @vvereschaka I'm unable to reproduce the build failure locally or via the `buildkite` jobs. Are the jobs that you're running on the BuildBot clean builds? https://github.com/llvm/llvm-project/pull/113780 ___ cfe-commits mailin

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-10-22 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: @vvereschaka, I agree. Note: The problem is that `IRNormalizer` produces a change that invalidates an analysis. It's not that IRNormalizer should declare that it's not preserving an analysis. I likely won't be able to fix this for a few days. @vvereschaka, should I re

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Remove nvvm.ldg.global.* intrinsics (PR #112834)

2024-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli approved this pull request. https://github.com/llvm/llvm-project/pull/112834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-09-18 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Ping @plotfi @nikic for review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-09-15 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Ping @plotfi @nikic for review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Remove nvvm.bitcast.* intrinsics (PR #107936)

2024-09-10 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: > can you point me to an analogous change I could use as an example? [[LLD] Add CLASS syntax to SECTIONS](https://github.com/llvm/llvm-project/commit/7e8a9020b1ae3dea28c19f0cd68743482dca13d9#diff-96d3595c06280d8c10f2687758a9e7bb5a0f3552fd53e552a1490411870c3500) [[LLVM] Add

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-09-07 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Hi @plotfi, thanks for pinging me on this! Generally speaking, two things deserve additional focus: - UX testing to find: - Improvements to existing features - New features to add - Additional testing to ensure that the pass preserves the semantics of the IR. - e.

[clang] [llvm] [NVPTX] Add conversion intrinsics from/to fp8 types (e4m3, e5m2) (PR #102969)

2024-08-19 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: > How do I actually upstream it? Here is the documentation on how to [obtain commit access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access). It's a relatively quick process. However, if you don't want to go through that process, you can just ask for

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-06-18 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Hi @dtcxzyw, thanks for reaching out! This MR is blocked because I cannot reproduce the failures @nikic found [here](https://github.com/llvm/llvm-project/pull/68176#issuecomment-1836365664). (See [this comment](https://github.com/llvm/llvm-project/pull/68176#issuecommen

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-05-28 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: TODO: Sort function order https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [clang-tools-extra] [llvm] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/78368 >From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Thu, 11 Jan 2024 20:00:53 -0800 Subject: [PATCH 1/6] Declare Affine Interfaces --- mlir/lib/Dialect/Affi

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Open question: where should I declare promised interfaces for the `builtin` Dialect? https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [clang] [llvm] Jf/promise interfaces (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/78368 >From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Thu, 11 Jan 2024 20:00:53 -0800 Subject: [PATCH 1/5] Declare Affine Interfaces --- mlir/lib/Dialect/Affi

[libc] [llvm] [compiler-rt] [libcxx] [lld] [lldb] [flang] [clang-tools-extra] [libcxxabi] [clang] [NVPTX] Improve lowering of v4i8 (PR #67866)

2024-01-25 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/67866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libcxx] [libc] [clang] [flang] [compiler-rt] [libcxxabi] [lldb] [clang-tools-extra] [lld] [NVPTX] Improve lowering of v4i8 (PR #67866)

2024-01-24 Thread Justin Fargnoli via cfe-commits
@@ -2110,6 +2214,29 @@ def : Pat<(seteq Int1Regs:$a, Int1Regs:$b), def : Pat<(setueq Int1Regs:$a, Int1Regs:$b), (NOT1 (XORb1rr Int1Regs:$a, Int1Regs:$b))>; +// comparisons of i8 extracted with BFE as i32 +def: Pat<(setgt (sext_inreg (trunc Int32Regs:$a), i8), (sext_i

[clang-tools-extra] [mlir] [llvm] [clang] Jf/promise interfaces (PR #78368)

2024-01-16 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/78368 >From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Thu, 11 Jan 2024 20:00:53 -0800 Subject: [PATCH 1/4] Declare Affine Interfaces --- mlir/lib/Dialect/Affi

[clang-tools-extra] [clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-30 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Unless other comments brought up, I'll plan on merging this on Monday the 4th. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [llvm] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-25 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Pinging @nikic for another round of review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-19 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: > I would recommend trying to run this pass (with all options enabled) over all > existing tests to make sure that it doesn't cause any crashes/verifier > failures. You're moving instructions around, and it's easy to get that wrong > when invoke, callbr or catchswitch are

[clang-tools-extra] [llvm] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-19 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-19 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-11 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-11 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,637 @@ +//===--- IRNormalizer.cpp - IR Normalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[llvm] [clang-tools-extra] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-11 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/31] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[llvm] [clang-tools-extra] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-10 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/30] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[llvm] [clang-tools-extra] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-10 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/29] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] [clang-tools-extra] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-10 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/28] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] [llvm] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-10 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/26] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[llvm] [clang-tools-extra] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-10 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/25] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[llvm] [clang] [clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-31 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Ping for another round of review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][scf.parallel] Don't allow a tile size of 0 (PR #68762)

2023-10-23 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/68762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][scf.parallel] Don't allow a tile size of 0 (PR #68762)

2023-10-22 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(scf-parallel-loop-tiling{parallel-loop-tile-sizes=0,0}))' -split-input-file -verify-diagnostics + +// XFAIL: * justinfargnoli wrote: It looks like it isn't possible to use `expected-e

[clang-tools-extra] [mlir][DeadCodeAnalysis] Don't Require `RegionBranchTerminatorOpInterface` in `visitRegionTerminator()` (PR #69043)

2023-10-22 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/69043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][DeadCodeAnalysis] Don't Require `RegionBranchTerminatorOpInterface` in `visitRegionTerminator()` (PR #69043)

2023-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/69043 >From 8f8b644792d5e26f76d98bd8ba45440443f9a260 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Fri, 13 Oct 2023 18:16:45 -0700 Subject: [PATCH 1/4] Initial commit --- .../mlir/Analysis/DataFlow/DeadC

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-21 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-15 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/19] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Renamed to IRNormalizer. Requesting another round of review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/18] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM] Add Normalizer Pass (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [LLVM] Add Normalizer Pass (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-14 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/17] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,638 @@ +//===--- IRCanonicalizer.cpp - IR Canonicalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,638 @@ +//===--- IRCanonicalizer.cpp - IR Canonicalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/16] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/16] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-03 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/15] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] llvm-canon (PR #68176)

2023-10-03 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/15] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] llvm-canon (PR #68176)

2023-10-03 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli created https://github.com/llvm/llvm-project/pull/68176 Add the llvm-canon tool. Description from the [original PR](https://reviews.llvm.org/D66029#change-wZv3yOpDdxIu): > Added a new llvm-canon tool which aims to transform LLVM Modules into a > canonical for