[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

2023-09-28 Thread Justin Cady via Phabricator via cfe-commits
justincady added a comment. I suspect there's another unintended consequence of this change with regards to broken ODR violation detection. I filed an issue and am connecting it here should someone find this review first. Repository: rG LL

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

2023-07-10 Thread Justin Cady via Phabricator via cfe-commits
justincady added subscribers: njames93, LegalizeAdulthood, justincady. justincady added a comment. This feature appears to have strong user support throughout this review, and a lot of people (including myself) seem interested in having it landed. cc'ing some clang-tidy owners

[PATCH] D128482: [clang codegen] Add dso_local/hidden/etc. markings to VTT declarations

2022-06-24 Thread Justin Cady via Phabricator via cfe-commits
justincady accepted this revision. justincady added a comment. LGTM! Just to double check I tested this exact patch locally with the setup that found the problem. I confirmed it resolved that issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12