[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3790064 , @hans wrote: > Ah, thanks for letting me know. I've committed on your behalf as > https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28 Sweet, thanks a lot :-) Repository:

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. @hans just to clarify as I do not have commit access: do I still need to perform some action? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133354/new/ https://reviews.llvm.org/D133354 ___ cfe-commits mailing list cf

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin updated this revision to Diff 459277. ningvin added a comment. I added the respective RUN lines to the different test cases, did not seem to break anything on my end. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133354/new/ https://reviews.llvm.org/D133354 Files: clang/lib/

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. That is indeed a better option than to simply copy the test case. I did some more digging and found the following test cases which reference the deprecated copy warning (all located under clang/test/CXX/): - deprecated.cpp

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3779123 , @dblaikie wrote: > That works, you can also take the hash with the `rG` prefix and use that: > rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad >

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3778237 , @dblaikie wrote: > Got any pointers to the commits/authors that added this functionality in the > first place? (would be good to have any review history, etc, to check against > the change here) That would

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin created this revision. ningvin added a reviewer: rsmith. ningvin added a project: clang. Herald added a project: All. ningvin requested review of this revision. Herald added a subscriber: cfe-commits. When running in MSVC compatibility mode, previously no deprecated copy operation warning