[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 01/11] Copied over everything --- .../readability/QualifiedAutoChec

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
JuanBesa wrote: Updated to `IgnoreAliasing` name for the option (also updated the title here) Merged the testfile so that everythign runs in one file Added the Limitations section for the case discussed. https://github.com/llvm/llvm-project/pull/147060

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
@@ -96,3 +96,23 @@ Note in the LLVM alias, the default value is `false`. matched against only the type name (i.e. ``Type``). E.g. to suppress reports for ``std::array`` iterators use `std::array<.*>::(const_)?iterator` string. The default is an empty string. + +.. option:

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa edited https://github.com/llvm/llvm-project/pull/147060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/9] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-15 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/5] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-14 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/5] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-08 Thread Juan Besa via cfe-commits
JuanBesa wrote: I updated the Check to only modify the matcher. Will update tests + option name soon. I have found a case which I don't know how to manage. The case is as follows (following tests format): ``` namespace std { template class vector { // dummy impl T _data[1]; public: T *b

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-08 Thread Juan Besa via cfe-commits
@@ -174,6 +176,21 @@ void QualifiedAutoCheck::registerMatchers(MatchFinder *Finder) { void QualifiedAutoCheck::check(const MatchFinder::MatchResult &Result) { if (const auto *Var = Result.Nodes.getNodeAs("auto")) { +if (RespectOpaqueTypes) { JuanBesa wr

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-08 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/5] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-08 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/4] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-08 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/3] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-07 Thread Juan Besa via cfe-commits
JuanBesa wrote: Thanks for the comments. I also think `IgnoreAliasing` is a better name. In that case the default should be `true` though right? I'll look into merging the tests into a single file, and see if I can figure out the matcher. https://github.com/llvm/llvm-project/pull/147060

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-07 Thread Juan Besa via cfe-commits
@@ -174,6 +176,21 @@ void QualifiedAutoCheck::registerMatchers(MatchFinder *Finder) { void QualifiedAutoCheck::check(const MatchFinder::MatchResult &Result) { if (const auto *Var = Result.Nodes.getNodeAs("auto")) { +if (RespectOpaqueTypes) { JuanBesa wr

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-07 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/2] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-07 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa updated https://github.com/llvm/llvm-project/pull/147060 >From d176aa31c18a4293be9b49da671270d349a323b7 Mon Sep 17 00:00:00 2001 From: juanbesa Date: Thu, 26 Jun 2025 07:42:55 -0700 Subject: [PATCH 1/2] Copied over everything --- .../readability/QualifiedAutoCheck.

[clang-tools-extra] [clang-tidy] added `RespectOpaqueTypes` option to `readability-qualified-auto check` (PR #147060)

2025-07-04 Thread Juan Besa via cfe-commits
https://github.com/JuanBesa created https://github.com/llvm/llvm-project/pull/147060 `readability-qualified-auto` check currently looks at the unsugared type, skipping any typedefs, to determine if the variable is a pointer-type. This may not be the desired behaviour, in particular when the ty