[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

2018-09-10 Thread Josh Gao via Phabricator via cfe-commits
jmgao added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3016-3017 +def warn_thread_attribute_not_on_capability_member : Warning< + "%0 attribute without capability arguments can only be applied in a class " + "annotated with 'capability' or 'scoped_l

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-08 Thread Josh Gao via Phabricator via cfe-commits
jmgao added a comment. Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D36237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-08 Thread Josh Gao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310402: Reland "Thread Safety Analysis: fix assert_capability." (authored by jmgao). Changed prior to commit: https://reviews.llvm.org/D36237?vs=110054&id=110260#toc Repository: rL LLVM https://revi

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-08 Thread Josh Gao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310403: Thread Safety Analysis: warn on nonsensical attributes. (authored by jmgao). Changed prior to commit: https://reviews.llvm.org/D36237?vs=110054&id=110259#toc Repository: rL LLVM https://revi

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-07 Thread Josh Gao via Phabricator via cfe-commits
jmgao updated this revision to Diff 110054. jmgao added a comment. Reword warnings. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabilities.c tes

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-02 Thread Josh Gao via Phabricator via cfe-commits
jmgao updated this revision to Diff 109412. jmgao added a comment. Fix commit messages. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabilities.c

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

2017-08-02 Thread Josh Gao via Phabricator via cfe-commits
jmgao updated this revision to Diff 109411. jmgao added a comment. Remove accidental trailing backslash. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr

[PATCH] D36122: Thread Safety Analysis: fix assert_capability.

2017-08-01 Thread Josh Gao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL309725: Thread Safety Analysis: fix assert_capability. (authored by jmgao). Repository: rL LLVM https://reviews.llvm.org/D36122 Files: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/lib/Analysis/

[PATCH] D36122: Thread Safety Analysis: fix assert_capability.

2017-07-31 Thread Josh Gao via Phabricator via cfe-commits
jmgao created this revision. Previously, the assert_capability attribute was completely ignored by thread safety analysis. https://reviews.llvm.org/D36122 Files: include/clang/Basic/Attr.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/SemaCXX/warn-thread-safety-analysis.