[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233652. zapster added a comment. > The new LTO/X86/embed-bitcode.ll test is failing for me Should be fixed now, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. Thanks again for you reviews! Since I do not have commit rights, I would be grateful if someone could push it for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 ___ cfe

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233548. zapster added a comment. Addressed suggestions from @tejohnson CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Frontend/x86-embed-bitcode.ll

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233282. zapster edited the summary of this revision. zapster added a comment. Made `-lto-embed-bitcode` a boolean option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUti

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster marked an inline comment as done. zapster added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) +

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. Thanks for your comment. I replied inline. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) +

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. (Ping) Hi! I am still looking for reviews/reviewers for this change. Please let me know what I can do to make progress with this. Many thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 __

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. (ping) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster marked 5 inline comments as done. zapster added a comment. Added inline remarks. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1547 } -static const char* getSectionNameForBitcode(const Triple &T) { moved to `llvm/lib/Bitcode/Writer/BitcodeWriter.cpp`

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster created this revision. zapster added reviewers: LLVM, clang, rsmith, pcc. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, aheejin, hiraditya, inglorion, mehdi_amini. Herald added a reviewer: alexshap. Herald added projects: clang, LLVM. zapster updated thi

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 222401. zapster added a comment. re-ran clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Frontend/x86-embed-bitcode.ll llvm/include/llvm/