[PATCH] D61716: [libclang] Expose AtomicType

JornVernee added a comment. Would like to try to draw attention to this patch again, since it seems to have gone under the radar. Can someone review this/help get it integrated? We are still having to work around _Atomic types because we can't get to the underlying value type. Thanks Reposito

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. In D61239#1487406 , @aaron.ballman wrote: > In D61239#1486692 , @JornVernee > wrote: > > > Also, I don't have committer access. Would you mind committing this? > > > Happy to do so -- I

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. In D61239#1486634 , @aaron.ballman wrote: > LGTM, thank you! That's strange that clang-format would remove the newline > from the end of the file. I don't get that behavior when I try it, so it > makes me wonder what's differ

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197583. JornVernee marked 3 inline comments as done. JornVernee added a comment. Removed spurious newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/print-type-size.c tools/libc

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197557. JornVernee marked an inline comment as done. JornVernee added a comment. - Removed const& QualType and passing by-value instead - Ran print-type-size.c through clang-format FWIW, clang-format was removing the newline at the end of the file, so I ad

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197543. JornVernee marked an inline comment as done. JornVernee added a comment. - Replaced plane predicates with helper methods describing their function. - Fixed test file indentation Changing the logic for `clang_Type_getAlignOf` was not needed after al

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee marked 4 inline comments as done. JornVernee added a comment. In D61239#1486005 , @aaron.ballman wrote: > In D61239#1485994 , @JornVernee > wrote: > > > - holding of on adding helper method until hearin

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197533. JornVernee added a comment. Add forgotten newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/print-type-size.c tools/libclang/CXType.cpp Index: tools/libclang/CXType.c

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197532. JornVernee marked 2 inline comments as done. JornVernee added a comment. - Restructured test source file to put CHECK comments inline - Removed IAT comments. - holding of on adding helper method until hearing back. CHANGES SINCE LAST ACTION htt

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. @yvvan Mind taking a look here as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197038. JornVernee added a comment. Incremented minor version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee marked an inline comment as done. JornVernee added a comment. No worries! I'm already glad there's someone who picked up the review for this so quickly ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197024. JornVernee added a comment. Fixed the similar problem with `clang_Type_getAlignOf` since the patch is pretty small any ways. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/pr

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee created this revision. JornVernee added reviewers: akyrtzi, aaron.ballman, rsmith. JornVernee added a project: clang. Herald added subscribers: arphaman, dexonsmith. Currently, looking up the offset of a field in a type with an incomplete array, using `clang_Type_getOffsetOf` always re

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197019. JornVernee marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/li

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 197018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index: tools/libclang/CXT

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. @yvvan Hows that as a test? I'm pretty new at this, and it took a while to figure out how to run the tests. I used something like: `build\Release\bin\c-index-test.exe -test-print-type .\test\Index\print-type.c | ..\llvm\build\Release\bin\FileCheck .\test\Index\print

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 196988. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index: tools/libclang/CXT

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. Also, I don't have commit access, so I would need some help with that if this gets accepted :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 ___

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee created this revision. JornVernee added reviewers: yvvan, nik, rsmith. JornVernee added a project: clang. Herald added a subscriber: arphaman. https://reviews.llvm.org/D54996 Changed the behaviour of clang_Cursor_isAnonymous, but there is no alternative available to get the old behavi

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

JornVernee added a comment. Herald added a project: LLVM. This seems to have changed the behaviour w.r.t inline struct or union decls in fields and global variables e.g. struct foo { struct { int x; } bar; }; For the StructDecl cursor of 'bar' isAnonymous now returns t