[PATCH] D52280: Don't trim non-alphanumeric characters in 'file not found' errors for include directives.

jgorbe created this revision. jgorbe added reviewers: christylee, rsmith, aaron.ballman. r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric characters and chec

[PATCH] D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization

jgorbe added a comment. Can't comment much on the patch itself (I'm still not very familiar with the codebase, I'll leave that to the other reviewers), but thanks a lot for responding so quickly! :) https://reviews.llvm.org/D46135 ___ cfe-commits

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe added inline comments. Comment at: lib/Sema/SemaLookup.cpp:3792-3793 static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) { if (TC.begin() == TC.end()) return; rsmith wrote: > jgorbe wrote: > > rsmith wrote: > > > Do we need

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe updated this revision to Diff 101437. jgorbe added a comment. Herald added a subscriber: sanjoy. Removed unneeded branch. https://reviews.llvm.org/D30963 Files: lib/Sema/SemaLookup.cpp test/Modules/Inputs/crash-typo-correction-visibility/module.h test/Modules/Inputs/crash-typo-corr

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe added inline comments. Comment at: lib/Sema/SemaLookup.cpp:3792-3793 static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) { if (TC.begin() == TC.end()) return; rsmith wrote: > Do we need to clear the flag on this path too? (T

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe updated this revision to Diff 101302. jgorbe added a comment. Also clear the 'requires import' flag when the TypoCorrection has no decls at all. https://reviews.llvm.org/D30963 Files: lib/Sema/SemaLookup.cpp test/Modules/Inputs/crash-typo-correction-visibility/module.h test/Module

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe added a comment. Ping? https://reviews.llvm.org/D30963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current, types::TY_LLVM

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe added inline comments. Comment at: lib/Driver/Driver.cpp:2600-2603 + // When saving temps, add extra actions to write unoptimized and optimized + // IR besides the normal bitcode outputs if possible. This is not possible + // for multi-arch builds because

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe updated this revision to Diff 100954. jgorbe added a comment. Clarify that we only skip saving IR for multiarch Mach-O universal builds, not other multi-arch builds like CUDA. https://reviews.llvm.org/D33108 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cu

[PATCH] D32573: [Driver] Rename GetNamedOutputPath() to addNamedOutputPath()

jgorbe created this revision. The current name is confusing: it looks like it should just compute the path and return it but it has the side effect of appending it to the compilation's list of result files. This change changes the verb in the method name from "get" to "add" to emphasize this si

[PATCH] D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls.

jgorbe created this revision. The TypoCorrection::RequiresImport flag is managed by checkCorrectionVisibility() in SemaLookup.cpp. Currently, when none of the declarations in the typo correction are visible RequiresImport is set to true, and if there are no declarations, it's implicitly set to fal