[clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-04-09 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: > @slackito this will be fixed here: #135111 Thanks for the quick fix! https://github.com/llvm/llvm-project/pull/133610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-04-08 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: I have a reduced test case for the mangling issue mentioned [here](https://github.com/llvm/llvm-project/pull/133610#issuecomment-2784039483). It's still a bit long (118 lines), so apologies for that. [hash_mangling.txt](https://github.com/user-attachments/files/19654889/hash_ma

[clang] cuda clang: Clean up test dependency for CUDA surfaces (PR #134459)

2025-04-04 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/134459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cuda clang: Clean up test dependency for CUDA surfaces (PR #134459)

2025-04-04 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/134459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 412f7fa - [clang] Bump DIAG_SIZE_PARSE as we're hitting the limit downstream as of 6263de90df7f58c8b98475024d5eef102e10a372.

2025-04-04 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2025-04-04T14:39:57-07:00 New Revision: 412f7fa31607489dc400321968a70e114463b374 URL: https://github.com/llvm/llvm-project/commit/412f7fa31607489dc400321968a70e114463b374 DIFF: https://github.com/llvm/llvm-project/commit/412f7fa31607489dc400321968a70e114463b374.di

[clang] cuda clang: Add support for CUDA surfaces (PR #132883)

2025-04-03 Thread Jorge Gorbe Moya via cfe-commits
@@ -0,0 +1,3329 @@ +// RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s +#include "../Headers/Inputs/include/cuda.h" ---

[clang] Revert "[clang][bytecode] Stack-allocate bottom function frame" (PR #125325)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/125325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][bytecode] Stack-allocate bottom function frame" (PR #125325)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito created https://github.com/llvm/llvm-project/pull/125325 Reverts llvm/llvm-project#125253 It introduced an msan failure. Caught by a buildbot here: https://lab.llvm.org/buildbot/#/builders/164/builds/6922/steps/17/logs/stdio >From e9ca5033e880f1f6e28692fb86c0b97a1b

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: The problem described above also reproduced in one of the buildbots: https://lab.llvm.org/buildbot/#/builders/164/builds/6922/steps/17/logs/stdio I'll revert this patch. https://github.com/llvm/llvm-project/pull/125253 ___ cfe-commits

[clang] [clang][bytecode] Stack-allocate bottom function frame (PR #125253)

2025-01-31 Thread Jorge Gorbe Moya via cfe-commits
@@ -27,7 +27,7 @@ bool InterpState::inConstantContext() const { } InterpState::~InterpState() { - while (Current) { + while (Current && !Current->isBottomFrame()) { slackito wrote: This is causing use-after-destruction errors for me when running clang tests

[clang] [clang] StmtPrinter: Handle DeclRefExpr to a Decomposition (PR #125001)

2025-01-29 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito approved this pull request. I'm not very familiar with any of this code, but this looks like a straightforward workaround to me. I'll leave to you and the other reviewer the decision about what should be done to make the Analyzer do the right thing in the long-term

[clang] Reland: [clang] improve print / dump of anonymous declarations (PR #124858)

2025-01-29 Thread Jorge Gorbe Moya via cfe-commits
@@ -1257,28 +1257,48 @@ void StmtPrinter::VisitConstantExpr(ConstantExpr *Node) { } void StmtPrinter::VisitDeclRefExpr(DeclRefExpr *Node) { - if (const auto *OCED = dyn_cast(Node->getDecl())) { + ValueDecl *VD = Node->getDecl(); + if (const auto *OCED = dyn_cast(VD)) {

[clang] Reland: [clang] improve print / dump of anonymous declarations (PR #124858)

2025-01-29 Thread Jorge Gorbe Moya via cfe-commits
@@ -1257,28 +1257,48 @@ void StmtPrinter::VisitConstantExpr(ConstantExpr *Node) { } void StmtPrinter::VisitDeclRefExpr(DeclRefExpr *Node) { - if (const auto *OCED = dyn_cast(Node->getDecl())) { + ValueDecl *VD = Node->getDecl(); + if (const auto *OCED = dyn_cast(VD)) {

[clang] Reland: [clang] improve print / dump of anonymous declarations (PR #124858)

2025-01-29 Thread Jorge Gorbe Moya via cfe-commits
@@ -1257,28 +1257,48 @@ void StmtPrinter::VisitConstantExpr(ConstantExpr *Node) { } void StmtPrinter::VisitDeclRefExpr(DeclRefExpr *Node) { - if (const auto *OCED = dyn_cast(Node->getDecl())) { + ValueDecl *VD = Node->getDecl(); + if (const auto *OCED = dyn_cast(VD)) {

[clang] [llvm] [clang][Serialization] Stop including Frontend headers from Serialization (NFC) (PR #123140)

2025-01-16 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/123140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Serialization] Stop including Frontend headers from Serialization (NFC) (PR #123140)

2025-01-15 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito created https://github.com/llvm/llvm-project/pull/123140 The Frontend library depends on Serialization. This is an explicit dependency encoded in the CMake target. However, Serialization currently has an implicit dependency on Frontend, as it includes one of its hea

[clang] [clang][modules] Optimize construction and usage of the submodule index (PR #113391)

2024-10-28 Thread Jorge Gorbe Moya via cfe-commits
@@ -541,11 +541,14 @@ class ModuleMap { /// /// \param IsExplicit Whether this is an explicit submodule. /// - /// \returns The found or newly-created module, along with a boolean value - /// that will be true if the module is newly-created. - std::pair findOrCreateMod

[clang] [llvm] Revert "Reapply "Add source file name for template instantiations in -ftime-trace"" (PR #99731)

2024-07-19 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito closed https://github.com/llvm/llvm-project/pull/99731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "Reapply "Add source file name for template instantiations in -ftime-trace"" (PR #99731)

2024-07-19 Thread Jorge Gorbe Moya via cfe-commits
https://github.com/slackito created https://github.com/llvm/llvm-project/pull/99731 Reverts llvm/llvm-project#99545 There were a couple of issues reported in the PR: a sanitizer warning (https://lab.llvm.org/buildbot/#/builders/164/builds/1246/steps/14/logs/stdio) and a tmp file accidentally

[clang] d4ff961 - Add missing #include for ObjCMethodDecl.

2024-05-30 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2024-05-30T15:42:57-07:00 New Revision: d4ff9615a1531f4a466b7d1fb0f175e3ae489289 URL: https://github.com/llvm/llvm-project/commit/d4ff9615a1531f4a466b7d1fb0f175e3ae489289 DIFF: https://github.com/llvm/llvm-project/commit/d4ff9615a1531f4a466b7d1fb0f175e3ae489289.di

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-04-17 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: The following program fails to build after this change: ``` #include #include template struct X { void f() { values_.reset(new int64_t[123][65]); } std::unique_ptr values_; }; int main() { X x; x.f(); } ``` you get similar errors with both libstdc++: ``` jgorbe@

[clang] 2b2881b - Add namespace qualifier for llvm::StringRef

2024-02-21 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2024-02-21T14:16:27-08:00 New Revision: 2b2881b0ae94e56aa019b519419d122bb7b81462 URL: https://github.com/llvm/llvm-project/commit/2b2881b0ae94e56aa019b519419d122bb7b81462 DIFF: https://github.com/llvm/llvm-project/commit/2b2881b0ae94e56aa019b519419d122bb7b81462.di

[clang] fcbb4e1 - [NFCI] Fix unused variable warning with asserts off in clang/lib/Sema/TypeLocBuilder.cpp

2022-07-12 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-07-12T17:40:41-07:00 New Revision: fcbb4e1fa42793edc9531d59d047e6bd0909d3d3 URL: https://github.com/llvm/llvm-project/commit/fcbb4e1fa42793edc9531d59d047e6bd0909d3d3 DIFF: https://github.com/llvm/llvm-project/commit/fcbb4e1fa42793edc9531d59d047e6bd0909d3d3.di

[clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

2022-07-12 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-07-12T16:46:58-07:00 New Revision: ee88c0cf09969ba44307068797e12533b94768a6 URL: https://github.com/llvm/llvm-project/commit/ee88c0cf09969ba44307068797e12533b94768a6 DIFF: https://github.com/llvm/llvm-project/commit/ee88c0cf09969ba44307068797e12533b94768a6.di

[clang] 7dcd698 - Use writable temporary file for test compiler output instead of hardcoded name. NFCI.

2022-04-08 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-04-08T10:57:27-07:00 New Revision: 7dcd698875cc6c73a9b10acad1b55aeb08bc9fca URL: https://github.com/llvm/llvm-project/commit/7dcd698875cc6c73a9b10acad1b55aeb08bc9fca DIFF: https://github.com/llvm/llvm-project/commit/7dcd698875cc6c73a9b10acad1b55aeb08bc9fca.di

[clang] 5b81158 - Revert "[clang-format] Handle attributes before case label."

2022-03-21 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-03-21T14:39:14-07:00 New Revision: 5b811586758808ce3335272d5b41852cf87666c7 URL: https://github.com/llvm/llvm-project/commit/5b811586758808ce3335272d5b41852cf87666c7 DIFF: https://github.com/llvm/llvm-project/commit/5b811586758808ce3335272d5b41852cf87666c7.di

[clang-tools-extra] de9611b - [NFC] Don't pass temporary LangOptions to Lexer

2022-02-28 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2022-02-28T12:53:59-08:00 New Revision: de9611befeebeb85324062cb1ae8978a82a09e26 URL: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26 DIFF: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26.di

[clang] 770ddf5 - Fix unused variable warning in release build

2021-11-09 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2021-11-09T19:48:42-08:00 New Revision: 770ddf599d28e8b0aef38166bed899b0194f4d8b URL: https://github.com/llvm/llvm-project/commit/770ddf599d28e8b0aef38166bed899b0194f4d8b DIFF: https://github.com/llvm/llvm-project/commit/770ddf599d28e8b0aef38166bed899b0194f4d8b.di

[clang-tools-extra] 74add1b - Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)"

2021-11-09 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2021-11-09T11:28:48-08:00 New Revision: 74add1b6d6d377ab2cdce26699cf798110817e42 URL: https://github.com/llvm/llvm-project/commit/74add1b6d6d377ab2cdce26699cf798110817e42 DIFF: https://github.com/llvm/llvm-project/commit/74add1b6d6d377ab2cdce26699cf798110817e42.di

[libunwind] 82576d6 - [libunwind] Fix UB in EHHeaderParser::findFDE

2020-04-07 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2020-04-07T14:44:42-07:00 New Revision: 82576d6fecfec71725eb900111c000d772002449 URL: https://github.com/llvm/llvm-project/commit/82576d6fecfec71725eb900111c000d772002449 DIFF: https://github.com/llvm/llvm-project/commit/82576d6fecfec71725eb900111c000d772002449.di

[libunwind] 1ae8d81 - [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state

2020-02-18 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2020-02-18T11:57:18-08:00 New Revision: 1ae8d81147a0724cc972054afbd72943032e4832 URL: https://github.com/llvm/llvm-project/commit/1ae8d81147a0724cc972054afbd72943032e4832 DIFF: https://github.com/llvm/llvm-project/commit/1ae8d81147a0724cc972054afbd72943032e4832.di

r374844 - Revert "Dead Virtual Function Elimination"

2019-10-14 Thread Jorge Gorbe Moya via cfe-commits
Author: jgorbe Date: Mon Oct 14 16:25:25 2019 New Revision: 374844 URL: http://llvm.org/viewvc/llvm-project?rev=374844&view=rev Log: Revert "Dead Virtual Function Elimination" This reverts commit 9f6a873268e1ad9855873d9d8007086c0d01cf4f. Removed: cfe/trunk/test/CodeGenCXX/vcall-visibility-me

r359361 - Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC.

2019-04-26 Thread Jorge Gorbe Moya via cfe-commits
Author: jgorbe Date: Fri Apr 26 17:32:04 2019 New Revision: 359361 URL: http://llvm.org/viewvc/llvm-project?rev=359361&view=rev Log: Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC. This reverts r359059 (git commit 0b098754b73f3b96d00ecb1c7605760b11c

[libunwind] r350787 - Revert "[Sparc] Add Sparc V8 support"

2019-01-09 Thread Jorge Gorbe Moya via cfe-commits
Author: jgorbe Date: Wed Jan 9 17:08:31 2019 New Revision: 350787 URL: http://llvm.org/viewvc/llvm-project?rev=350787&view=rev Log: Revert "[Sparc] Add Sparc V8 support" This reverts commit r350705. Modified: libunwind/trunk/include/__libunwind_config.h libunwind/trunk/include/libunwind

r347402 - Mark lambda decl as invalid if a captured variable has an invalid type.

2018-11-21 Thread Jorge Gorbe Moya via cfe-commits
Author: jgorbe Date: Wed Nov 21 09:49:37 2018 New Revision: 347402 URL: http://llvm.org/viewvc/llvm-project?rev=347402&view=rev Log: Mark lambda decl as invalid if a captured variable has an invalid type. This causes the compiler to crash when trying to compute a layout for the lambda closure typ

Re: r342668 - Add testcases for r342667.

2018-09-20 Thread Jorge Gorbe Moya via cfe-commits
Filed https://bugs.llvm.org/show_bug.cgi?id=39029 for the incorrect behavior when including a path with a leading slash on Windows. On Thu, Sep 20, 2018 at 3:35 PM Eric Christopher wrote: > Thank you! > > On Thu, Sep 20, 2018, 3:34 PM Zachary Turner wrote: > >> Test removed in r342693. >> >> On

Re: r342668 - Add testcases for r342667.

2018-09-20 Thread Jorge Gorbe Moya via cfe-commits
Zach and I were able to find the cause. Clang on Windows manages to find "file.h" when you #include "/file.h" and that makes the expected diagnostic not appear. MSVC inteprets an #include with a leading slash as an absolute path so I think we have accidentally hit a different bug in Clang :) One