[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

jgorbe added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4012-4018 + if (Target->getTriple().isWasm() && Target->hasFeature("reference-types")) { +#define WASM_REF_TYPE(Name, MangledName, Id, SingletonId, AS) \ + if (BuiltinType::Id == BuiltinTyp

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

jgorbe added a comment. By the way, the line number for `llvm::misexpect::verifyMisExpect` in the stack trace above includes the debug `printf`s I inserted to get the variable values so it won't match the exact line number in the repo. But I think that's the only call to `BranchProbability` in

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

jgorbe added a comment. Hi, this patch is causing floating point exceptions for us during profile generation. On a debug build I get this assertion failure (see stack trace below): clang: /usr/local/google/home/jgorbe/code/llvm/llvm/lib/Support/BranchProbability.cpp:41: llvm::BranchProbabil

[PATCH] D121450: [clang-format] Handle attributes before case label.

jgorbe added a comment. Hi, We've observed that this patch introduces infinite loops in some cases. Here's a reduced test case: export class Foo extends Bar { get case(): Case { return ( (this.Bar$has('case')) ? (this.Bar$get('case')) : (

[PATCH] D51650: Implement target_clones multiversioning

jgorbe added a comment. This breaks some existing code (we have found this issue building the JPEG XL library at github.com/libjxl). This is a very simplified version of the problem: #pragma clang attribute push(__attribute__((target("sse2,ssse3"))), apply_to = function) __attribute__((targ

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

jgorbe added a comment. This change is causing asan errors when running the clang-tidy checks under ASan, most likely because of the reason akuegel pointed out in his comment. I'm going to revert the patch to unbreak HEAD until the problem can be fixed. Repository: rG LLVM Github Monorepo C

[PATCH] D100466: clang-format: [JS] merge import lines.

jgorbe added a comment. Hi, one of our tests is failing because of this patch and it looks like an actual bug. clang-format now turns this file: import './a'; import {bar} from './a'; into this: barimport './a'; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

jgorbe added a comment. Hi, I found a clang crash that seems to be caused by this patch. Here's a reduced test case: template class a { public: ~a(); void b(); }; template a::~a() try { b(); } catch (...) { } class d { public: d(const char *, int);

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe updated this revision to Diff 174944. jgorbe added a comment. Folded the two test cases (capturing an invalid type and capturing an invalid array type) into a single file. https://reviews.llvm.org/D54550 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/lambda-invalid-capture.cp

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe added a comment. Added a test for the "capturing an array of incomplete type" case. See also responses to inline comments below. Comment at: clang/lib/Sema/SemaExpr.cpp:14946 + // as invalid as well. + if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) { +

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe updated this revision to Diff 174853. jgorbe marked 2 inline comments as done. https://reviews.llvm.org/D54550 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/lambda-invalid-array-capture.cpp clang/test/SemaCXX/lambda-invalid-capture.cpp Index: clang/test/SemaCXX/lambda-inval

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14946 + // as invalid as well. + if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) { +if (RD->isInvalidDecl()) { rsmith wrote: > You'

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe updated this revision to Diff 174118. jgorbe added a comment. Fixed some issues pointed out in review comments: - call to getBaseElementType before checking type validity. - when the type is incomplete, mark not only the lambda closure type as invalid but also the field Also, added a cou

[PATCH] D54550: Mark lambda decl as invalid if a captured variable has an invalid type.

jgorbe created this revision. jgorbe added a reviewer: rsmith. This causes the compiler to crash when trying to compute a layout for the lambda closure type (see included test). Repository: rC Clang https://reviews.llvm.org/D54550 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/lam