Midar wrote:
Thanks for merging! Is there a way to get this into 20.1.2?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Thanks, that looks like it'll have to wait for 21.
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
@rjmccall What's required to get this merged now that it has your LGTM?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -,6 +,96 @@ class CGObjCObjFW: public CGObjCGNU {
return ClassSymbol;
}
+ void GenerateDirectMethodPrologue(
+ CodeGenFunction &CGF, llvm::Function *Fn, const ObjCMethodDecl *OMD,
+ const ObjCContainerDecl *CD) override {
+auto &Builder = CGF.Bu
Midar wrote:
@rjmccall @davidchisnall @ahatanak Could any of you have a look, please? I'd
think this is rather straightforward.
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Copied the necessary parts from CGObjCMac to just ObjFW, as GNUstep decided to
do it very differently.
Theoretically, the same could be done for the GCC runtime. Should it?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits
https://github.com/Midar ready_for_review
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar updated
https://github.com/llvm/llvm-project/pull/126382
>From ddc24b92cb8cc629082d0943de0f726a7604241e Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Sat, 8 Feb 2025 12:12:21 +0100
Subject: [PATCH] Allow direct dispatch for the ObjFW runtime
---
clang/includ
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar updated
https://github.com/llvm/llvm-project/pull/126382
>From 9b076179061731a647921271e400dbdaea31f60d Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Sat, 8 Feb 2025 12:12:21 +0100
Subject: [PATCH] Allow direct dispatch for the ObjFW runtime >= 1.3
---
clang
https://github.com/Midar converted_to_draft
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Actually, I realized this needs more work, as GenerateDirectMethodPrologue
needs to be implemented. Moving to draft.
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
Midar wrote:
Also, would it be possible to get this into 20.1?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Midar wrote:
Would @rjmccall be the appropriate reviewer?
https://github.com/llvm/llvm-project/pull/126382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar created
https://github.com/llvm/llvm-project/pull/126382
There was no reason for it to ever be disabled.
>From 28cc71ac247b1fc8d4d9d4ecd7ea3f210bca3ef2 Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Sat, 8 Feb 2025 12:12:21 +0100
Subject: [PATCH] Allow direct
Midar wrote:
These symbols are just used to deduplicate strings: That's why they're hidden
and in COMDAT. So I don't think it'll break or fix the ABI ;).
https://github.com/llvm/llvm-project/pull/88713
___
cfe-commits mailing list
cfe-commits@lists.ll
Midar wrote:
Maybe @rjmccall would be a good reviewer?
https://github.com/llvm/llvm-project/pull/88713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Midar updated https://github.com/llvm/llvm-project/pull/88713
>From 8dc7333c0e9c757bba91ebfbe57280ad0635afa9 Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Mon, 15 Apr 2024 13:36:05 +0200
Subject: [PATCH] Fix objc_sel_{name,types} missing an underscore
The other plac
https://github.com/Midar created https://github.com/llvm/llvm-project/pull/88713
The other places all use the underscore.
This is just a quick drive-by commit, LMK if more is needed.
>From e39e2fc218c588d66937211f98a25eb2acf00a6b Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer
Date: Mon, 15
> Testcase?
Shouldn't be necessary for such a simple and extremely obvious one-liner.
--
Jonathan
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Use the correct EH personality for ObjC++ code.
Previously, it would just always use the ObjC DWARF personality, even with SjLj
or SEH exceptions.
diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp
index 228efec51b..ca1535182e 100644
--- a/lib/CodeGen/CGException.cpp
+++ b/li
Sorry, it seems the inline patch has been garbled.
Trying as an attachment this time.
0001-Use-the-correct-ObjC-EH-personality.patch
Description: Binary data
--
Jonathan
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Use the correct ObjC EH personality
This fixes ObjC exceptions on Win64 (which uses SEH), among others.
---
lib/CodeGen/CGCleanup.h | 2 ++
lib/CodeGen/CGException.cpp | 8
2 files changed, 10 insertions(+)
diff --git a/lib/CodeGen/CGCleanup.h b/lib/CodeGen/CGCleanup.h
index 2166490ec1
28 matches
Mail list logo
