https://github.com/JonasToth closed
https://github.com/llvm/llvm-project/pull/118209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -27,6 +27,39 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Arithmetic with smaller integer types than ``int`` trigger implicit
conversions,
+as explained under `"Integral Promotion" on c
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f7f570b3fa5a96cd3eb140abd02e4351a4586e26 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f4345664e10ac6a9e87b33b1e816b685a1355bb6 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH 1/2] [clang-tidy][docs] improve documentation on
cppcoreguidelines
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f4345664e10ac6a9e87b33b1e816b685a1355bb6 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From 4340df440863de154ed305dc487d23ef46c9277a Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH 1/2] [clang-tidy][docs] improve documentation on
cppcoreguidelines
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
+T
https://github.com/JonasToth edited
https://github.com/llvm/llvm-project/pull/118209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
--
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
--
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From 4340df440863de154ed305dc487d23ef46c9277a Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
+T
JonasToth wrote:
@PiotrZSL I did assign you as reviewer because I noticed you do many reviews.
Please remove yourself if that was not appropriate.
I did not contribute to clang-tidy for a longer period and not sure who to
assign (if any!) for the PR. It was not meant offensively or so :)
https
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From b10c536f66521249a374908f0bd0eb1fe2ff42ad Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
https://github.com/JonasToth created
https://github.com/llvm/llvm-project/pull/118209
This PR improves the docs for this check to include an example of hidden
narrowing conversions from the integer promotion rules in arithmetic.
>From c662917b248335c85714e791f55e12e834baa87d Mon Sep 17 00:00:0
JonasToth wrote:
As you requested my review:
The original linking was done for the `ExprMutAnalyzer` used in
'misc-const-correctness'. If clang-tidy is builtin without static analyzer
Support, you get linker failure.
If the `ExprMutAnalyzer` is moved (back) to clang-tidy, the issue is not
ex
Author: Jonas Toth
Date: 2022-09-26T10:39:11+02:00
New Revision: e66345d54d5f5e803f54c1ace487d57bb11ee884
URL:
https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884
DIFF:
https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884.diff
LO
Author: Jonas Toth
Date: 2022-08-29T11:20:47+02:00
New Revision: b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4
URL:
https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4
DIFF:
https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4.diff
LO
Author: Jonas Toth
Date: 2022-07-24T19:37:54+02:00
New Revision: 46ae26e7eb7095faeda6d6c15470c256f9294c48
URL:
https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48
DIFF:
https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48.diff
LO
Author: Jonas Toth
Date: 2022-04-24T17:17:02+02:00
New Revision: 3f0f20366622ee5fd35a1d65d7db5226f5e5751f
URL:
https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f
DIFF:
https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f.diff
LO
Author: Jonas Toth
Date: 2020-10-09T13:45:32+02:00
New Revision: e517e5cfec90a00a488ad8df901ab9b903ebb966
URL:
https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966
DIFF:
https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966.diff
LO
Author: Jonas Toth
Date: 2020-09-24T13:13:38+02:00
New Revision: 4e534900476d2a5c620e74ddb9c9e7d321e6d443
URL:
https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443
DIFF:
https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443.diff
LO
Author: Jonas Toth
Date: 2020-09-15T21:07:30+02:00
New Revision: 69f98311ca42127df92527b6fc3be99841a15f12
URL:
https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12
DIFF:
https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12.diff
LO
Hi Anshil,
take a look at this: https://clang.llvm.org/docs/InternalsManual.html
cxx1x is probably done already, but cxx2a has some outstanding features ;)
In general, please use 'cfe-dev' instead of 'cfe-commits'. There is the
normal discussion and questions/answers for developers.
Regards Jon
Author: Jonas Toth
Date: 2020-01-11T19:41:27+01:00
New Revision: 23a799adf0abbe9a7be1494d5efd1ab3215ee4fb
URL:
https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb
DIFF:
https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb.diff
LO
Author: Jonas Toth
Date: 2020-01-11T19:21:03+01:00
New Revision: 4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4
URL:
https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4
DIFF:
https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4.diff
LO
Author: Jonas Toth
Date: 2020-01-10T16:10:55+01:00
New Revision: cdd05f2aea3b950a4e2c496175117e6b47b2a050
URL:
https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050
DIFF:
https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050.diff
LO
Author: Jonas Toth
Date: 2020-01-03T22:32:10+01:00
New Revision: 48ee04033cce2e085fd8909c6ebaa0de68ab65d0
URL:
https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0
DIFF:
https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0.diff
LO
Author: Jonas Toth
Date: 2020-01-03T22:02:11+01:00
New Revision: fed2a5033af564af390faa8f8438018fe747126a
URL:
https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a
DIFF:
https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a.diff
LO
Author: Jonas Toth
Date: 2020-01-03T21:55:51+01:00
New Revision: 05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8
URL:
https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8
DIFF:
https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8.diff
LO
Author: Jonas Toth
Date: 2020-01-03T20:37:47+01:00
New Revision: cf48101200ee192dd82e6ed0512ae42e7b3162a9
URL:
https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9
DIFF:
https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9.diff
LO
Author: jonastoth
Date: Thu May 16 05:39:22 2019
New Revision: 360883
URL: http://llvm.org/viewvc/llvm-project?rev=360883&view=rev
Log:
[clang-tidy] Removed superfluous and slightly annoying newlines in
run-clang-tidy's output.
Summary: The output of clang-tidy itself already has enough newlines
Author: jonastoth
Date: Thu May 16 05:35:00 2019
New Revision: 360882
URL: http://llvm.org/viewvc/llvm-project?rev=360882&view=rev
Log:
[clang-tidy] Handle member variables in readability-simplify-boolean-expr
- Add readability-simplify-boolean-expr test cases for member variables
Fixes PR40179
Author: jonastoth
Date: Thu May 16 02:22:39 2019
New Revision: 360869
URL: http://llvm.org/viewvc/llvm-project?rev=360869&view=rev
Log:
[clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.
Summary: When run-clang-tidy is given the -quiet flag, do not output the
potenti
Author: jonastoth
Date: Thu Feb 28 09:53:51 2019
New Revision: 355108
URL: http://llvm.org/viewvc/llvm-project?rev=355108&view=rev
Log:
[clang-tidy] fix documentation link in list of clang-tidy checks
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-ext
Author: jonastoth
Date: Thu Feb 28 07:56:40 2019
New Revision: 355102
URL: http://llvm.org/viewvc/llvm-project?rev=355102&view=rev
Log:
[clang-tidy] redirection in list of checks adjusted
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-extra/trunk/docs
Author: jonastoth
Date: Thu Feb 28 07:47:10 2019
New Revision: 355100
URL: http://llvm.org/viewvc/llvm-project?rev=355100&view=rev
Log:
[clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of
checks and fix redirection
Modified:
clang-tools-extra/trunk/docs/clang-tidy/c
Author: jonastoth
Date: Thu Feb 28 07:39:47 2019
New Revision: 355098
URL: http://llvm.org/viewvc/llvm-project?rev=355098&view=rev
Log:
[clang-tidy] documentation fixing the actual correct file
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst
Modified:
cl
Author: jonastoth
Date: Thu Feb 28 07:28:36 2019
New Revision: 355097
URL: http://llvm.org/viewvc/llvm-project?rev=355097&view=rev
Log:
[clang-tidy] tryfix documenation continued
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-subtraction.rst
Modified:
clang-tools-
Author: jonastoth
Date: Thu Feb 28 07:18:54 2019
New Revision: 355095
URL: http://llvm.org/viewvc/llvm-project?rev=355095&view=rev
Log:
[clang-tidy] another issue in documentation, double empty line seemed to
confuse code-block
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/abseil
Author: jonastoth
Date: Thu Feb 28 07:01:17 2019
New Revision: 355094
URL: http://llvm.org/viewvc/llvm-project?rev=355094&view=rev
Log:
[clang-tidy] attempt to fix documentation build-error
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst
Modified:
clang-
Author: jonastoth
Date: Thu Feb 28 06:55:12 2019
New Revision: 355093
URL: http://llvm.org/viewvc/llvm-project?rev=355093&view=rev
Log:
[clang-tidy] added cppcoreguidelines-explicit-virtual-functions
Addresses the bugzilla bug #30397. (https://bugs.llvm.org/show_bug.cgi?id=30397)
modernize-use-ov
Author: jonastoth
Date: Tue Feb 26 10:15:17 2019
New Revision: 354903
URL: http://llvm.org/viewvc/llvm-project?rev=354903&view=rev
Log:
[clang-tidy] undo bitfields in ExceptionAnalyzer
Scoped enums do induce some problems with some MSVC and GCC versions
if used as bitfields. Therefor this is deac
Author: jonastoth
Date: Wed Feb 20 13:04:36 2019
New Revision: 354517
URL: http://llvm.org/viewvc/llvm-project?rev=354517&view=rev
Log:
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Summary:
The analsis on the throwing behvaiour on functions and statements gave only
a bin
Author: jonastoth
Date: Thu Feb 7 03:00:59 2019
New Revision: 353389
URL: http://llvm.org/viewvc/llvm-project?rev=353389&view=rev
Log:
[clang-tidy] Fixed a std::bind() transformation
There was an extra semicolon that was somehow working in some contexts.
Patch by oleg.smolsky.
Modified:
cl
Author: jonastoth
Date: Thu Jan 31 02:46:37 2019
New Revision: 352741
URL: http://llvm.org/viewvc/llvm-project?rev=352741&view=rev
Log:
[clang-tidy] refactor bugprone-exception-escape analysis into class
Summary:
The check `bugprone-exception-escape` does an AST-based analysis to determine
if a f
Author: jonastoth
Date: Fri Jan 25 11:05:12 2019
New Revision: 352231
URL: http://llvm.org/viewvc/llvm-project?rev=352231&view=rev
Log:
[clang-tidy] fix unit tests for dropped _Float16 support in X86
Summary:
Because _Float16 was disabled for X86 targets the unit-tests started failing.
Extract th
Author: jonastoth
Date: Mon Jan 21 05:26:18 2019
New Revision: 351743
URL: http://llvm.org/viewvc/llvm-project?rev=351743&view=rev
Log:
[clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers
Summary:
This patch adds two unit-tests that are the result of reducing a crashing TU
Author: jonastoth
Date: Fri Jan 18 10:03:11 2019
New Revision: 351569
URL: http://llvm.org/viewvc/llvm-project?rev=351569&view=rev
Log:
[clang-tidy] add reproducer for PR39949 into test-suite
Summary:
The underlying issue is fixed in https://reviews.llvm.org/D56444
and this test ensures the issue
Author: jonastoth
Date: Thu Jan 10 03:56:44 2019
New Revision: 350814
URL: http://llvm.org/viewvc/llvm-project?rev=350814&view=rev
Log:
[clang-tidy] Fix case of local variables in modernize-use-nodiscard checker
Summary:
Correct the case of the local variables..
Rational:
I want to be able to ru
Author: jonastoth
Date: Wed Jan 9 13:27:59 2019
New Revision: 350765
URL: http://llvm.org/viewvc/llvm-project?rev=350765&view=rev
Log:
[clang-tidy] another take at fixing doc
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst
Modified:
clang-tools-extra/tr
Author: jonastoth
Date: Wed Jan 9 13:19:44 2019
New Revision: 350763
URL: http://llvm.org/viewvc/llvm-project?rev=350763&view=rev
Log:
[clang-tidy] tryfix documentation build
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst
Modified:
clang-tools-extra/tr
Author: jonastoth
Date: Wed Jan 9 13:03:54 2019
New Revision: 350761
URL: http://llvm.org/viewvc/llvm-project?rev=350761&view=rev
Log:
[clang-tidy] fix-up failing tests
Removed:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nodiscard.h
Modified:
clang-tools-extra/trunk/test/clang
Author: jonastoth
Date: Wed Jan 9 12:50:50 2019
New Revision: 350760
URL: http://llvm.org/viewvc/llvm-project?rev=350760&view=rev
Log:
[clang-tidy] Adding a new modernize use nodiscard checker
Summary: Adds a checker to clang-tidy to warn when a non void const member
function, taking only param
Author: jonastoth
Date: Sat Jan 5 03:40:05 2019
New Revision: 350466
URL: http://llvm.org/viewvc/llvm-project?rev=350466&view=rev
Log:
[Documentation] fix order of checks in checks/list.rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-extra/trunk/d
Author: jonastoth
Date: Tue Dec 11 04:45:51 2018
New Revision: 348842
URL: http://llvm.org/viewvc/llvm-project?rev=348842&view=rev
Log:
Use the standard Duration factory matcher
Summary: A new check came in over the weekend; it should use our existing
infrastructure for matching `absl::Duration`
Author: jonastoth
Date: Tue Dec 11 04:42:17 2018
New Revision: 348840
URL: http://llvm.org/viewvc/llvm-project?rev=348840&view=rev
Log:
[clang-tidy] NFC Consolidate test absl::Time implementation
Summary: Several tests re-implement these same prototypes (differently), so we
can put them in a com
Author: jonastoth
Date: Mon Dec 10 11:41:53 2018
New Revision: 348793
URL: http://llvm.org/viewvc/llvm-project?rev=348793&view=rev
Log:
[clang-tidy] insert release notes for new checkers alphabetically
Summary:
Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem
to a
Author: jonastoth
Date: Wed Dec 5 01:34:18 2018
New Revision: 348344
URL: http://llvm.org/viewvc/llvm-project?rev=348344&view=rev
Log:
Revert "[clang-tidy] new check: bugprone-branch-clone"
The patch broke on buildbot with assertion-failure. Revert until this
is figured out.
Removed:
clang-
Author: jonastoth
Date: Wed Dec 5 01:16:25 2018
New Revision: 348343
URL: http://llvm.org/viewvc/llvm-project?rev=348343&view=rev
Log:
[clang-tidy] new check: bugprone-branch-clone
Summary:
Implement a check for detecting if/else if/else chains where two or more
branches are Type I clones of eac
Author: jonastoth
Date: Wed Dec 5 00:29:56 2018
New Revision: 348341
URL: http://llvm.org/viewvc/llvm-project?rev=348341&view=rev
Log:
Fix a false positive in misplaced-widening-cast
Summary:
bugprone-misplaced-widening-cast check
used to give a false warning to the
following example.
enum Day
Author: jonastoth
Date: Mon Dec 3 11:41:04 2018
New Revision: 348172
URL: http://llvm.org/viewvc/llvm-project?rev=348172&view=rev
Log:
[clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove
previous wrong attempt at doing so
Modified:
clang-tools-extra/trunk/clang-t
Author: jonastoth
Date: Mon Dec 3 11:22:08 2018
New Revision: 348169
URL: http://llvm.org/viewvc/llvm-project?rev=348169&view=rev
Log:
[clang-tidy] Recommit: Add the abseil-duration-comparison check
Summary:
This check finds instances where Duration values are being converted to a
numeric value
Author: jonastoth
Date: Mon Dec 3 10:59:27 2018
New Revision: 348165
URL: http://llvm.org/viewvc/llvm-project?rev=348165&view=rev
Log:
Revert "[clang-tidy] Add the abseil-duration-comparison check"
This commit broke buildbots and needs adjustments.
Removed:
clang-tools-extra/trunk/clang-tid
Author: jonastoth
Date: Mon Dec 3 10:35:56 2018
New Revision: 348161
URL: http://llvm.org/viewvc/llvm-project?rev=348161&view=rev
Log:
[clang-tidy] Add the abseil-duration-comparison check
Summary:
This check finds instances where Duration values are being converted to a
numeric value in a comp
Author: jonastoth
Date: Tue Nov 27 09:28:38 2018
New Revision: 347676
URL: http://llvm.org/viewvc/llvm-project?rev=347676&view=rev
Log:
Revert "[clang] - Simplify tools::SplitDebugName."
This reverts commit r347035 as it introduced assertion failures under
certain conditions. More information can
Author: jonastoth
Date: Mon Nov 12 09:22:36 2018
New Revision: 346678
URL: http://llvm.org/viewvc/llvm-project?rev=346678&view=rev
Log:
Revert "Add a test checking clang-tidy can find libc++ on Mac"
This reverts commit r346653.
Removed:
clang-tools-extra/trunk/test/clang-tidy/Inputs/mock-li
Author: jonastoth
Date: Mon Nov 12 09:02:05 2018
New Revision: 346676
URL: http://llvm.org/viewvc/llvm-project?rev=346676&view=rev
Log:
[clang-tidy] fix ARM tests, because int and long have same width
Modified:
clang-tools-extra/trunk/test/clang-tidy/bugprone-too-small-loop-variable.cpp
Modi
Author: jonastoth
Date: Mon Nov 12 08:01:39 2018
New Revision: 346665
URL: http://llvm.org/viewvc/llvm-project?rev=346665&view=rev
Log:
[clang-tidy] new check: bugprone-too-small-loop-variable
The new checker searches for those for loops which has a loop variable with a
"too small" type which me
Author: jonastoth
Date: Fri Nov 9 12:57:28 2018
New Revision: 346555
URL: http://llvm.org/viewvc/llvm-project?rev=346555&view=rev
Log:
[clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in
pro-bounds-array-to-pointer-decay
Summary:
The fix to the issue that `const char* p = ("foo
Author: jonastoth
Date: Fri Nov 9 12:54:06 2018
New Revision: 346554
URL: http://llvm.org/viewvc/llvm-project?rev=346554&view=rev
Log:
[ASTMatchers] overload ignoringParens for Expr
Summary: This patch allows fixing PR39583.
Reviewers: aaron.ballman, sbenza, klimek
Reviewed By: aaron.ballman
Author: jonastoth
Date: Mon Nov 5 14:30:17 2018
New Revision: 346176
URL: http://llvm.org/viewvc/llvm-project?rev=346176&view=rev
Log:
[clang-tidy] fix example code-blocks indendation
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst
Author: jonastoth
Date: Mon Nov 5 14:21:27 2018
New Revision: 346173
URL: http://llvm.org/viewvc/llvm-project?rev=346173&view=rev
Log:
[clang-tidy] doc removew hitespace in front of code-block-line
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/boost-use-to-string.rst
clang-to
Author: jonastoth
Date: Fri Nov 2 09:36:21 2018
New Revision: 345995
URL: http://llvm.org/viewvc/llvm-project?rev=345995&view=rev
Log:
[fix][clang-tidy] fix for r345961 that introduced a test failure on Windows
builds
r345961 introduced a path check in
.\tools\clang\tools\extra\test\clang-tidy\
Author: jonastoth
Date: Wed Oct 31 10:26:10 2018
New Revision: 345742
URL: http://llvm.org/viewvc/llvm-project?rev=345742&view=rev
Log:
[clang-tidy] add missing '--' in RUN-line, unbreak buildbot
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp
Modified:
Author: jonastoth
Date: Wed Oct 31 10:08:09 2018
New Revision: 345738
URL: http://llvm.org/viewvc/llvm-project?rev=345738&view=rev
Log:
[clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp
M
Author: jonastoth
Date: Wed Oct 31 10:00:50 2018
New Revision: 345737
URL: http://llvm.org/viewvc/llvm-project?rev=345737&view=rev
Log:
[clang] try-fix broken documentation builder
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewv
Author: jonastoth
Date: Wed Oct 31 09:59:41 2018
New Revision: 345736
URL: http://llvm.org/viewvc/llvm-project?rev=345736&view=rev
Log:
[clang-tools-extra] fix broken link in release notes
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseN
Author: jonastoth
Date: Wed Oct 31 09:50:44 2018
New Revision: 345735
URL: http://llvm.org/viewvc/llvm-project?rev=345735&view=rev
Log:
[clang-tidy] new check 'readability-isolate-declaration'
Summary:
This patch introduces a new clang-tidy check that matches on all `declStmt`
that declare more
Author: jonastoth
Date: Wed Oct 24 10:40:50 2018
New Revision: 345167
URL: http://llvm.org/viewvc/llvm-project?rev=345167&view=rev
Log:
[clang-tidy] Add the abseil-duration-factory-float check
Summary:
This check finds cases where calls to an absl::Duration factory could use the
more efficient i
Author: jonastoth
Date: Mon Oct 22 13:29:15 2018
New Revision: 344947
URL: http://llvm.org/viewvc/llvm-project?rev=344947&view=rev
Log:
[clang-tidy] tryfix windows build
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp
Modified:
clang-tools-extra/trunk/clan
Author: jonastoth
Date: Mon Oct 22 12:20:01 2018
New Revision: 344940
URL: http://llvm.org/viewvc/llvm-project?rev=344940&view=rev
Log:
[clang-tidy] implement cppcoreguidelines macro rules
Summary:
In short macros are discouraged by multiple rules (and sometimes reference
randomly). [Enum.1], [E
Author: jonastoth
Date: Sat Oct 13 02:30:58 2018
New Revision: 32
URL: http://llvm.org/viewvc/llvm-project?rev=32&view=rev
Log:
Revert "[clang-tidy] New checker for not null-terminated result caused by
strlen(), size() or equal length"
This reverts commit r344374.
Removed:
clang-too
Author: jonastoth
Date: Sat Oct 13 02:30:46 2018
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"
This reverts commit r344379.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/
Author: jonastoth
Date: Fri Oct 12 10:57:18 2018
New Revision: 344388
URL: http://llvm.org/viewvc/llvm-project?rev=344388&view=rev
Log:
[Doc] fix second error in UsersManual
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-pr
Author: jonastoth
Date: Fri Oct 12 10:47:43 2018
New Revision: 344384
URL: http://llvm.org/viewvc/llvm-project?rev=344384&view=rev
Log:
[clangd] NFC fix semicolon warning
Modified:
clang-tools-extra/trunk/clangd/index/IndexAction.cpp
Modified: clang-tools-extra/trunk/clangd/index/IndexAction
Author: jonastoth
Date: Fri Oct 12 10:44:01 2018
New Revision: 344382
URL: http://llvm.org/viewvc/llvm-project?rev=344382&view=rev
Log:
[Doc] fix BB, add code-block type
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-projec
Author: jonastoth
Date: Fri Oct 12 10:36:04 2018
New Revision: 344379
URL: http://llvm.org/viewvc/llvm-project?rev=344379&view=rev
Log:
[doc] fix markup in clang-tidy bugprone-not-null-terminated-result
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-not-null-terminated-res
Author: jonastoth
Date: Fri Oct 12 10:22:36 2018
New Revision: 344374
URL: http://llvm.org/viewvc/llvm-project?rev=344374&view=rev
Log:
[clang-tidy] New checker for not null-terminated result caused by strlen(),
size() or equal length
New checker called bugprone-not-null-terminated-result. This
Author: jonastoth
Date: Tue Oct 9 06:29:31 2018
New Revision: 344046
URL: http://llvm.org/viewvc/llvm-project?rev=344046&view=rev
Log:
[clang-tidy] NFC fix warnings from missing braces
The std::array create multiple StringRef but did not wrap
them in braces. Some compilers warned for that. Addin
Author: jonastoth
Date: Tue Oct 9 06:24:50 2018
New Revision: 344044
URL: http://llvm.org/viewvc/llvm-project?rev=344044&view=rev
Log:
[clangd] fix miscompiling lower_bound call
Modified:
clang-tools-extra/trunk/clangd/index/Index.cpp
Modified: clang-tools-extra/trunk/clangd/index/Index.cpp
m not alone seeing it.
> This is still giving the warning with clang 3.6.
>
> Thanks,
> Mikael
>
>> Regards,
>> Mikael
>>
>> On 10/05/2018 03:36 PM, Jonas Toth via cfe-commits wrote:
>>> Author: jonastoth
>>> Date: Fri Oct 5 06:36:00 2018
>
Author: jonastoth
Date: Fri Oct 5 07:15:19 2018
New Revision: 343850
URL: http://llvm.org/viewvc/llvm-project?rev=343850&view=rev
Log:
[clang-tidy] NFC refactor lexer-utils to be usable without ASTContext
Summary:
This patch is a small refactoring necessary for
'readability-isolate-declaration'
Author: jonastoth
Date: Fri Oct 5 06:36:00 2018
New Revision: 343848
URL: http://llvm.org/viewvc/llvm-project?rev=343848&view=rev
Log:
[clang-tidy] Replace deprecated std::ios_base aliases
This check warns the uses of the deprecated member types of std::ios_base
and replaces those that have a no
Author: jonastoth
Date: Thu Oct 4 09:39:41 2018
New Revision: 343797
URL: http://llvm.org/viewvc/llvm-project?rev=343797&view=rev
Log:
[clang-tidy] fix failing unit tests
The removal from the FIX-IT notes through the check-clang-tidy
script was done incorrect. I did not detect beforehand but adj
Author: jonastoth
Date: Thu Oct 4 09:29:58 2018
New Revision: 343796
URL: http://llvm.org/viewvc/llvm-project?rev=343796&view=rev
Log:
[clangd] fix another ambigous constructor in DexTest
Modified:
clang-tools-extra/trunk/unittests/clangd/DexTests.cpp
Modified: clang-tools-extra/trunk/unitt
Author: jonastoth
Date: Thu Oct 4 08:59:30 2018
New Revision: 343792
URL: http://llvm.org/viewvc/llvm-project?rev=343792&view=rev
Log:
[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
Reviewers: alexfh, aaron.ballman, hokein
Reviewed By: alexfh
Subscribers: xazax.hun, cf
Author: jonastoth
Date: Thu Oct 4 08:55:37 2018
New Revision: 343791
URL: http://llvm.org/viewvc/llvm-project?rev=343791&view=rev
Log:
[clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
Reviewers: alexfh, aaron.ballman, hokein
Reviewed By: alexfh
Subscribers: lebed
Author: jonastoth
Date: Thu Oct 4 08:49:25 2018
New Revision: 343789
URL: http://llvm.org/viewvc/llvm-project?rev=343789&view=rev
Log:
[clang-tidy] fix PR39167, bugprone-exception-escape hangs-up
Summary:
The check bugprone-exception-escape should not register
if -fno-exceptions is set for the c
Author: jonastoth
Date: Thu Oct 4 08:47:57 2018
New Revision: 343788
URL: http://llvm.org/viewvc/llvm-project?rev=343788&view=rev
Log:
[clang-tidy] Added pointer types to clang-tidy readability-identifier-naming
check.
Summary:
Option to check for different naming conventions on the following
1 - 100 of 162 matches
Mail list logo
