jpporto wrote:
Thanks for the pointers, truly appreciated.
I am not sure what was happening on my machine (my clangd was built with a
revision from a few weeks ago, so probably a broken version either). I am
closing the PR for now until I can repro the issue on my side (hopefully never).
Chee
https://github.com/jpporto closed
https://github.com/llvm/llvm-project/pull/169339
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpporto wrote:
> Nice! Can you please add a testcase?
I am unsure how to add a test for this -- the error is non-deterministic.
Moreover, the original commit didn't add a test, so it is hard to base off of
that. I am open to suggestions, though.
https://github.com/llvm/llvm-project/pull/16933
https://github.com/jpporto created
https://github.com/llvm/llvm-project/pull/169339
StringMap insertion may cause elements to be rehased, or the underlying storage
to be reallocated, so it is generatelly unsafe to take pointers to StringMap
"values". This in turn caused clangd to fail to load