[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn updated this revision to Diff 142579. jklaehn added a comment. Thanks for the review! As I do not have commit access, it would be great if you could commit the updated patch. https://reviews.llvm.org/D35181 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn added a comment. friendly ping? :) Repository: rC Clang https://reviews.llvm.org/D35181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn updated this revision to Diff 141033. jklaehn set the repository for this revision to rC Clang. jklaehn added a comment. ping? (rebased) Repository: rC Clang https://reviews.llvm.org/D35181 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp lib/Lex/Prepr

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn updated this revision to Diff 127685. jklaehn added a project: clang. jklaehn added a comment. ping (rebased) https://reviews.llvm.org/D35181 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp lib/Lex/Preprocessor.cpp unittests/libclang/LibclangTest.cpp

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn added a comment. Thanks! However, compared to diff 126298 (https://reviews.llvm.org/differential/diff/126298/), there seems to be duplication in the committed change (maybe some artifacts due to rebasing/merging?). Should I submit a follow-up patch to fix this? Comme

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn added a comment. In https://reviews.llvm.org/D36952#951616, @arphaman wrote: > LGTM Thanks! Can you submit this for me? (I do not have commit access yet.) https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn updated this revision to Diff 126298. jklaehn added a comment. ping (rebased) https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h test/Index/load-classes.cpp tools/c-index-test/c-index-test.

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn added a comment. In https://reviews.llvm.org/D35181#948925, @rsmith wrote: > LGTM, but I'd like the old `IdentifierTable` constructor to be removed if > there are no callers left. It's still being used in e.g. `FormatTokenLexer`, where the populated `IdentifierTable` is passed to the

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn added a comment. Ping, can you take another look? https://reviews.llvm.org/D35181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn updated this revision to Diff 123495. jklaehn added a reviewer: arphaman. jklaehn added a comment. Thanks for taking a look! I removed the constructor argument as suggested; keywords are now added in `PP.Initialize`. https://reviews.llvm.org/D35181 Files: include/clang/Basic/Identifi

[PATCH] D39543: [analyzer] Document the issue hash debugging facility

jklaehn added inline comments. Comment at: docs/analyzer/DebugChecks.rst:247 + + The analyzer can generate a hash to identify repots. To debug what information + is used to calculate this hash it is possible to dump the hashed string to typo `reports`? Repos

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

jklaehn added a comment. I spotted two typos. :) Also, the commit message needs to be updated. Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:61 + StringRef getDescription() const override { +return "The new qualified to chagne the symbol to"; + }

[PATCH] D39217: [libclang, bindings]: add spelling location

jklaehn added inline comments. Comment at: test/Index/c-index-getCursor-test.m:167 // CHECK: [57:1 - 57:10] FunctionDecl=f:57:6 (Definition) -// CHECK: [58:4 - 58:8] VarDecl=my_var:58:8 (Definition) +// CHECK: [58:4 - 58:8] VarDecl=my_var:2:1 (Definition) // CHECK: [58:8 - 58:1

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn added a comment. ping :) https://reviews.llvm.org/D35181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn added a comment. ping :) https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39217: [libclang, bindings]: add spelling location

jklaehn added inline comments. Comment at: test/Index/annotate-tokens.c:226 // CHECK-RANGE2: Punctuation: "." [55:5 - 55:6] UnexposedExpr= -// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:52:1 +// CHECK-RANGE2: Identifier: "z" [55:6 - 55:7] MemberRef=z:41:9 // CHECK-

[PATCH] D37905: [libclang, bindings]: add spelling location

jklaehn added inline comments. Comment at: bindings/python/clang/cindex.py:214 +class Location(object): +"""A Location is a specific kind of source location. A SourceLocation Can you also add `Location` to `__all__`? https://reviews.llvm.org/D37905 __

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn added a comment. In https://reviews.llvm.org/D36955#893856, @jbcoe wrote: > LGTM > > Would you like me to commit this for you? Yes, I would appreciate it. https://reviews.llvm.org/D36955 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn marked an inline comment as done. jklaehn added a comment. In https://reviews.llvm.org/D36973#893851, @jbcoe wrote: > LGTM > > Would you like me to commit this for you? Yes, that would be great! https://reviews.llvm.org/D36973 ___ cfe-com

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn updated this revision to Diff 118333. jklaehn added a comment. Use user-defined function for test of `AvailabilityKind.DEPRECATED`. https://reviews.llvm.org/D36973 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py Index: bindings/python/tests/cindex

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn updated this revision to Diff 118330. jklaehn added a comment. Added `c-index-test`-based test. https://reviews.llvm.org/D36955 Files: bindings/python/tests/cindex/test_cursor.py test/Index/annotate-attribute.cpp tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp ===

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn added a reviewer: jbcoe. jklaehn added a comment. ping :) https://reviews.llvm.org/D36955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn updated this revision to Diff 116456. jklaehn marked an inline comment as done. jklaehn added a comment. Added test for `AvailabilityKind.DEPRECATED`. `NOT_ACCESSIBLE` is never returned by `clang_getCursorAvailability` but only only used in `CodeCompletionResult`. https://reviews.llvm.

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jklaehn added a comment. In https://reviews.llvm.org/D36953#877367, @jbcoe wrote: > Do you need someone to commit this change for you? > > I'm happy to do so if you don't have commit access. Yes that would be great, thanks! https://reviews.llvm.org/D36953 __

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

jklaehn added inline comments. Comment at: docs/ReleaseNotes.rst:62 +<<< 2f301f50187ede4b9b8c7456ac4a67b9f7418004 - Renamed checks to use correct term "implicit conversion" instead of "implicit You missed a conflict marker here (and below in line 149). R

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn marked 2 inline comments as done. jklaehn added a comment. In https://reviews.llvm.org/D35271#850472, @vsk wrote: > Thanks, LGTM! This seems like a pretty straightforward bug fix. Since it's > not my usual area maybe it'd be worth waiting a day or so for more feedback. Thanks! I do not

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn updated this revision to Diff 112334. jklaehn added a comment. Update regression test to use `createTemporaryFile()` and `tool_output_file` as suggested. https://reviews.llvm.org/D35271 Files: lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp unittests/Frontend/CMakeLis

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn updated this revision to Diff 112139. jklaehn added a reviewer: akyrtzi. jklaehn added a comment. Herald added a subscriber: mgorny. Added regression test. https://reviews.llvm.org/D35271 Files: lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp unittests/Frontend/CMakeLi

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn created this revision. jklaehn added a project: clang. This patch allows checking the availability of cursors through libclang and clang.cindex (Python). This e.g. allows to check whether a C++ member function has been marked as deleted. https://reviews.llvm.org/D36973 Files: bindin

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn created this revision. jklaehn added a project: clang. Previously, `VisitAttributes` was not called for function and class templates and thus their attributes were not accessible using libclang. https://reviews.llvm.org/D36955 Files: bindings/python/tests/cindex/test_cursor.py tool

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jklaehn created this revision. jklaehn added a project: clang. Previously the `_tu` was not propagated to the returned cursor, leading to errors when calling any method on that cursor (e.g. `cursor.referenced`). https://reviews.llvm.org/D36953 Files: bindings/python/clang/cindex.py binding

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn created this revision. jklaehn added a project: clang. This patch allows checking whether a C++ record declaration is abstract through libclang and clang.cindex (Python). https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn added a comment. In https://reviews.llvm.org/D35271#809159, @vsk wrote: > I wonder if it's possible to do away with the calls to 'updated()'... it > seems strange that we initialize the same preprocessor repeatedly. Is there > any way to finalize an ASTInfoCollector after ReadAST happen

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn created this revision. jklaehn added a project: clang. In `ASTUnit::LoadFromASTFile`, the context object is set up using default-constructed `LangOptions` (which only later get populated). As the language options are used in the constructor of `PrintingPolicy`, this needs to be updated

[PATCH] D35187: [libclang] Support for querying whether an enum is scoped

jklaehn added a comment. I do not have commit access, it would be great if you could commit it. Thanks! https://reviews.llvm.org/D35187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D35187: [libclang] Support for querying whether an enum is scoped

jklaehn updated this revision to Diff 106066. jklaehn added a project: clang. https://reviews.llvm.org/D35187 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h test/Index/print-type-declaration.cpp tools/c-index-test/c-index-test.

[PATCH] D35187: [libclang] Support for querying whether an enum is scoped

jklaehn created this revision. This patch allows checking whether an enum declaration is scoped through libclang and clang.cindex (Python). https://reviews.llvm.org/D35187 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h test/Ind

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn created this revision. In `ASTUnit::LoadFromASTFile`, the preprocesor object is set up using default-constructed `LangOptions` (which only later get populated). Then, in the constructor of `IdentifierTable`, these default-constructed `LangOptions` were used in the call to `AddKeywords`, le