[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-11-27 Thread Joel E. Denny via cfe-commits
@@ -1311,4 +1314,96 @@ COMPILER_RT_VISIBILITY int __llvm_profile_set_file_object(FILE *File, return 0; } +int __llvm_write_custom_profile(const char *Target, +const __llvm_profile_data *DataBegin, +const __llvm

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-11-27 Thread Joel E. Denny via cfe-commits
@@ -1,12 +1,17 @@ -// RUN: %libomptarget-compile-generic -fprofile-instr-generate \ -// RUN: -Xclang "-fprofile-instrument=clang" -// RUN: %libomptarget-run-generic 2>&1 | %fcheck-generic \ -// RUN: --check-prefix="CLANG-PGO" // RUN: %libomptarget-compile-generic -fprofil

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Add GPU profiling flags to driver (PR #94268)

2024-11-27 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > > For some codes, I get the following error for a gfx906: > > ``` > > LLVM ERROR: Relocation for CG Profile could not be created: unknown > > relocation name > > ``` > Not sure if this is still relevant, but I think #114617 should fix this > issue. The ASM builder was try

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Add GPU profiling flags to driver (PR #94268)

2024-10-03 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: For some codes, I get the following error for a gfx906: ``` LLVM ERROR: Relocation for CG Profile could not be created: unknown relocation name ``` I see it for OpenMC, but the following is a simpler example: ``` $ cat test.c #include #include __attribute__((noinline)) d

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-10-03 Thread Joel E. Denny via cfe-commits
@@ -1311,4 +1314,96 @@ COMPILER_RT_VISIBILITY int __llvm_profile_set_file_object(FILE *File, return 0; } +int __llvm_write_custom_profile(const char *Target, +const __llvm_profile_data *DataBegin, +const __llvm

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Add GPU profiling flags to driver (PR #94268)

2024-10-02 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,82 @@ +// RUN: %libomptarget-compile-generic -fprofile-generate-gpu jdenny-ornl wrote: When targeting a V100, this command fails for me in both pgo1.c and pgo2.c. In the LTO case: ``` LLVM ERROR: Circular dependency found in global variable set ```

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-10-02 Thread Joel E. Denny via cfe-commits
@@ -1,12 +1,17 @@ -// RUN: %libomptarget-compile-generic -fprofile-instr-generate \ -// RUN: -Xclang "-fprofile-instrument=clang" -// RUN: %libomptarget-run-generic 2>&1 | %fcheck-generic \ -// RUN: --check-prefix="CLANG-PGO" // RUN: %libomptarget-compile-generic -fprofil

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-09-04 Thread Joel E. Denny via cfe-commits
@@ -116,6 +116,16 @@ ToolChain::executeToolChainProgram(StringRef Executable, }; std::string ErrorMessage; + int SecondsToWait = 60; + if (std::optional Str = + llvm::sys::Process::GetEnv("CLANG_TOOLCHAIN_PROGRAM_TIMEOUT")) { +if (!llvm::to_integer(*Str, Sec

[clang] 7c4eb60 - [Clang] Fix CLANG_TOOLCHAIN_PROGRAM_TIMEOUT logic

2024-09-04 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2024-09-04T18:43:54-04:00 New Revision: 7c4eb60c9509c3a750961eac2dbcaad369d911f2 URL: https://github.com/llvm/llvm-project/commit/7c4eb60c9509c3a750961eac2dbcaad369d911f2 DIFF: https://github.com/llvm/llvm-project/commit/7c4eb60c9509c3a750961eac2dbcaad369d911f2.diff

[clang] [llvm] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > > > Updated to pass `-O2` instead, this was the actual behavior that passed, > > > so it's mostly not a functional change. > > > > > > So you just changed the tests not to use -O1? Doesn't this patch then > > represent a regression in what's supported? > > I wouldn't con

[clang] [llvm] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
@@ -21,7 +21,6 @@ // RUN: env LIBOMPTARGET_JIT_PRE_OPT_IR_MODULE=%t.pre.ll \ // RUN: LIBOMPTARGET_JIT_SKIP_OPT=true \ // RUN: %libomptarget-run-generic -// TODO: jdenny-ornl wrote: Unrelated changed? https://github.com/llvm/llvm-

[clang] [llvm] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Updated to pass `-O2` instead, this was the actual behavior that passed, so > it's mostly not a functional change. So you just changed the tests not to use -O1? Doesn't this patch then represent a regression in what's supported? (Rewriting history with force pushes make

[clang] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I guess I should just manually pass the optimization level at `O2` for now. Would -O3 still pass through? https://github.com/llvm/llvm-project/pull/102972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [LinkerWrapper] Always pass `-flto` if the linker supports it (PR #102972)

2024-08-13 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Seems like it does what it intends to do. Thanks for working on it. However, there's a side effect. Now that -O1 gets passed along, sometimes it triggers an assert fail for AMD GPU: ``` ld.lld: /tmp/llvm/llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:151: virtual

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl closed https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/7] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-09 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Possibly worth increasing it to a minute then, Should we also land the env var? If so, I'll just extend this patch. Either way, any objection to moving `[Default]SecondsToWait` into executeToolChainProgram so we're maintaining it in just one place? > this is basically j

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-09 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/102483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-09 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl closed https://github.com/llvm/llvm-project/pull/102483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: FWIW, on one of my test systems that's currently very busy, check-offload consistently fails with amdgpu-arch timeouts. However, the following so far makes it consistently succeed: ``` $ CLANG_TOOLCHAIN_PROGRAM_TIMEOUT=60 ninja check-offload ``` Previously, I've decreased

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/5] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
@@ -116,6 +117,15 @@ ToolChain::executeToolChainProgram(StringRef Executable, }; std::string ErrorMessage; + int SecondsToWait = DefaultSecondsToWait; + if (std::optional Str = + llvm::sys::Process::GetEnv("CLANG_TOOL_CHAIN_PROGRAM_WAIT")) { +int Val = std::

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
@@ -99,7 +99,8 @@ def warn_drv_amdgpu_cov6: Warning< " use at your own risk">; def err_drv_undetermined_gpu_arch : Error< "cannot determine %0 architecture: %1; consider passing it via " - "'%2'">; + "'%2' or increasing the tool timeout using the environment variable " +

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/4] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Also, just be aware that if you set this, it will apply to everything. So if > you had a particularly long link job, probably would be a good idea to make > it wait forever. Not sure I understand. grep found 2 uses of executeToolChainProgram: calling amdgpu-arch and nvpt

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/3] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
@@ -116,6 +117,15 @@ ToolChain::executeToolChainProgram(StringRef Executable, }; std::string ErrorMessage; + int SecondsToWait = DefaultSecondsToWait; + if (std::optional Str = + llvm::sys::Process::GetEnv("CLANG_TOOL_CHAIN_PROGRAM_WAIT")) { +int Val = std::

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/2] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Maybe we should bump the default time up? I don't know what's reasonable in > this area, but the GPU drivers have a bad habit of deadlocking, so this is to > prevent that. I don't know the right value either. If no one else is complaining, maybe 10s is fine under normal

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl created https://github.com/llvm/llvm-project/pull/102521 When working on very busy systems, check-offload frequently fails many tests with this diagnostic: ``` clang: error: cannot determine amdgcn architecture: /tmp/llvm/build/bin/amdgpu-arch: Child timed out:

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102483 >From 9e8a8e78f3014324d8aa35dd1615b3f5720a5cb4 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Wed, 7 Aug 2024 19:10:33 -0400 Subject: [PATCH 1/3] [Clang] Simplify specifying passes via -Xoffload-linker

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joel E. Denny via cfe-commits
@@ -527,9 +527,11 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { // Forward all of the `--offload-opt` and similar options to the device. if (linkerSupportsLTO(Args)) { -for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) +for (auto

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102483 >From 9e8a8e78f3014324d8aa35dd1615b3f5720a5cb4 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Wed, 7 Aug 2024 19:10:33 -0400 Subject: [PATCH 1/2] [Clang] Simplify specifying passes via -Xoffload-linker

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl created https://github.com/llvm/llvm-project/pull/102483 Make it possible to do things like the following, regardless of whether `$GPU_ARCH` is for nvptx or amdgpu: ``` $ clang -O1 -g -fopenmp -fopenmp-targets=$GPU_ARCH test.c \ -Xoffload-lin

[clang] Revert "[LinkerWrapper] Extend with usual pass options (#96704)" (PR #102226)

2024-08-06 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl approved this pull request. https://github.com/llvm/llvm-project/pull/102226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl approved this pull request. https://github.com/llvm/llvm-project/pull/101032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Joel E. Denny via cfe-commits
@@ -32,6 +32,9 @@ def builtin_bitcode_EQ : Joined<["--"], "builtin-bitcode=">, def device_linker_args_EQ : Joined<["--"], "device-linker=">, Flags<[WrapperOnlyOption]>, MetaVarName<" or =">, HelpText<"Arguments to pass to the device linker invocation">; +def device_compiler

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think this looks good overall, Thanks for the fast reviews. > though I'd like to hear some other clang maintainers chime in on the LIT > config changes. For reference, I mostly copied that from the llvm test suite config. https://github.com/llvm/llvm-project/pull/96704

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/96704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,77 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. jdenny-ornl wrote: noinline prevents the inline pass in the test from running. https://github.com/llvm/llvm-project/pull/96704 ___

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/96704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,77 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. jdenny-ornl wrote: OK, I did that. I used opt to discard the inline attribute that clang introduces. If you know of a better way that doesn't perform inlining before the c

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/96704 >From 98e04dd372b82c2c5309a6148bb49eb1012a97ee Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Tue, 25 Jun 2024 17:29:49 -0400 Subject: [PATCH 1/4] [LinkerWrapper] Extend with usual pass options The goa

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,77 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. jdenny-ornl wrote: Yeah, I suppose that's just as good. I do wonder if this is really the right directory for these tests at all. Its lit.local.cfg has a %clang_cc1 substi

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,86 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. + +; REQUIRES: llvm-plugins, llvm-examples +; REQUIRES: x86-registered-target +; REQUIRES: amdgpu-registered-target + +; Setup. +; RUN: split-file %s %t +; RUN: opt -o %t/host-x86_64-unknown-li

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/96704 >From 98e04dd372b82c2c5309a6148bb49eb1012a97ee Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Tue, 25 Jun 2024 17:29:49 -0400 Subject: [PATCH 1/3] [LinkerWrapper] Extend with usual pass options The goa

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Makes sense overall. However in the future I'm looking to move away from the > home-baked LTO pipeline in favor of giving it to the linker. That allows me > to set up libraries as a part of the target toolchain in the driver. I guess > for that I'll just need to forward `-

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,86 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. + +; REQUIRES: llvm-plugins, llvm-examples +; REQUIRES: x86-registered-target +; REQUIRES: amdgpu-registered-target + +; Setup. +; RUN: split-file %s %t +; RUN: opt -o %t/host-x86_64-unknown-li

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/96704 >From 98e04dd372b82c2c5309a6148bb49eb1012a97ee Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Tue, 25 Jun 2024 17:29:49 -0400 Subject: [PATCH 1/2] [LinkerWrapper] Extend with usual pass options The goa

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,86 @@ +; Check various clang-linker-wrapper pass options after -offload-opt. + +; REQUIRES: llvm-plugins, llvm-examples +; REQUIRES: x86-registered-target +; REQUIRES: amdgpu-registered-target + +; Setup. +; RUN: split-file %s %t +; RUN: opt -o %t/host-x86_64-unknown-li

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
@@ -0,0 +1,10 @@ +// Check that these simple command lines for listing LLVM options are supported, jdenny-ornl wrote: Grepping for -help in llvm's test suite finds various such tests. The point here is to make sure `--offload-opt=--help can list these opt-like

[clang] [LinkerWrapper] Extend with usual pass options (PR #96704)

2024-06-25 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl created https://github.com/llvm/llvm-project/pull/96704 The goal of this patch is to enable utilizing LLVM plugin passes and remarks for GPU offload code at link time. Specifically, this patch extends clang-linker-wrapper's `--offload-opt` (and consequently `-ml

[clang] [Clang][OpenMP] Fix stdio.h wrapper when glibc includes again (PR #77017)

2024-01-05 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl closed https://github.com/llvm/llvm-project/pull/77017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Fix stdio.h wrapper when glibc includes again (PR #77017)

2024-01-04 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > TYVM for fixing this. There's a lot of hacky stuff we need to do here to make > it work, but it is what it is. > > Guessing the other wrapped files are fine? I remember having problems with > `cytype` and `string` but I hopefully resolved a lot of those already. I do have

[clang] [Clang][OpenMP] Fix stdio.h wrapper when glibc includes again (PR #77017)

2024-01-04 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl created https://github.com/llvm/llvm-project/pull/77017 Since D154036 landed (2a65d0388ca0 on July 7, 2023), I've been seeing many (40-50) libomptarget test failures with errors like the following on some of our test systems: ``` /auto/software/gcc/x86_64/gcc-11

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to > use on Windows. (When I install Visual Studio, it creates a widget that > brings up a `cmd` shell with the right environment. I'm not aware of a > similar widget for PowerShell.) While I rarely

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think that might be a bit too accelerated. I work mostly with a fork of > LLVM (https://github.com/apple/llvm-project) and do care about the usability > of `cmd` as a shell (however, it is significantly behind but is working on > updating to a more recent version). I thi

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think that might be a bit too accelerated. I work mostly with a fork of > LLVM (https://github.com/apple/llvm-project) and do care about the usability > of `cmd` as a shell (however, it is significantly behind but is working on > updating to a more recent version). I thi

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-05 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Thanks for everyone's comments so far. This PR is not ready to land. As discussed, it doesn't fully fix support for windows `cmd` as a lit external shell. Given how long that use case has been broken (apparently since April, 2022), it seems that's a use case no one cares

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-05 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/65242: >From 26d5891879583b9addd2a6d4d7caf4241ba55b85 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 31 Aug 2023 20:24:51 -0400 Subject: [PATCH 1/2] [lit] Are all RUN lines skipped in windows cmd? Key i

[clang] 19841e4 - [OpenMP] Fix transformed loop's var privacy

2023-06-02 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2023-06-02T12:18:13-04:00 New Revision: 19841e4dcaabe573d35eb88a130fc34d32ecd708 URL: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708 DIFF: https://github.com/llvm/llvm-project/commit/19841e4dcaabe573d35eb88a130fc34d32ecd708.diff

[clang] 28412d1 - [lit] Implement DEFINE and REDEFINE directives

2022-09-21 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2022-09-21T11:32:05-04:00 New Revision: 28412d1800e391c5ba8e7607bb15c74b106d581b URL: https://github.com/llvm/llvm-project/commit/28412d1800e391c5ba8e7607bb15c74b106d581b DIFF: https://github.com/llvm/llvm-project/commit/28412d1800e391c5ba8e7607bb15c74b106d581b.diff

[clang] 0103d4d - [Clang][OpenMP] Don't overload "extension" in status doc

2022-06-27 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2022-06-27T18:41:17-04:00 New Revision: 0103d4da740c9d2688389e2aa5e3c2f3792e6940 URL: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940 DIFF: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940.diff

[clang] d2e3cb7 - [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

2022-05-30 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2022-05-30T11:02:20-04:00 New Revision: d2e3cb737417a2e5ffad34f666fa8510e88e8bc2 URL: https://github.com/llvm/llvm-project/commit/d2e3cb737417a2e5ffad34f666fa8510e88e8bc2 DIFF: https://github.com/llvm/llvm-project/commit/d2e3cb737417a2e5ffad34f666fa8510e88e8bc2.diff

[clang] 4a36813 - [OpenACC][OpenMP] Document atomic-in-teams extension

2022-05-27 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2022-05-27T18:53:19-04:00 New Revision: 4a368136693ba9c4e827702e9d390280c3d5e7ac URL: https://github.com/llvm/llvm-project/commit/4a368136693ba9c4e827702e9d390280c3d5e7ac DIFF: https://github.com/llvm/llvm-project/commit/4a368136693ba9c4e827702e9d390280c3d5e7ac.diff

[clang] 48ca3a5 - [OpenMP] Extend omp teams to permit nested omp atomic

2022-05-26 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2022-05-26T14:59:16-04:00 New Revision: 48ca3a5ebb156ccb776eea399138b7cda4d13395 URL: https://github.com/llvm/llvm-project/commit/48ca3a5ebb156ccb776eea399138b7cda4d13395 DIFF: https://github.com/llvm/llvm-project/commit/48ca3a5ebb156ccb776eea399138b7cda4d13395.diff

[clang] 5b0a948 - [UpdateCCTestChecks] Implement --global-hex-value-regex

2021-07-20 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-07-20T11:23:20-04:00 New Revision: 5b0a948a81e695f044e88659be18a28256b1e309 URL: https://github.com/llvm/llvm-project/commit/5b0a948a81e695f044e88659be18a28256b1e309 DIFF: https://github.com/llvm/llvm-project/commit/5b0a948a81e695f044e88659be18a28256b1e309.diff

[clang] 2f5b2ea - [UpdateCCTestChecks] Implement --global-value-regex

2021-07-20 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-07-20T11:23:20-04:00 New Revision: 2f5b2ea6cd854edfa2722ae0b5acf604a333e785 URL: https://github.com/llvm/llvm-project/commit/2f5b2ea6cd854edfa2722ae0b5acf604a333e785 DIFF: https://github.com/llvm/llvm-project/commit/2f5b2ea6cd854edfa2722ae0b5acf604a333e785.diff

[clang] cc60fa2 - [UpdateCCTestChecks] Fix new test from 9eaf0d120d32

2021-06-25 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-06-25T14:29:58-04:00 New Revision: cc60fa2685bdbff889df826a1bfd5e52ffd163c8 URL: https://github.com/llvm/llvm-project/commit/cc60fa2685bdbff889df826a1bfd5e52ffd163c8 DIFF: https://github.com/llvm/llvm-project/commit/cc60fa2685bdbff889df826a1bfd5e52ffd163c8.diff

[clang] 9eaf0d1 - [UpdateCCTestChecks] Support --check-globals

2021-06-25 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-06-25T13:17:56-04:00 New Revision: 9eaf0d120d3255c43789213c499513ba1be9dde7 URL: https://github.com/llvm/llvm-project/commit/9eaf0d120d3255c43789213c499513ba1be9dde7 DIFF: https://github.com/llvm/llvm-project/commit/9eaf0d120d3255c43789213c499513ba1be9dde7.diff

[clang] 2bfe053 - [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines

2021-06-21 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-06-21T17:01:17-04:00 New Revision: 2bfe0536e5143caad80f7a9691fa775cf451317b URL: https://github.com/llvm/llvm-project/commit/2bfe0536e5143caad80f7a9691fa775cf451317b DIFF: https://github.com/llvm/llvm-project/commit/2bfe0536e5143caad80f7a9691fa775cf451317b.diff

[clang] 82e99f5 - [OpenMP] Fix second debug name from map clause

2021-04-30 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2021-04-30T16:26:59-04:00 New Revision: 82e99f50351dd83d854f45bab3d91d4e6ad6450e URL: https://github.com/llvm/llvm-project/commit/82e99f50351dd83d854f45bab3d91d4e6ad6450e DIFF: https://github.com/llvm/llvm-project/commit/82e99f50351dd83d854f45bab3d91d4e6ad6450e.diff

[clang] 26cf9c1 - [OpenMP][Docs] Add map clause reordering status as unclaimed

2020-08-05 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 26cf9c17044515cdde3e7baeea843001ba33be59 URL: https://github.com/llvm/llvm-project/commit/26cf9c17044515cdde3e7baeea843001ba33be59 DIFF: https://github.com/llvm/llvm-project/commit/26cf9c17044515cdde3e7baeea843001ba33be59.diff

[clang] 002d61d - [OpenMP] Fix `present` for exit from `omp target data`

2020-08-05 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 002d61db2b7790dc884953bf9271878bf0af3a8e URL: https://github.com/llvm/llvm-project/commit/002d61db2b7790dc884953bf9271878bf0af3a8e DIFF: https://github.com/llvm/llvm-project/commit/002d61db2b7790dc884953bf9271878bf0af3a8e.diff

[clang] 03bb545 - [OpenMP][Docs] Mark `present` map type modifier as done

2020-08-05 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 03bb545b68c2edb9dc5bd092104bdb83a8e5e347 URL: https://github.com/llvm/llvm-project/commit/03bb545b68c2edb9dc5bd092104bdb83a8e5e347 DIFF: https://github.com/llvm/llvm-project/commit/03bb545b68c2edb9dc5bd092104bdb83a8e5e347.diff

[clang] 3d06fc0 - [OpenMP][Docs] Mark `present` motion modifier as done

2020-07-30 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-30T12:21:37-04:00 New Revision: 3d06fc0049c6bb94e6efd77388453206037f43ad URL: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad DIFF: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad.diff

[clang] 9f2f3b9 - [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

2020-07-29 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-29T12:18:45-04:00 New Revision: 9f2f3b9de6314a009322b6081c792ebf9a469460 URL: https://github.com/llvm/llvm-project/commit/9f2f3b9de6314a009322b6081c792ebf9a469460 DIFF: https://github.com/llvm/llvm-project/commit/9f2f3b9de6314a009322b6081c792ebf9a469460.diff

[clang] 69fc33f - Revert "[OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)"

2020-07-28 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-28T20:30:05-04:00 New Revision: 69fc33f0cd130b02a38d2fc582afc7b0fcd6458a URL: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a DIFF: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a.diff

[clang] 3c3faae - [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

2020-07-28 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-28T19:15:18-04:00 New Revision: 3c3faae497046be706df29e16c9fbccb7e1fce09 URL: https://github.com/llvm/llvm-project/commit/3c3faae497046be706df29e16c9fbccb7e1fce09 DIFF: https://github.com/llvm/llvm-project/commit/3c3faae497046be706df29e16c9fbccb7e1fce09.diff

[clang] a3d1f88 - [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

2020-07-28 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-28T19:15:18-04:00 New Revision: a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819 URL: https://github.com/llvm/llvm-project/commit/a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819 DIFF: https://github.com/llvm/llvm-project/commit/a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819.diff

[clang] f250eb3 - [OpenMP][Docs] Update `present` modifier status

2020-07-27 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-27T19:23:55-04:00 New Revision: f250eb37cd4fabcc9f222ca2da80b62d110d9fff URL: https://github.com/llvm/llvm-project/commit/f250eb37cd4fabcc9f222ca2da80b62d110d9fff DIFF: https://github.com/llvm/llvm-project/commit/f250eb37cd4fabcc9f222ca2da80b62d110d9fff.diff

[clang] d6e79e3 - [OpenMP][Docs] Update `present` map type modifier status

2020-07-15 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-15T11:17:00-04:00 New Revision: d6e79e3dd6df63425eb098f482be2c9744ad48eb URL: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb DIFF: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb.diff

[clang] ed39bec - [OpenMP][NFC] Remove hard-coded line numbers from more tests

2020-07-07 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-07T09:48:22-04:00 New Revision: ed39becd274dae5537c24b2107737d718527e718 URL: https://github.com/llvm/llvm-project/commit/ed39becd274dae5537c24b2107737d718527e718 DIFF: https://github.com/llvm/llvm-project/commit/ed39becd274dae5537c24b2107737d718527e718.diff

[clang] 01ddb2a - [OpenMP][NFC] Remove hard-coded line numbers from test

2020-06-24 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-06-24T14:35:01-04:00 New Revision: 01ddb2a7b044f697a15043e47acdb93e2825809a URL: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a DIFF: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a.diff

[clang] 3fa666b - [OpenMP][Docs] Mark TR8 `present` as claimed in docs

2020-06-24 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-06-24T14:21:11-04:00 New Revision: 3fa666b883625a678cfcfd9ad96b2daabcef09e8 URL: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8 DIFF: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8.diff

[clang] a1fd188 - [FileCheck] Support comment directives

2020-05-13 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-05-13T11:29:48-04:00 New Revision: a1fd188223d9c9b404dccd3511fe8b63ef022a13 URL: https://github.com/llvm/llvm-project/commit/a1fd188223d9c9b404dccd3511fe8b63ef022a13 DIFF: https://github.com/llvm/llvm-project/commit/a1fd188223d9c9b404dccd3511fe8b63ef022a13.diff

[clang] d0e7fd6 - Revert "[FileCheck] Support comment directives"

2020-05-11 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-05-11T19:41:22-04:00 New Revision: d0e7fd6b624b1943f3780a69883690017d2efad2 URL: https://github.com/llvm/llvm-project/commit/d0e7fd6b624b1943f3780a69883690017d2efad2 DIFF: https://github.com/llvm/llvm-project/commit/d0e7fd6b624b1943f3780a69883690017d2efad2.diff

[clang] 9a9a5f9 - [FileCheck] Support comment directives

2020-05-11 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-05-11T14:53:48-04:00 New Revision: 9a9a5f9893c8db05cebc8818eb8485bff61f7c74 URL: https://github.com/llvm/llvm-project/commit/9a9a5f9893c8db05cebc8818eb8485bff61f7c74 DIFF: https://github.com/llvm/llvm-project/commit/9a9a5f9893c8db05cebc8818eb8485bff61f7c74.diff

[clang] c85fa79 - [Attr] Fix `-ast-print` for `asm` attribute

2019-11-18 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2019-11-18T11:55:25-05:00 New Revision: c85fa79d3663ecb3117e178b2a79ffa721d18e32 URL: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32 DIFF: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32.diff

[clang-tools-extra] r375058 - [lit] Fix another test case that r374652 missed

2019-10-16 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Wed Oct 16 16:58:58 2019 New Revision: 375058 URL: http://llvm.org/viewvc/llvm-project?rev=375058&view=rev Log: [lit] Fix another test case that r374652 missed Modified: clang-tools-extra/trunk/test/clang-include-fixer/merge.test Modified: clang-tools-extra/trunk/test/cl

r369619 - [OpenMP] Permit map with DSA on combined directive

2019-08-21 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Wed Aug 21 20:34:30 2019 New Revision: 369619 URL: http://llvm.org/viewvc/llvm-project?rev=369619&view=rev Log: [OpenMP] Permit map with DSA on combined directive For `map`, the following restriction changed in OpenMP 5.0: * OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item

r369049 - [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

2019-08-15 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Thu Aug 15 14:17:48 2019 New Revision: 369049 URL: http://llvm.org/viewvc/llvm-project?rev=369049&view=rev Log: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug I'd like to add these comments to warn others of problems I encountered when trying to use `RemoveLine

r365264 - [Rewrite] Try to fix buildbot link fail left by r365263

2019-07-06 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Sat Jul 6 09:28:32 2019 New Revision: 365264 URL: http://llvm.org/viewvc/llvm-project?rev=365264&view=rev Log: [Rewrite] Try to fix buildbot link fail left by r365263 http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/10272 Modified: cfe/trunk/unitt

r365263 - [Rewrite] Try to fix buildbot link fail caused by r365258

2019-07-06 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Sat Jul 6 06:44:57 2019 New Revision: 365263 URL: http://llvm.org/viewvc/llvm-project?rev=365263&view=rev Log: [Rewrite] Try to fix buildbot link fail caused by r365258 http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/10270 Modified: cfe/trunk/uni

r365258 - [Rewrite] Extend to further accept CharSourceRange

2019-07-05 Thread Joel E. Denny via cfe-commits
Author: jdenny Date: Fri Jul 5 19:55:06 2019 New Revision: 365258 URL: http://llvm.org/viewvc/llvm-project?rev=365258&view=rev Log: [Rewrite] Extend to further accept CharSourceRange Some Rewrite functions are already overloaded to accept CharSourceRange, and this extends others in the same mann

  1   2   >