[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e076a8d8099: Make sure Objective-C category support in IncludeSorter handles top-level… (authored by compositeprimes). Repository: rG LLVM Github

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300402. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes added a comment. In D89608#2336596 , @gribozavr2 wrote: > Any chance of adding a test? Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 __

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes created this revision. compositeprimes added reviewers: alexfh, gribozavr. compositeprimes added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. compositeprimes requested review of this revision. Currently, this would not correct

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes added a comment. clang-format is complaining about my ordering of headers in my test case in IncludeInserterTest (but that's correct objc formatting). Not sure if there's a way to disable that on those lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298264. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298241. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298203. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298029. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index: clang-tools-extra/unittes

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298026. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: ___

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 297980. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/unittests/clang-tidy/IncludeInserterTest.cpp Index: clang-tools-extra/unittes

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 297728. compositeprimes edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSo

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes created this revision. compositeprimes added a reviewer: alexfh. compositeprimes added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. compositeprimes requested review of this revision. Update IncludeSorter/IncludeInserter to sup

[PATCH] D68887: [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes updated this revision to Diff 245915. compositeprimes edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68887/new/ https://reviews.llvm.org/D68887 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tidy/ClangTidyDiagnosticC

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added a comment. I don't have commit rights (this is my first llvm commit!), so could someone help out? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 ___ cfe-commits mailin

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:51 +/// Represents a single source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRange { + DiagnosticAssociatedRange() = default; alexfh wrote: >

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 245717. compositeprimes marked an inline comment as done. compositeprimes added a comment. Added tests for Yaml serialization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 Files: include/clang/To

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added a comment. Sorry about the lack of context on the last upload, this one should have it all Comment at: include/clang/Tooling/Core/Diagnostic.h:62-70 +/// Represents extra source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRanges

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 245207. compositeprimes marked 2 inline comments as done. compositeprimes added a comment. Removed unnecessary DiagnosticAssociatedRanges struct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 Files:

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 244737. compositeprimes added a comment. Updated to serialize the ranges in yaml. This required making a few abstractions around the representation of CharSourceRange. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews

[PATCH] D68885: Add a Ranges field to Diagnostic struct

compositeprimes marked 3 inline comments as done. compositeprimes added a comment. Sorry for the delay; I got caught up in some other work. I moved this to https://reviews.llvm.org/D69782 using arc diff. @gribozavr: I'm not sure how to merge this with the other commit, because it's in clang-tid

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes created this revision. compositeprimes added reviewers: gribozavr, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D69782 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Diagno

[PATCH] D68887: Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes created this revision. compositeprimes added a reviewer: clang-tools-extra. compositeprimes added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. Part 2 of the change: The goal is instead of dropping all the ranges associa

[PATCH] D68885: Add a Ranges field to Diagnostic struct

compositeprimes created this revision. compositeprimes added reviewers: clang, clang-tools-extra. compositeprimes added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Part 1 of the change: The goal is instead of dropping all the ranges associated with a Diagnostic whe

[PATCH] D55545: Allow IncludeSorter to use #import for Objective-C files

compositeprimes created this revision. compositeprimes added reviewers: klimek, alexfh. Herald added a subscriber: cfe-commits. The change infers whether a source file is Objective-C using LangOpts, and if it detects Objective-C, it uses "#import" instead of "#include" for all inserted imports.