[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. In D138870#4020211 , @arsenm wrote: > In D138870#4020204 , @Joe_Nash > wrote: > >> The code looks fine,

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe_Nash added a comment. The code looks fine, but as you say, the change visible in user code and could break something. Do you want to handle that somehow? Maybe wait for @b-sumner Comment at: clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp:17 #pragma omp meta

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash accepted this revision. Joe_Nash added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + What part o

[PATCH] D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138216/new/ https://reviews.llvm.org/D138216 ___

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d43de13df03: [AMDGPU] gfx11 new dot instruction codegen support (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1926 +// f16 %r = llvm.amdgcn.fdot2.f16.f16(v2f16 %a, v2f16 %b, f16 %c, i1 %clamp) +// %r = %a[0] * %b[0] + %a[1] * %b[1] + %c rampitec wrote: > I do not see clamp in the def

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash updated this revision to Diff 437552. Joe_Nash marked 3 inline comments as done. Joe_Nash added a comment. added builtin positive tests, removed clamp from intrinsic comments, combined gisel with normal codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash created this revision. Joe_Nash added reviewers: foad, rampitec. Herald added subscribers: kosarev, jsilvanus, hsmhsm, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. Joe_Nash requested review of this revision. Herald ad

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bdfc73f633d: [AMDGPU][clang] Definition of gfx11 subtarget (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG813e521e55b1: [AMDGPU] Add gfx11 subtarget ELF definition (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

Joe_Nash updated this revision to Diff 425802. Joe_Nash added a comment. add requested docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124536/new/ https://reviews.llvm.org/D124536 Files: clang/test/Misc/target-invalid-cpu-note.c llvm/docs/A

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

Joe_Nash created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, dexonsmith, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, jholewinski. Herald added a project: All. Joe_Nash requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

Joe_Nash created this revision. Herald added subscribers: hsmhsm, foad, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, emaste, arsenm. Herald added a reviewer: jhenderson. Herald added a project: All. Joe_Nash requested review of this revisi