[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam closed this revision. jspam added a comment. No idea, I'll just close this then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 ___ cfe-commits mailing

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam added a comment. I see :) Yes, looks like Git's rename detection did its job. Thanks for the review. Could you or someone else please merge this for me? Author: Joachim Priesner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ htt

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam added a comment. @LegalizeAdulthood Not sure what exactly you mean by "fold your changes into `checkers/cppcoreguidelines/virtual-class-destructor.cpp`". The only rebase conflict was in `VirtualClassDestructorCheck.cpp`. Please let me know if there is still something to do. Repository:

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam updated this revision to Diff 439300. jspam added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorChe

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam added a comment. Thanks. Please use Joachim Priesner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam added a comment. Would someone be able to commit this for me, as I do not have the necessary rights? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 _

[PATCH] D128157: cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, nemanjai. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Check llvm::Optional before dereferencing it.

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

jspam updated this revision to Diff 438265. jspam added a comment. Improve fixes As suggested by njames93, use call syntax instead of operator(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125949/new/ https://reviews.llvm.org/D125949 Files:

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

jspam created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The following assertion fails when referencing an operator membe

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam updated this revision to Diff 430586. jspam added a comment. Update test as suggested by njames93. bugprone-argument-comment-literals.cpp also contains some instances of a UDL used as an argument which didn't lead to problems before because the argument didn't have a name. So that case is

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam updated this revision to Diff 430375. jspam added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-

[PATCH] D125885: bugprone-argument-comment: Ignore calls to user-defined literals

jspam created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Without this change, code such as "f(/*param=*/1_op)" will check the comme

[PATCH] D86209: [clang-tidy] run-clang-tidy.py: Fix -allow-enabling-analyzer-alpha-checkers always being passed

jspam added a comment. Yes please. I am fine with the license agreement, and please use Joachim Priesner as the commit author. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86209/new/ https://reviews.llvm.org/D86209 _

[PATCH] D86209: [clang-tidy] run-clang-tidy.py: Fix -allow-enabling-analyzer-alpha-checkers always being passed

jspam created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. jspam requested review of this revision. The `action='store_true'` option of `argparse.add_argument`