[clang] de27291 - Add missing header guards so the modules build will succeed.

2023-04-19 Thread Jim Ingham via cfe-commits
Author: Jim Ingham Date: 2023-04-19T17:24:11-07:00 New Revision: de27291e25f7398b0b36c0f388eaf272b2b54e37 URL: https://github.com/llvm/llvm-project/commit/de27291e25f7398b0b36c0f388eaf272b2b54e37 DIFF: https://github.com/llvm/llvm-project/commit/de27291e25f7398b0b36c0f388eaf272b2b54e37.diff LO

Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Jim Ingham via cfe-commits
A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she. Plea

Re: [PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

2018-10-23 Thread Jim Ingham via cfe-commits
> On Oct 23, 2018, at 11:09 AM, Erik Pilkington via Phabricator > wrote: > > erik.pilkington added a subscriber: jingham. > erik.pilkington added inline comments. > > > > Comment at: clang/lib/Basic/IdentifierTable.cpp:166-167 > // in non-arc mode. > - if (LangOpts.ObjC2