[PATCH] D52259: [CUDA] Fix two failed test cases using --cuda-path-ignore-env

gaijiading updated this revision to Diff 166811. gaijiading retitled this revision from "[CUDA] Rearrange search path ordering to fix two test case failures" to "[CUDA] Fix two failed test cases using --cuda-path-ignore-env". gaijiading edited the summary of this revision. gaijiading added a comm

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

gaijiading updated this revision to Diff 166206. gaijiading added a comment. Apologies for having uploaded the wrong patch in my original review request. Please help review this version instead. Thanks. Repository: rC Clang https://reviews.llvm.org/D52259 Files: lib/Driver/ToolChains/Cuda

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

gaijiading created this revision. gaijiading added reviewers: jlebar, Hahnfeld, dlj, tra. gaijiading added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, when a system has the CUDA toolkit already installed to its default locations in /usr/local/cuda, there will be t

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. Hi Roman, The cause of it was that, during committing the patch (r337811), svn skipped over an empty directory that was required for my test case. I've submitted a fix in a follow-up commit (r337813). Thanks. In https://reviews.llvm.org/D46230#1173063, @lebedev.ri w

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1167023, @echristo wrote: > In https://reviews.llvm.org/D46230#1166958, @gaijiading wrote: > > > In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > > > > > LGTM. > > > > > > -eric > > > > > > Hi Eric, I do not have commit

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1167023, @echristo wrote: > In https://reviews.llvm.org/D46230#1166958, @gaijiading wrote: > > > In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > > > > > LGTM. > > > > > > -eric > > > > > > Hi Eric, I do not have commit

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > LGTM. > > -eric Hi Eric, I do not have commit access to trunk. Could you commit the change for me? Thanks. Repository: rC Clang https://reviews.llvm.org/D46230 ___

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. Thanks very much for the comments and the review. Repository: rC Clang https://reviews.llvm.org/D46230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading updated this revision to Diff 156117. gaijiading added a comment. Include the full context in the update diff. Repository: rC Clang https://reviews.llvm.org/D46230 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/Inputs/ami_linux_tree/usr/lib/gcc/x86_64-amazon-linux/7/crtbegin

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading updated this revision to Diff 156018. gaijiading removed reviewers: mcrosier, fedor.sergeev. gaijiading added a comment. Add a test case to cover this. Repository: rC Clang https://reviews.llvm.org/D46230 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/Inputs/ami_linux_tree/u

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1106086, @echristo wrote: > Well, that's ridiculous. We should really fix this a better way in the future. > > That said, would you add a testcase for this please so we don't regress if we > fix it? :) > > -eric Thanks Eric for the

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading created this revision. gaijiading added a reviewer: rsmith. gaijiading added a project: clang. Herald added a subscriber: cfe-commits. For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux.