[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

int3 added inline comments. Comment at: lld/test/MachO/cspgo-gen.ll:13 + +define void @_start() { +entry: doesn't *really* matter since you are creating a dylib, but `lld-macho` doesn't actually treat `_start` as a special symbol (only `main`). maybe rename to

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lld/MachO/UnwindInfoSection.cpp:346 -// If we have DWARF unwind info, create a CU entry that points to it. +// If we have DWARF unwind info, set the DW

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

int3 added a comment. I'm trying to add similar support to lld-macho, hence the question :) Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( Any re

[PATCH] D144638: [lit] Detect Consistent File Access Times

int3 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that require +# consistent atime. lenary wrote: > jhenderson wrote: > > Is "hopefully" really needed here?

[PATCH] D144482: [clang][docs] Document ThinLTO options for ld64.lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. int3 marked an inline comment as done. Closed by commit rGb0bf3e66d087: [clang][docs] Document ThinLTO options for ld64.lld (authored by int3). Changed prior to commit

[PATCH] D144482: [clang][docs] Document ThinLTO options for ld64.lld

int3 created this revision. int3 added reviewers: lld-macho, tejohnson, lgrey. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO-cach

[PATCH] D137338: Fix dupe word typos

int3 added a comment. lld/MachO changes lgtm Comment at: lld/MachO/Driver.cpp:1386 // ld64 does something really weird. It attempts to realign the value to the -// page size, but assumes the the page size is 4K. This doesn't work with +// page size, but assumes th

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dbfc4fc065d: [clang] Document -femit-compact-unwind option in the User’s Manual (authored by int3). Changed prior to commit: https://reviews.llvm

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

int3 updated this revision to Diff 444740. int3 retitled this revision from "[clang] Document -femit-compact-unwind flag in the User’s Manual" to "[clang] Document -femit-compact-unwind option in the User’s Manual". int3 added a comment. option Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 added a comment. @davide just adding you in case you have opinions on the wording around the bincompat issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129772/new/ https://reviews.llvm.org/D129772 _

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 created this revision. int3 added reviewers: lld-macho, davide. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129772 Files: clang/d

[PATCH] D127630: [MC] Fix likely uninitialized memory bug

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4a21e1644f2: [MC] Fix likely uninitialized memory bug (authored by int3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127630/new/ https://reviews.llvm.or

[PATCH] D127630: [MC] Fix likely uninitialized memory bug

int3 created this revision. int3 added reviewers: lld-macho, uabelho. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See https://reviews.llvm.org/D122258#inline-1223493. I can't repro the issue locally but

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:323-329 + if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) { +Opts.EmitDwarfUnwind = +llvm::StringSwitch(A->getValue()) +.Case("always", EmitDwarfUnwindType::Always) +

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Actually let me try it now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Oh dear. Hmm does running the test with ASAN enabled hit any memory issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commit

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. d'oh, I see it now. And of course the parent `llvm/test/MC/MachO` directory is gated to x86-only. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Buildbots gave me a bunch of errors of the form /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llvm-mc: error: unable to get target for 'arm64-apple-macos11.0', see --version and --triple. I'm wondering if I'm just missing a REQUIRES line, but th

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible (authored by int3). Changed prior to commit: https://reviews

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 marked 3 inline comments as done. int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCR

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427509. int3 added a comment. make things work under cc1as too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427398. int3 added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427396. int3 retitled this revision from "[MC] Omit DWARF unwind info if compact unwind is present for all archs" to "[MC] Omit DWARF unwind info if compact unwind is present where eligible". int3 edited the summary of this revision. int3 added a comment. Herald

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425953. int3 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/O

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425944. int3 added a comment. add --no-force-dwarf-unwind-info; only omit by default on aarch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/cl

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. Thanks for the feedback! > The binary compatibility issue is non-existent on arm64, but it could be > still a thing on x86_64. Can we enable `OmitDwarfIfHaveCompactUnwind` by default on arm64 then? And have it be opt-in just for x86_64? Repository: rG LLVM Github Mono

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added inline comments. Comment at: llvm/lib/CodeGen/MachineModuleInfo.cpp:69 MMI.TM.getMCRegisterInfo(), MMI.TM.getMCSubtargetInfo(), nullptr, - nullptr, false), + &MMI.TM.Options.MCOptions, false), MachineFunctions(std::move(M

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 425408. int3 marked an inline comment as done. int3 added a comment. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. use MCTargetOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/n

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. bump @lhames @JDevlieghere would either of y'all be able to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits m

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 424044. int3 edited the summary of this revision. int3 added a comment. Herald added a subscriber: pengfei. fix x86 backend's omission of DWARF unwind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ http

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. This is ready for review, please take a look 🙏 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 423532. int3 added a comment. Herald added a subscriber: dexonsmith. - Use a separate ForceDwarfUnwindInfo flag - Fix the remaining tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.l

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 marked an inline comment as done. int3 added inline comments. Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:131-132 + size_t Size) { + if (Size == 0) +return; registerEHFramesInProcess(Addr, Size);

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. I'm currently working on the eh_frame support in LLD itself, but will circle back to this diff in a week or so. Thanks for the feedback! Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:48 +// FIXME TEST(InterpreterT

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:66-67 - if (T.isWatchABI()) -OmitDwarfIfHaveCompactUnwind = true; @MaskRay > I vaguely remember there is a place where DWARF unwind info is enabled for > all but few environments

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 created this revision. int3 added reviewers: davide, kledzik, lhames. Herald added subscribers: StephenFan, cmtice, hiraditya, kristof.beyls, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. int3 requested review of this revision.

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. Ohh gotcha. So clang assumes that the platform linker's version is at least as high as the host linker's, assuming the host linker is ld64. That seems kind of hacky, but I suppose it's existing be

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

int3 added a comment. Would it make sense to have clang pass `-object_path_lto` whenever it's invoking LLD? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122110/new/ https://reviews.llvm.org/D122110 ___

[PATCH] D122109: [CMake][Clang] Skip host link version detection for lld on Darwin

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122109/new/ https://reviews.llvm.org/D122109 ___

[PATCH] D119612: [clang] Pass more flags to ld64.lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shoul

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm. Could you make a post to llvm-dev before landing this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99811/new/ https://reviews.llvm.org/D99811 ___ cfe-c

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG18fa1d380d6c: [clang+lld] Pass -platform_version args to ld64.lld (authored by int3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97741/new/ https://revie

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

int3 created this revision. int3 added reviewers: lld-macho, thakis. Herald added subscribers: steven_wu, hiraditya. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that ld64.lld points to the new Darwin backend, we can pass it the

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

int3 added a comment. I've reverted the clang driver changes for now in rG922de2574c17a755279358be928e5343dcf56c56 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

int3 added a comment. Thanks for the heads up. Looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG415c0cd698a8: [lld-macho] Switch default to new Darwin backend (authored by int3). Herald added a project: lld-macho. Changed prior to commit: htt

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

int3 updated this revision to Diff 327145. int3 added a comment. keep around darwinnew link for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/test/Drive

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

int3 updated this revision to Diff 321921. int3 marked an inline comment as done. int3 added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/te

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

int3 updated this revision to Diff 321001. int3 added a subscriber: gkm. int3 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/test/Dri

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

int3 updated this revision to Diff 320940. int3 retitled this revision from "[lld-macho] switch default to new Darwin port" to "[lld-macho] Switch default to new Darwin port". int3 edited the summary of this revision. int3 edited reviewers, added: thakis; removed: gkm. int3 added a comment. updat

[PATCH] D76452: Use LLD by default for Android.

int3 added a comment. Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the `DarwinNew` flavor. I'm not sure if anything depends on the old `Darwin` flavor, which is why we haven't removed it yet, though we plan to do that once we get the new im

[PATCH] D76452: Use LLD by default for Android.

int3 added a comment. I don't think I have enough context here to answer the question, but I'm pretty sure that change wouldn't affect what I'm working on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452