jwtowner marked 2 inline comments as done.
jwtowner added a comment.
> Thanks! What name and email address would you like me to use for patch
> attribution?
The following will do:
Jesse Towner
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103385
jwtowner marked 2 inline comments as done.
jwtowner added a comment.
It should be good to go. I do not have commit access so feel free to commit.
Thanks!
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34
+ template,A&&...>
jwtowner updated this revision to Diff 361289.
jwtowner added a comment.
Improved the code formatting of the samples in the documentation and added back
in the newline at the end of the bugprone-forwarding-reference-overload.rst
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jwtowner added a comment.
Friendly bump in case this was missed. Without this fix,
bugprone-forwarding-reference-overload is not currently usable in a lot of
codebases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103385/new/
https://reviews.llv
jwtowner added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp:83
+ hasType(isEnableIf()),
+ anyOf(hasDescendant(cxxBoolLiteral()),
+hasDescendant(cxxNullPtrLiteralE
jwtowner created this revision.
jwtowner added reviewers: alexfh, aaron.ballman, hokein.
Herald added a subscriber: xazax.hun.
jwtowner requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Many concepts emulation libraries, such as t
