[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Thank you! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. No problem. :) Jesko Appelfeller, je...@appelfeller.eu please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Thanks for accepting. Do I need to do anything to get this merged or is this basically done? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I'm not so much opposed to writing a test case for the one change I made (especially after @salman-javed-nz suggestion) as I am opposed to learning the build system. I've tried to set for a few minutes and oh man, that's a lot of targets... So yeah, If someone could mer

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. In D118104#3294883 , @LegalizeAdulthood wrote: > What is the feasibility of Python unit tests Instead of a heavy-weight `lit` > oriented test? I don't know the code-base well enough to answer that. Is python used for testing pu

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Well, since this was more of source of confusion than actual incorrect behaviour, I don't think there should be a test for it. In general though, I think the script is complex enough to warrant some testing. That being said: I don't think they should be part of this patc

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. In D118104#3279654 , @njames93 wrote: > In D118104#3279524 , @JesApp wrote: > >> I can (re)start a build manually. Let's see how that goes, before we start >> doing workarounds like that.

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I can (re)start a build manually. Let's see how that goes, before we start doing workarounds like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailin

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Anyone have an idea why it's still building? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp updated this revision to Diff 403541. JesApp marked 2 inline comments as done. JesApp added a comment. Resubmitting the same changes after rebasing onto current main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 Files: clang-tools-

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I'm new to phabricator, buildkite, your whole setup. Any idea why the patch fails? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp updated this revision to Diff 403244. JesApp added a comment. As requested by @carlosgalvezp, this update uses the get_tidy_invocation function, rather than building it's own test invocation. I chose to pass all arguments of the script, in case any of them ever have an impact on what is

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. See this github issue for the bug this fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 _

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp created this revision. JesApp added a reviewer: alexfh. JesApp added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. JesApp requested review of this revision. Herald added a subscriber: cfe-commits. The test invocation at the start of run-clang-tidy.py (line 257) pri