[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

Jeroen added a comment. Will it also add braces if they where not there yet? Comment at: clang/unittests/Format/FormatTest.cpp:25374 verifyFormat("if (a) {\n" " b = c >= 0 ? d\n" " : e;\n" Will it also add braces

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

Jeroen added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:442 +if (PrimaryCheckValue != Value) { + std::cout << "Alias check \"" << CheckName.str() << "\" of \"" +<< PrimaryCheckName.str() << "\"" I'

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

Jeroen added a comment. In D14484#2788953 , @FStefanni wrote: > Hi, > > in case of any doubt: yet it is of interest. > 6 years old means only that it has not been "fixed" in the meanwhile... > > Please consider that there are not many code formatters for C

[PATCH] D87244: [clang] Add fix-it for -Wreorder-ctor.

Jeroen added inline comments. Comment at: clang/test/SemaCXX/warn-reorder-ctor-initialization.cpp:171 + // code can't do this. + Bar(int x) : c(x), /*foo*/ a(2), b(3) {} // expected-warning {{field 'c' will be initialized after field 'a'}} + // CHECK-NOT: fix-it:"{{.*}}":{[[@

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

Jeroen added a comment. In the reproduction of https://bugs.llvm.org/show_bug.cgi?id=33236 there is explicit mentioning of `const T`. It would be nice if the test cases for this fix would also have coverage for that. Comment at: clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp:15 t