[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

jeremyd2019 added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS clang-tidy-headers

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 updated this revision to Diff 377590. jeremyd2019 added a comment. Switched to #ifdef _WIN32 instead of checking triple CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index:

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Also, I don't have push access so someone would need to push this for me assuming it is approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Note that I found this due to a report of a crash in clangd , but I don't actually use that so just looked through the code for what was messing with paths. Users on that bug report confirmed that this fixed thei

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 created this revision. jeremyd2019 added reviewers: mstorsjo, rsmith. jeremyd2019 added a project: clang. jeremyd2019 requested review of this revision. Herald added a subscriber: cfe-commits. Previously it only used Windows command lines for MSVC triples, but this was causing issues