Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-06-02 Thread Jean-Baptiste Lespiau via cfe-commits
> print_policy(ast.GetASTContext().getLangOpts()); > >>>>> print_policy.FullyQualifiedName = 1; > >>>>> print_policy.SuppressScope = 0; > >>>>> print_policy.PrintCanonicalTypes = 1; > >>>>> print_policy.GlobalSco

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-05-25 Thread Jean-Baptiste Lespiau via cfe-commits
; Clang, and then fix Clif is doable as it does not imply to fix all calls in >>> one go. >>> >>> I just wanted to develop these points. >>> >> >> Sure enough - appreciate the awareness of the cost to external clients, >> to be sure. >

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-05-12 Thread Jean-Baptiste Lespiau via cfe-commits
t;> >>> +Mr. Smith for visibility. >>> >>> I'm /guessing/ the right path might be to change the implementation of >>> getFullyQualifiedName to use the type printing/pretty printer approach with >>> the extra feature you're suggesting. Tha

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-05-12 Thread Jean-Baptiste Lespiau via cfe-commits
different (better? worse?) > to answer this question - or the tooling uses in LLVM proper just don't > have the same needs?). So probably best not to leave a buggy implementation > lying around - either deleting it, or fixing it. > > On Mon, May 11, 2020 at 11:28 PM Jean-Baptiste L

Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-05-11 Thread Jean-Baptiste Lespiau via cfe-commits
Hi, *Context and history:* I have found a bug in CLIF , which does not correctly fully qualify templated names when they are nested, e.g. ::tensorfn::Nested< ::std::variant > should have been: ::tensorfn::Nested< ::std::variant<::tensorflow::Tensor,::tensorfn::D